From: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
To: selinux@vger.kernel.org
Subject: [PATCH] libsepol: error in CIL if a permission cannot be resolved
Date: Thu, 13 Jun 2019 16:18:27 -0400 [thread overview]
Message-ID: <20190613201827.8616-1-yuli@crunchydata.com> (raw)
In the following example, "relabeltoo" is not a valid permission
in the loaded policy nor in the new module. Before, CIL would not
complain about the invalid permission and proceed to install the module:
$ cat test.cil
(mlsconstrain (db_procedure (create relabeltoo)) (eq l2 h2))
With this patch, an error is now prompted to a user:
$ sudo semodule -i foo.cil
Failed to resolve permission relabeltoo
Failed to resolve mlsconstrain statement at /etc/selinux/mls/tmp/modules/400/test/cil:1
semodule: Failed!
Signed-off-by: Yuli Khodorkovskiy <yuli@crunchydata.com>
---
libsepol/cil/src/cil_resolve_ast.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libsepol/cil/src/cil_resolve_ast.c b/libsepol/cil/src/cil_resolve_ast.c
index ea08087d..22d37f05 100644
--- a/libsepol/cil/src/cil_resolve_ast.c
+++ b/libsepol/cil/src/cil_resolve_ast.c
@@ -135,8 +135,11 @@ static int __cil_resolve_perms(symtab_t *class_symtab, symtab_t *common_symtab,
if (class_flavor == CIL_MAP_CLASS) {
cil_log(CIL_ERR, "Failed to resolve permission %s for map class\n", (char*)curr->data);
goto exit;
+ } else if (class_flavor == CIL_CLASS) {
+ cil_log(CIL_ERR, "Failed to resolve permission %s\n", (char*)curr->data);
+ goto exit;
}
- cil_log(CIL_WARN, "Failed to resolve permission %s\n", (char*)curr->data);
+
/* Use an empty list to represent unknown perm */
cil_list_init(&empty_list, perm_strs->flavor);
cil_list_append(*perm_datums, CIL_LIST, empty_list);
--
2.19.0
next reply other threads:[~2019-06-13 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 20:18 Yuli Khodorkovskiy [this message]
2019-06-14 15:35 ` [Non-DoD Source] [PATCH] libsepol: error in CIL if a permission cannot be resolved jwcart2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613201827.8616-1-yuli@crunchydata.com \
--to=yuli.khodorkovskiy@crunchydata.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).