From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0054C32792 for ; Mon, 30 Sep 2019 20:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A2C022509 for ; Mon, 30 Sep 2019 20:38:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729775AbfI3Uia (ORCPT ); Mon, 30 Sep 2019 16:38:30 -0400 Received: from mx1.polytechnique.org ([129.104.30.34]:39623 "EHLO mx1.polytechnique.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730437AbfI3Uia (ORCPT ); Mon, 30 Sep 2019 16:38:30 -0400 Received: from localhost.localdomain (85-168-38-217.rev.numericable.fr [85.168.38.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id E6E4E564866 for ; Mon, 30 Sep 2019 22:22:35 +0200 (CEST) From: Nicolas Iooss To: selinux@vger.kernel.org Subject: [PATCH 1/2] libsemanage/tests: return when str is NULL Date: Mon, 30 Sep 2019 22:22:10 +0200 Message-Id: <20190930202211.781578-1-nicolas.iooss@m4x.org> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Mon Sep 30 22:22:36 2019 +0200 (CEST)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org CU_FAIL() does not stop the execution flow. This issue has been found using Infer static analyzer. Signed-off-by: Nicolas Iooss --- libsemanage/tests/test_utilities.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libsemanage/tests/test_utilities.c b/libsemanage/tests/test_utilities.c index ba995b5ae094..fa3a077f5e92 100644 --- a/libsemanage/tests/test_utilities.c +++ b/libsemanage/tests/test_utilities.c @@ -142,6 +142,7 @@ void test_semanage_split_on_space(void) if (!str) { CU_FAIL ("semanage_split_on_space: unable to perform test, no memory"); + return; } temp = semanage_split_on_space(str); CU_ASSERT_STRING_EQUAL(temp, "bar baz"); -- 2.22.0