[PATCH 1/2] docs: sysctl: update description for inode-state

[PATCH 1/2] docs: sysctl: update description for inode-state

[Masatake YAMATO]

The third field of inode-state is dummy (== 0).
Update the description about the actual fields and
dummies.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
 Documentation/admin-guide/sysctl/fs.rst | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
index 2a45119e3331..596f84a1748d 100644
--- a/Documentation/admin-guide/sysctl/fs.rst
+++ b/Documentation/admin-guide/sysctl/fs.rst
@@ -151,18 +151,15 @@ out of inodes, you need to increase this value.
 The file inode-nr contains the first two items from
 inode-state, so we'll skip to that file...
 
-Inode-state contains three actual numbers and four dummies.
-The actual numbers are, in order of appearance, nr_inodes,
-nr_free_inodes and preshrink.
+Inode-state contains two actual numbers and five dummies.
+The actual numbers are, in order of appearance, nr_inodes
+and nr_free_inodes.
 
 Nr_inodes stands for the number of inodes the system has
 allocated, this can be slightly more than inode-max because
 Linux allocates them one pageful at a time.
 
-Nr_free_inodes represents the number of free inodes (?) and
-preshrink is nonzero when the nr_inodes > inode-max and the
-system needs to prune the inode list instead of allocating
-more.
+Nr_free_inodes represents the number of free inodes.
 
 
 overflowgid & overflowuid
-- 
2.17.2

[PATCH 2/2] docs: sysctl: delete the description about inode-max

[Masatake YAMATO]

The code for inode-max was deleted long time ago
(< Linux-2.6.12-rc2).

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
---
 Documentation/admin-guide/sysctl/fs.rst | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
index 596f84a1748d..5a99e37b5000 100644
--- a/Documentation/admin-guide/sysctl/fs.rst
+++ b/Documentation/admin-guide/sysctl/fs.rst
@@ -33,7 +33,6 @@ Currently, these files are in /proc/sys/fs:
 - dquot-nr
 - file-max
 - file-nr
-- inode-max
 - inode-nr
 - inode-state
 - nr_open
@@ -136,18 +135,12 @@ enough for most machines. Actual limit depends on RLIMIT_NOFILE
 resource limit.
 
 
-inode-max, inode-nr & inode-state
+inode-nr & inode-state
 ---------------------------------
 
 As with file handles, the kernel allocates the inode structures
 dynamically, but can't free them yet.
 
-The value in inode-max denotes the maximum number of inode
-handlers. This value should be 3-4 times larger than the value
-in file-max, since stdin, stdout and network sockets also
-need an inode struct to handle them. When you regularly run
-out of inodes, you need to increase this value.
-
 The file inode-nr contains the first two items from
 inode-state, so we'll skip to that file...
 
@@ -156,8 +149,7 @@ The actual numbers are, in order of appearance, nr_inodes
 and nr_free_inodes.
 
 Nr_inodes stands for the number of inodes the system has
-allocated, this can be slightly more than inode-max because
-Linux allocates them one pageful at a time.
+allocated.
 
 Nr_free_inodes represents the number of free inodes.
 
-- 
2.17.2

Re: [PATCH 1/2] docs: sysctl: update description for inode-state

[Stephen Smalley]

On 10/28/19 8:43 AM, Masatake YAMATO wrote:
> The third field of inode-state is dummy (== 0).
> Update the description about the actual fields and
> dummies.

These are not patches for SELinux and hence should not go to the selinux 
mailing list. Use scripts/get_maintainer.pl for some suggestions on the 
right set of maintainers and lists.

> 
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
> ---
>   Documentation/admin-guide/sysctl/fs.rst | 11 ++++-------
>   1 file changed, 4 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/admin-guide/sysctl/fs.rst b/Documentation/admin-guide/sysctl/fs.rst
> index 2a45119e3331..596f84a1748d 100644
> --- a/Documentation/admin-guide/sysctl/fs.rst
> +++ b/Documentation/admin-guide/sysctl/fs.rst
> @@ -151,18 +151,15 @@ out of inodes, you need to increase this value.
>   The file inode-nr contains the first two items from
>   inode-state, so we'll skip to that file...
>   
> -Inode-state contains three actual numbers and four dummies.
> -The actual numbers are, in order of appearance, nr_inodes,
> -nr_free_inodes and preshrink.
> +Inode-state contains two actual numbers and five dummies.
> +The actual numbers are, in order of appearance, nr_inodes
> +and nr_free_inodes.
>   
>   Nr_inodes stands for the number of inodes the system has
>   allocated, this can be slightly more than inode-max because
>   Linux allocates them one pageful at a time.
>   
> -Nr_free_inodes represents the number of free inodes (?) and
> -preshrink is nonzero when the nr_inodes > inode-max and the
> -system needs to prune the inode list instead of allocating
> -more.
> +Nr_free_inodes represents the number of free inodes.
>   
>   
>   overflowgid & overflowuid
> 

Re: [PATCH 1/2] docs: sysctl: update description for inode-state

[Masatake YAMATO]

I'm sorry. Plesae, ignore my two mails.

Masatake YAMATO

> On 10/28/19 8:43 AM, Masatake YAMATO wrote:
>> The third field of inode-state is dummy (== 0).
>> Update the description about the actual fields and
>> dummies.
> 
> These are not patches for SELinux and hence should not go to the
> selinux mailing list. Use scripts/get_maintainer.pl for some
> suggestions on the right set of maintainers and lists.
> 
>> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
>> ---
>>   Documentation/admin-guide/sysctl/fs.rst | 11 ++++-------
>>   1 file changed, 4 insertions(+), 7 deletions(-)
>> diff --git a/Documentation/admin-guide/sysctl/fs.rst
>> b/Documentation/admin-guide/sysctl/fs.rst
>> index 2a45119e3331..596f84a1748d 100644
>> --- a/Documentation/admin-guide/sysctl/fs.rst
>> +++ b/Documentation/admin-guide/sysctl/fs.rst
>> @@ -151,18 +151,15 @@ out of inodes, you need to increase this value.
>>   The file inode-nr contains the first two items from
>>   inode-state, so we'll skip to that file...
>>   -Inode-state contains three actual numbers and four dummies.
>> -The actual numbers are, in order of appearance, nr_inodes,
>> -nr_free_inodes and preshrink.
>> +Inode-state contains two actual numbers and five dummies.
>> +The actual numbers are, in order of appearance, nr_inodes
>> +and nr_free_inodes.
>>     Nr_inodes stands for the number of inodes the system has
>>   allocated, this can be slightly more than inode-max because
>>   Linux allocates them one pageful at a time.
>>   -Nr_free_inodes represents the number of free inodes (?) and
>> -preshrink is nonzero when the nr_inodes > inode-max and the
>> -system needs to prune the inode list instead of allocating
>> -more.
>> +Nr_free_inodes represents the number of free inodes.
>>       overflowgid & overflowuid
>> 
>