From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D25D6C35241 for ; Fri, 24 Jan 2020 00:26:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98A3F2087E for ; Fri, 24 Jan 2020 00:26:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="ZovhRzkx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730082AbgAXA0k (ORCPT ); Thu, 23 Jan 2020 19:26:40 -0500 Received: from sonic316-27.consmr.mail.ne1.yahoo.com ([66.163.187.153]:40297 "EHLO sonic316-27.consmr.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730099AbgAXA0k (ORCPT ); Thu, 23 Jan 2020 19:26:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1579825597; bh=JSaMrCw5rIOsb/PJrZw0TEWxJjBXsuaEn7uKyAVvJ7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject; b=ZovhRzkxSE7e5eyTAriw0SW8CrS3ogFHroBK3rDIB29yMgFlJ/vXcdri0CEXGMjxukdM1Tog2fkL6ug6OjdOGbPdYRnd4vYvpivrX19XZb0LvupkRn/HLTF4aVpgmYLi6A4X24wb+7uTtuqLVXkWDX8PxHWGde4ij0W4AjthAP0tJr2WzTk6BWuzC3p+s5agG3g0YqGrgQMunMS+6UeGD8pQC54NXQTNJywRy341fNAb97s4BrG9/ciLGYmoPYxRu0bvSUoehJtCcSJKPBc0SejPi1O48Ufw6VAl9tbPSmHEcb3K2X5yvi3s979ywGfhIvCfstnQxyYDUsOYbDEncg== X-YMail-OSG: 9CWl6VEVM1kgal.dA35A6WxLDkVfmTu_1ZsylAN8nsDW7ZI7p7OMCeg6UWtWvbc xxhKhckZOHnWKHxcIKs9Ano73flp57GXi3kFQooWvFzSaXGiKJDGgzKIeWk8SIjxAk0vTtmvfbBR fUPcp1SDmWUfN28Gee4xCtrcsh519sTb7TEt1eza7rcpMMhgUcozsJWuJfbsW4wMUQqmmAQSLDyY .nupYtgpCgqfwrEXWpV.m8IIaFv.Rn_uM9U1hrNt.OJrEKZsSAnTZhT.FUKpKzoYOM_YE7vCXpvA hYFvQy887gVZeHu5YPFtV1.T.PWOXINpKovgP86S7Mb3OD3._DKBtgYOyif0j_VCWYxTWO_T1Fn_ epX8Nuk5_FhFCWrab1V0YAYGyFVRciN_jOLK3w.CLhymqCkpV95aUm_VJZ4wddIaI6G2bCVh6Z.z klAGwJJXPfuvHI_zyj7fnSHKUNURTZgalxv7GOG45QFhHwEXZCgrMNbjlGLxdNlaRRFCbGuC3jZE Ol9_zSeuB_3_P6ew04gnjEkS4K8Dm8Ox27bBJ1fSJ4.t9KgCbGt0lsvFgBiV1iAn0n_zVA7t.Qlu aRaPjKtkdYFoiZN5568D4uCbrQE1b13uXhYuCJC5FVSBeJp9l.Z5WKWlu2h__tEJ3OVUvZt8PIRX VHBvEui0HD4hlQDsswSAMk5yD.E73pCGw3mSIj5jGpQ9Nh79wooSVSxgepxrankMIFBK4MbKl6Y2 VPfKN3gSSMDDKupRkNu5I3MHRZ4U4zURYXcHm3NWCcUrWiaPOAV7Pasj18Ntv3_bt7BBqmRrqN07 f1RgIJ7x9L3zw_Bp1I_AijFEYPnAAqiVgOe.RXorhuiE0AO_iRugUKoX5rxExHcdACKFk5.HpOLm Nieh0kfbFLah00n3vdMZ0Tct3n0SfNcD0oe8QwO0IMQgBXl8NbINbg3SzPUIrRdhwkH3Rz.OxBvt lojU1.ApGHX4OoOfR7ndLY3abzWYbmBYIl41HprKdmsZKgoZejwXJFMfWfgxfntHCOWPfDm4OfaH 8I0fLvdf7zybEA4sWV0Jue54gq_hZDKXRRv7Pp8CyGQ4U2RWedSdFXSv5rLQbSXwzzf_K6gVAj5c hqsZvEki15COsWaLiVROyPgdzpeXVemKv9agIbYxea9gjr07BDuPc7rbPkJDUM87nARahWIPi_pC riN22jWOvEGn.CrUhpb08.RSd.L5.C6PXsEv1Fhax2DVMJnyrOV7wdOyltedB4RpT7Z7iZuEoNZi lUP4wbaMLjY6Sa9TP_KVOpVQLdrzZn7alVENjPsb1bv1A_7zHfAtLHjgdLXeoKLcZSCg7Rtbp2LA I0w9SfMRN.0ki0.5oRDU0xHhCfRaqU3f0ys_hgqAurtRlpVN0Tdmzi_OpJl.nvNZKw0rOeeZ08zZ Rp0SjFskjREXULI91VqyNUHAMIToXASH.KEKI Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.ne1.yahoo.com with HTTP; Fri, 24 Jan 2020 00:26:37 +0000 Received: by smtp409.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 4426d449a8f49be2e6406d78823572b1; Fri, 24 Jan 2020 00:26:33 +0000 (UTC) From: Casey Schaufler To: casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Cc: casey@schaufler-ca.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov Subject: [PATCH v14 21/23] Audit: Include object data for all security modules Date: Thu, 23 Jan 2020 16:23:04 -0800 Message-Id: <20200124002306.3552-22-casey@schaufler-ca.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200124002306.3552-1-casey@schaufler-ca.com> References: <20200124002306.3552-1-casey@schaufler-ca.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org When there is more than one context displaying security module extend what goes into the audit record by supplimenting the "obj=" with an "obj_=" for each such security module. Acked-by: Stephen Smalley Signed-off-by: Casey Schaufler Cc:linux-audit@redhat.com --- kernel/audit.h | 4 +- kernel/auditsc.c | 106 ++++++++++++++++++++++++----------------------- 2 files changed, 56 insertions(+), 54 deletions(-) diff --git a/kernel/audit.h b/kernel/audit.h index f65f516913c6..9a26ba213f6a 100644 --- a/kernel/audit.h +++ b/kernel/audit.h @@ -78,7 +78,7 @@ struct audit_names { kuid_t uid; kgid_t gid; dev_t rdev; - u32 osid; + struct lsmblob oblob; struct audit_cap_data fcap; unsigned int fcap_ver; unsigned char type; /* record type */ @@ -152,7 +152,7 @@ struct audit_context { kuid_t uid; kgid_t gid; umode_t mode; - u32 osid; + struct lsmblob oblob; int has_perm; uid_t perm_uid; gid_t perm_gid; diff --git a/kernel/auditsc.c b/kernel/auditsc.c index 68ae5fa843c1..7dab48661e31 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -659,7 +659,6 @@ static int audit_filter_rules(struct task_struct *tsk, if (f->lsm_isset) { /* Find files that match */ if (name) { - lsmblob_init(&blob, name->osid); result = security_audit_rule_match( &blob, f->type, @@ -667,7 +666,6 @@ static int audit_filter_rules(struct task_struct *tsk, f->lsm_rules); } else if (ctx) { list_for_each_entry(n, &ctx->names_list, list) { - lsmblob_init(&blob, name->osid); if (security_audit_rule_match( &blob, f->type, @@ -681,8 +679,7 @@ static int audit_filter_rules(struct task_struct *tsk, /* Find ipc objects that match */ if (!ctx || ctx->type != AUDIT_IPC) break; - lsmblob_init(&blob, ctx->ipc.osid); - if (security_audit_rule_match(&blob, + if (security_audit_rule_match(&ctx->ipc.oblob, f->type, f->op, f->lsm_rules)) ++result; @@ -956,13 +953,57 @@ static inline void audit_free_context(struct audit_context *context) kfree(context); } +static int audit_log_object_context(struct audit_buffer *ab, + struct lsmblob *blob) +{ + struct lsmcontext context; + const char *lsm; + int i; + + /* + * None of the installed modules have object labels. + */ + if (security_lsm_slot_name(0) == NULL) + return 0; + + if (blob->secid[0] != 0) { + if (security_secid_to_secctx(blob, &context, 0)) { + audit_log_format(ab, " obj=?"); + return 1; + } + audit_log_format(ab, " obj=%s", context.context); + security_release_secctx(&context); + } + + /* + * Don't do anything more unless there is more than one LSM + * with a security context to report. + */ + if (security_lsm_slot_name(1) == NULL) + return 0; + + for (i = 0; i < LSMBLOB_ENTRIES; i++) { + lsm = security_lsm_slot_name(i); + if (lsm == NULL) + break; + if (blob->secid[i] == 0) + continue; + if (security_secid_to_secctx(blob, &context, i)) { + audit_log_format(ab, " obj_%s=?", lsm); + continue; + } + audit_log_format(ab, " obj_%s=%s", lsm, context.context); + security_release_secctx(&context); + } + return 0; +} + static int audit_log_pid_context(struct audit_context *context, pid_t pid, kuid_t auid, kuid_t uid, unsigned int sessionid, struct lsmblob *blob, char *comm) { struct audit_buffer *ab; - struct lsmcontext lsmctx; int rc = 0; ab = audit_log_start(context, GFP_KERNEL, AUDIT_OBJ_PID); @@ -972,15 +1013,7 @@ static int audit_log_pid_context(struct audit_context *context, pid_t pid, audit_log_format(ab, "opid=%d oauid=%d ouid=%d oses=%d", pid, from_kuid(&init_user_ns, auid), from_kuid(&init_user_ns, uid), sessionid); - if (lsmblob_is_set(blob)) { - if (security_secid_to_secctx(blob, &lsmctx, LSMBLOB_FIRST)) { - audit_log_format(ab, " obj=(none)"); - rc = 1; - } else { - audit_log_format(ab, " obj=%s", lsmctx.context); - security_release_secctx(&lsmctx); - } - } + rc = audit_log_object_context(ab, blob); audit_log_format(ab, " ocomm="); audit_log_untrustedstring(ab, comm); audit_log_end(ab); @@ -1207,26 +1240,14 @@ static void show_special(struct audit_context *context, int *call_panic) context->socketcall.args[i]); break; } case AUDIT_IPC: { - u32 osid = context->ipc.osid; + struct lsmblob *oblob = & context->ipc.oblob; audit_log_format(ab, "ouid=%u ogid=%u mode=%#ho", from_kuid(&init_user_ns, context->ipc.uid), from_kgid(&init_user_ns, context->ipc.gid), context->ipc.mode); - if (osid) { - struct lsmcontext lsmcxt; - struct lsmblob blob; - - lsmblob_init(&blob, osid); - if (security_secid_to_secctx(&blob, &lsmcxt, - LSMBLOB_FIRST)) { - audit_log_format(ab, " osid=%u", osid); - *call_panic = 1; - } else { - audit_log_format(ab, " obj=%s", lsmcxt.context); - security_release_secctx(&lsmcxt); - } - } + if (audit_log_object_context(ab, oblob)) + *call_panic = 1; if (context->ipc.has_perm) { audit_log_end(ab); ab = audit_log_start(context, GFP_KERNEL, @@ -1366,20 +1387,8 @@ static void audit_log_name(struct audit_context *context, struct audit_names *n, from_kgid(&init_user_ns, n->gid), MAJOR(n->rdev), MINOR(n->rdev)); - if (n->osid != 0) { - struct lsmblob blob; - struct lsmcontext lsmctx; - - lsmblob_init(&blob, n->osid); - if (security_secid_to_secctx(&blob, &lsmctx, LSMBLOB_FIRST)) { - audit_log_format(ab, " osid=%u", n->osid); - if (call_panic) - *call_panic = 2; - } else { - audit_log_format(ab, " obj=%s", lsmctx.context); - security_release_secctx(&lsmctx); - } - } + if (audit_log_object_context(ab, &n->oblob) && call_panic) + *call_panic = 2; /* log the audit_names record type */ switch (n->type) { @@ -1929,17 +1938,13 @@ static void audit_copy_inode(struct audit_names *name, const struct dentry *dentry, struct inode *inode, unsigned int flags) { - struct lsmblob blob; - name->ino = inode->i_ino; name->dev = inode->i_sb->s_dev; name->mode = inode->i_mode; name->uid = inode->i_uid; name->gid = inode->i_gid; name->rdev = inode->i_rdev; - security_inode_getsecid(inode, &blob); - /* scaffolding until osid is updated */ - name->osid = blob.secid[0]; + security_inode_getsecid(inode, &name->oblob); if (flags & AUDIT_INODE_NOEVAL) { name->fcap_ver = -1; return; @@ -2285,14 +2290,11 @@ void __audit_mq_getsetattr(mqd_t mqdes, struct mq_attr *mqstat) void __audit_ipc_obj(struct kern_ipc_perm *ipcp) { struct audit_context *context = audit_context(); - struct lsmblob blob; context->ipc.uid = ipcp->uid; context->ipc.gid = ipcp->gid; context->ipc.mode = ipcp->mode; context->ipc.has_perm = 0; - security_ipc_getsecid(ipcp, &blob); - /* scaffolding on the [0] - change "osid" to a lsmblob */ - context->ipc.osid = blob.secid[0]; + security_ipc_getsecid(ipcp, &context->ipc.oblob); context->type = AUDIT_IPC; } -- 2.24.1