From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02243C2BA1A for ; Mon, 6 Apr 2020 20:32:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCC6C2072A for ; Mon, 6 Apr 2020 20:32:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="lrkE7qnV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbgDFUc5 (ORCPT ); Mon, 6 Apr 2020 16:32:57 -0400 Received: from sonic306-27.consmr.mail.ne1.yahoo.com ([66.163.189.89]:44291 "EHLO sonic306-27.consmr.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgDFUc5 (ORCPT ); Mon, 6 Apr 2020 16:32:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1586205174; bh=07RxbwAYxdKzaEWFrRtckoqoMx7n8almVlTczK2aHcA=; h=From:To:Cc:Subject:Date:References:From:Subject; b=lrkE7qnVJvcck5DaeKO4o7c5UV653Jt+DfUDWwqRHjEcEki+VfkvBZ6OpLGNw1u1JYBnjXhBAcp4KNteAsvuYpKv2Ee5hGmFnOXelwKxO039ua2eDhMVnz64Yw3m97MP1gzGykE4q6G3nBcDU1cFEfmdIz2SUlAPCunuONQLdr6K5/PxNXkdVBqk4H9Z2nBEenSqX+RWqw6JpHVay7pP7PxOnEX4zjyBz1C9QNw+r1un9XdBcrfQpuB4frHHKNHMP1+k0XfIThuJjkJUZSwjiWjq6Tyox7ve02R2+PuuRBTHAo/bomirr4Pd7WXwFs5RQeto+ZspzRywDEq+IEbNew== X-YMail-OSG: lH9F04gVM1nMivSZuKm7G6EApfHXCIlg4_rrmUYSozSpf0yR_W3grRDJSDhVYiD gkp.hSWOLzzUF_zYHZ_PDMgzSE7pYN6ep2qoPUOQqm7fCj9nJ3oi0ys45MKZxUD2mHaXG50ecBxj upFB2mD9nIb72T9eNRFcU9CcCD2KkdC4jI9Psgl2EaN9tyIvK_Og7GGBYV2ETqvoBX83OeNzu_q3 2gdRcmnD.7bBBNsACBp422izrx7I4uV_Ihk1Yzhix8GAO1s6MsCzXGBw4rgwxUT2A_Hs_rncYn7m pcYgmPYjz4XsVTvWpIUspHwkGi6Doo6JazYYVq.hdNgnsdSNe7OuG2CoCCXT3C2c8LA94NmwUoJc TKtUBR8OSqi4zQPoiFMG2FaBCXfpEk2ISQso3yExXA8n9OSTO6bFiPOy1oQNBrnGDcW9isK1zEEY C4tYvZ4ZsvXfq1YiPU_N_W4eL5JMp7IMXrXgJZe7Q.Iyx.nnROiMblzBTvxuVVxDk1E57.NhVGeA b1N1spAWkfQ0HWLp3OZJfGiI1bFh2kqtd9PDV2XCG_DDUUyOkXkWATMVsbmsgT_c3ekPICGYv8Sn aNMvauSuSC0h_gQhVPCv6aCSQVB97A4zmqq1SCGvAtl9sFe9c_KThe46ue3J1ih1LQmp8Qx0liq_ kA704q3vMifttQzjtUAbS0XPYyU.NnBQBM8vv.psBDYB_sMcAB.TO8RfxyzsuPtdLd3s1kdxtwjn bhoNa4xg.zmllXvuLbUd1KVynRl4WNO6hkWQai3.OcLFj87oIRcSDEu8vCccXG5oN7M0BkCyNba_ FJ7AcECt75YrOaEKIW7J.82CxtXokmCuOVmdqlNThzRdG2EOd2ATvt_MLttUVqf5wewJhjmgMcs5 KLLOtqG4tmeYjn3bP_3LQx04oE8Vz2qofUWxIaHGB2.5CbXhN.gH5MWAROlEzXI4lLQ4dYGSK6RL .ta.FVfx4djand.h_6dea.943fun0B1Un85twIgxx.ULFMdwFm2d9u4HQ6GgNnmW6cpRX0g3IQR8 WbYU9VsAmWCdWwAqdw.L.5QYZ1_NG_Py9FXwtKMUKkxE_M5QIr3k4hQR9ae0KKu8zbvLeiPiwqqS Lz1a5VvcAszsmsCTb0atOcHhZ_irZVbFnAT0fdH41rxKQAHVH63gx3qFl5JOuBetXTRGbCdRlymk TdO5X4yjeEpAf4cyx0Wz7xd8VdWO4q8u84HmZuQIgw2mdpqA5MuGy23icE.oVtyIw2jyuxo3Y.kw W0.FwR1vNZzcOwG8cBWjr9.JCg.5fZZ0RzyuWBrCFowMScRudTvUHZJGF8suyAODuPm4l1zctk1U 0E9_Sfct1_aSv23ojzIkiJfUxvpNKeNavWjwwKBDFhR_LIMRaTwmsqsnY_.rsrHWPRGB4sX0Vhqx 49tMmI7GDpwZVrV1mNQEFRIieFvxrUZCY3_ioqbbsOjxSS_bkgrRvojnl3tKt7x9xoBJk Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Mon, 6 Apr 2020 20:32:54 +0000 Received: by smtp425.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 9fcf7e00425023fdab52f7ee4fe38a97; Mon, 06 Apr 2020 20:32:49 +0000 (UTC) From: Casey Schaufler To: casey.schaufler@intel.com, jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Cc: casey@schaufler-ca.com, keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov, linux-audit@redhat.com Subject: [PATCH v15 00/23] LSM: Module stacking for AppArmor Date: Mon, 6 Apr 2020 13:32:46 -0700 Message-Id: <20200406203246.42079-1-casey@schaufler-ca.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <20200406203246.42079-1-casey.ref@schaufler-ca.com> Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org This patchset provides the changes required for the AppArmor security module to stack safely with any other. v16: Rebase to 5.6 Incorporate feedback from v15 - Thanks Stephen, Mimi and Paul - Generally improve commit messages WRT scaffolding - Comment ima_lsm_isset() (patch 0002) - Some question may remain on IMA warning (patch 0002) - Mark lsm_slot as __lsm_ro_after_init not __init_data (patch 0002) - Change name of lsmblob variable in ima_match_rules() (patch 0003) - Instead of putting a struct lsmblob into the unix_skb_parms structure put a pointer to an allocated instance. There is currently only space for 5 u32's in unix_skb_parms and it is likely to get even tighter. Fortunately, the lifecycle management of the allocated lsmblob is simple. (patch 0005) - Dropped Acks due to the above change (patch 0005) - Improved commentary on secmark labeling scaffolding. (patch 0006) - Reduced secmark related labeling scaffolding. (patch 0006) - Replace use of the zeroth entry of an lsmblob in scaffolding with a function lsmblob_value() to hopefully make it less obscure. (patch 0006) - Convert security_secmark_relabel_packet to use lsmblob as this reduces much of the most contentious scaffolding. (patch 0006) - Dropped Acks due to the above change (patch 0006) - Added BUILD_BUG_ON() for CIPSO tag 6. (patch 0018) - Reworked audit subject information. Instead of adding fields in the middle of existing records add a new record to the event. When a separate record is required use subj="?". (patch 0020) - Dropped Acks due to the above change (patch 0020) - Reworked audit object information. Instead of adding fields in the middle of existing records add a new record to the event. When a separate record is required use obj="?". (patch 0021) - Dropped Acks due to the above change (patch 0021) - Enhanced documentation (patch 0022) - Removed unnecessary error code check in security_getprocattr() (patch 0021) v15: Rebase to 5.6-rc1 - Revise IMA data use (patch 0002) Incorporate feedback from v14 - Fix lockdown module registration naming (patch 0002) - Revise how /proc/self/attr/context is gathered. (patch 0022) - Revise access modes on /proc/self/attr/context. (patch 0022) - Revise documentation on LSM external interfaces. (patch 0022) v14: Rebase to 5.5-rc5 Incorporate feedback from v13 - Use an array of audit rules (patch 0002) - Significant change, removed Acks (patch 0002) - Remove unneeded include (patch 0013) - Use context.len correctly (patch 0015) - Reorder code to be more sensible (patch 0016) - Drop SO_PEERCONTEXT as it's not needed yet (patch 0023) v13: Rebase to 5.5-rc2 Incorporate feedback from v12 - Print lsmblob size with %z (Patch 0002) - Convert lockdown LSM initialization. (Patch 0002) - Restore error check in nft_secmark_compute_secid (Patch 0006) - Correct blob scaffolding in ima_must_appraise() (Patch 0009) - Make security_setprocattr() clearer (Patch 0013) - Use lsm_task_display more widely (Patch 0013) - Use passed size in lsmcontext_init() (Patch 0014) - Don't add a smack_release_secctx() hook (Patch 0014) - Don't print warning in security_release_secctx() (Patch 0014) - Don't duplicate the label in nfs4_label_init_security() (Patch 0016) - Remove reviewed-by as code has significant change (Patch 0016) - Send the entire lsmblob for Tag 6 (Patch 0019) - Fix description of socket_getpeersec_stream parameters (Patch 0023) - Retain LSMBLOB_FIRST. What was I thinking? (Patch 0023) - Add compound context to LSM documentation (Patch 0023) v12: Rebase to 5.5-rc1 Fixed a couple of incorrect contractions in the text. v11: Rebase to 5.4-rc6 Incorporate feedback from v10 - Disambiguate reading /proc/.../attr/display by restricting all use of the interface to the current process. - Fix a merge error in AppArmor's display attribute check v10: Ask the security modules if the display can be changed. v9: There is no version 9 v8: Incorporate feedback from v7 - Minor clean-up in display value management - refactor "compound" context creation to use a common append_ctx() function. v7: Incorporate feedback from v6 - Make setting the display a privileged operation. The availability of compound contexts reduces the need for setting the display. v6: Incorporate feedback from v5 - Add subj_= and obj_= fields to audit records - Add /proc/.../attr/context to get the full context in lsmname\0value\0... format as suggested by Simon McVittie - Add SO_PEERCONTEXT for getsockopt() to get the full context in the same format, also suggested by Simon McVittie. - Add /sys/kernel/security/lsm_display_default to provide the display default value. v5: Incorporate feedback from v4 - Initialize the lsmcontext in security_secid_to_secctx() - Clear the lsmcontext in all security_release_secctx() cases - Don't use the "display" on strictly internal context interfaces. - The SELinux binder hooks check for cases where the context "display" isn't compatible with SELinux. v4: Incorporate feedback from v3 - Mark new lsm__alloc functions static - Replace the lsm and slot fields of the security_hook_list with a pointer to a LSM allocated lsm_id structure. The LSM identifies if it needs a slot explicitly. Use the lsm_id rather than make security_add_hooks return the slot value. - Validate slot values used in security.c - Reworked the "display" process attribute handling so that it works right and doesn't use goofy list processing. - fix display value check in dentry_init_security - Replace audit_log of secids with '?' instead of deleting the audit log v3: Incorporate feedback from v2 - Make lsmblob parameter and variable names more meaningful, changing "le" and "l" to "blob". - Improve consistency of constant naming. - Do more sanity checking during LSM initialization. - Be a bit clearer about what is temporary scaffolding. - Rather than clutter security_getpeersec_dgram with otherwise unnecessary checks remove the apparmor stub, which does nothing useful. Patch 0001 moves management of the sock security blob from the individual modules to the infrastructure. Patches 0002-0012 replace system use of a "secid" with a structure "lsmblob" containing information from the security modules to be held and reused later. At this point lsmblob contains an array of u32 secids, one "slot" for each of the security modules compiled into the kernel that used secids. A "slot" is allocated when a security module requests one. The infrastructure is changed to use the slot number to pass the correct secid to or from the security module hooks. It is important that the lsmblob be a fixed size entity that does not have to be allocated. Several of the places where it is used would have performance and/or locking issues with dynamic allocation. Patch 0013 provides a mechanism for a process to identify which security module's hooks should be used when displaying or converting a security context string. A new interface /proc/self/attr/display contains the name of the security module to show. Reading from this file will present the name of the module, while writing to it will set the value. Only names of active security modules are accepted. Internally, the name is translated to the appropriate "slot" number for the module which is then stored in the task security blob. Setting the display requires that all modules using the /proc interfaces allow the transition. The "display" of other processess can be neither read nor written. All suggested cases for reading the display of a different process have race conditions. Patch 0014 Starts the process of changing how a security context is represented. Since it is possible for a security context to have been generated by more than one security module it is now necessary to note which module created a security context so that the correct "release" hook can be called. There are several places where the module that created a security context cannot be inferred. This is achieved by introducing a "lsmcontext" structure which contains the context string, its length and the "slot" number of the security module that created it. The security_release_secctx() interface is changed, replacing the (string,len) pointer pair with a lsmcontext pointer. Patches 0015-0017 convert the security interfaces from (string,len) pointer pairs to a lsmcontext pointer. The slot number identifying the creating module is added by the infrastructure. Where the security context is stored for extended periods the data type is changed. The Netlabel code is converted to save lsmblob structures instead of secids in Patch 0018. Patch 0019 adds checks to the binder hooks which verify that if both ends of a transaction use the same "display". Patches 0020-0021 add addition audit records to identify the LSM specific data for all active modules. Patch 0022 adds a new interfaces for getting the compound security contexts. Finally, with all interference on the AppArmor hooks removed, Patch 0023 removes the exclusive bit from AppArmor. An unnecessary stub hook was also removed. The Ubuntu project is using an earlier version of this patchset in their distribution to enable stacking for containers. Performance measurements to date have the change within the "noise". The sockperf and dbench results are on the order of 0.2% to 0.8% difference, with better performance being as common as worse. The benchmarks were run with AppArmor and Smack on Ubuntu. https://github.com/cschaufler/lsm-stacking.git#stack-5.6-v16 Signed-off-by: Casey Schaufler ---