From: Ondrej Mosnacek <omosnace@redhat.com>
To: selinux@vger.kernel.org
Subject: [PATCH testsuite] tests/sctp: bump connect timeout to 4 seconds
Date: Thu, 27 Aug 2020 10:11:00 +0200 [thread overview]
Message-ID: <20200827081100.1954467-1-omosnace@redhat.com> (raw)
The current value of 2 seconds causes transient failures too often in
certain slow/unstable environments (including the nested KVM Travis CI
setup). Our experience from downstream testing at Red Hat (across a
variety of HW and architectures) has shown that a value of 4 seconds
yields only very sporadic failures.
Therefore, change the value to 4 to trade off some testing time for more
stability.
Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
---
tests/sctp/sctp_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/sctp/sctp_client.c b/tests/sctp/sctp_client.c
index 595da75..2f527ed 100644
--- a/tests/sctp/sctp_client.c
+++ b/tests/sctp/sctp_client.c
@@ -99,7 +99,7 @@ int main(int argc, char **argv)
* EAGAIN - Resource temporarily unavailable - SOCK_SEQPACKET
* Uses SO_RCVTIMEO when NO connects are called.
*/
- tm.tv_sec = 2;
+ tm.tv_sec = 4;
tm.tv_usec = 0;
result = setsockopt(sock, SOL_SOCKET, SO_SNDTIMEO, &tm, sizeof(tm));
if (result < 0) {
--
2.26.2
next reply other threads:[~2020-08-27 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 8:11 Ondrej Mosnacek [this message]
2020-08-31 14:13 ` [PATCH testsuite] tests/sctp: bump connect timeout to 4 seconds Stephen Smalley
2020-09-03 15:13 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827081100.1954467-1-omosnace@redhat.com \
--to=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).