From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>,
Ondrej Mosnacek <omosnace@redhat.com>,
SElinux list <selinux@vger.kernel.org>,
Linux Security Module list
<linux-security-module@vger.kernel.org>,
mptcp@lists.linux.dev, network dev <netdev@vger.kernel.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Matthieu Baerts <matthieu.baerts@tessares.net>
Subject: Re: Broken SELinux/LSM labeling with MPTCP and accept(2)
Date: Fri, 2 Dec 2022 13:23:32 +0100 [thread overview]
Message-ID: <20221202122332.GC7057@breakpoint.cc> (raw)
In-Reply-To: <48dd1e9b21597c46e4767290e5892c01850a45ff.camel@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> index 99f5e51d5ca4..b8095b8df71d 100644
> --- a/net/mptcp/protocol.c
> +++ b/net/mptcp/protocol.c
> @@ -3085,7 +3085,10 @@ struct sock *mptcp_sk_clone(const struct sock *sk,
> /* will be fully established after successful MPC subflow creation */
> inet_sk_state_store(nsk, TCP_SYN_RECV);
>
> - security_inet_csk_clone(nsk, req);
> + /* let's the new socket inherit the security label from the msk
> + * listener, as the TCP reqest socket carries a kernel context
> + */
> + security_sock_graft(nsk, sk->sk_socket);
> bh_unlock_sock(nsk);
FWIW this makes Ondrejs test case work:
before:
mptcp successfully enabled on unit /usr/lib/systemd/system/nginx.service
% Total % Received % Xferd Average Speed Time Time Time % Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (52) Empty reply from server
With above change:
mptcp successfully enabled on unit /usr/lib/systemd/system/nginx.service
% Total % Received % Xferd Average Speed Time Time Time % Current
Dload Upload Total Spent Left Speed 100 5 100 5 0 0 1770 0 --:--:-- --:--:-- --:--:-- 5000
next prev parent reply other threads:[~2022-12-02 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 13:42 Broken SELinux/LSM labeling with MPTCP and accept(2) Ondrej Mosnacek
2022-12-01 18:26 ` Paolo Abeni
2022-12-02 2:06 ` Paul Moore
2022-12-02 12:07 ` Paolo Abeni
2022-12-02 12:23 ` Florian Westphal [this message]
2022-12-02 20:16 ` Paul Moore
2022-12-05 20:58 ` Paolo Abeni
2022-12-06 14:43 ` Ondrej Mosnacek
2022-12-06 16:51 ` Paolo Abeni
2022-12-08 22:45 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202122332.GC7057@breakpoint.cc \
--to=fw@strlen.de \
--cc=linux-security-module@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).