From: Stephen Smalley <sds@tycho.nsa.gov>
To: Masatake YAMATO <yamato@redhat.com>, selinux@vger.kernel.org
Subject: Re: [PATCH 1/5] dispol: extend usage() to take exit status
Date: Tue, 8 Oct 2019 10:03:59 -0400 [thread overview]
Message-ID: <301d34c5-21b6-e279-ba7f-e983eac12ea0@tycho.nsa.gov> (raw)
In-Reply-To: <20191008064500.8651-3-yamato@redhat.com>
On 10/8/19 2:44 AM, Masatake YAMATO wrote:
> Signed-off-by: Masatake YAMATO <yamato@redhat.com>
You appear to have sent two slightly different versions of this patch?
> ---
> checkpolicy/test/dispol.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/checkpolicy/test/dispol.c b/checkpolicy/test/dispol.c
> index d72d9fb3..6c4829c4 100644
> --- a/checkpolicy/test/dispol.c
> +++ b/checkpolicy/test/dispol.c
> @@ -36,10 +36,10 @@
>
> static policydb_t policydb;
>
> -static __attribute__((__noreturn__)) void usage(const char *progname)
> +static __attribute__((__noreturn__)) void usage(const char *progname, int status)
> {
> printf("usage: %s binary_pol_file\n\n", progname);
> - exit(1);
> + exit(status);
> }
>
> int render_access_mask(uint32_t mask, avtab_key_t * key, policydb_t * p,
> @@ -395,7 +395,7 @@ int main(int argc, char **argv)
> struct policy_file pf;
>
> if (argc != 2)
> - usage(argv[0]);
> + usage(argv[0], 1);
>
> fd = open(argv[1], O_RDONLY);
> if (fd < 0) {
>
next prev parent reply other threads:[~2019-10-08 14:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 6:44 [PATCH 0/5] dispol: add batch execution mode Masatake YAMATO
2019-10-08 6:44 ` [PATCH 1/5] dispol: extend usage() to take error code as an argument Masatake YAMATO
2019-10-08 6:44 ` [PATCH 1/5] dispol: extend usage() to take exit status Masatake YAMATO
2019-10-08 14:03 ` Stephen Smalley [this message]
2019-10-08 6:44 ` [PATCH 2/5] dispol: add an option for printing the command usage Masatake YAMATO
2019-10-09 14:41 ` [Non-DoD Source] " Stephen Smalley
2019-10-08 6:44 ` [PATCH 3/5] dispol: introduce a local variable representing the input file Masatake YAMATO
2019-10-08 6:44 ` [PATCH 4/5] dispol: introduce -b option to run commands in batch Masatake YAMATO
2019-10-08 6:45 ` [PATCH 5/5] dispol: add the list of commands for batch mode to help message Masatake YAMATO
2019-10-08 12:48 ` [PATCH 0/5] dispol: add batch execution mode Stephen Smalley
2019-10-08 14:31 ` Stephen Smalley
2019-10-17 7:12 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=301d34c5-21b6-e279-ba7f-e983eac12ea0@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=yamato@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).