From: Stephen Smalley <sds@tycho.nsa.gov>
To: Petr Lautrbach <plautrba@redhat.com>, selinux@vger.kernel.org
Subject: Re: [PATCH] libselinux/audit2why.so: Filter out non-python related symbols
Date: Tue, 15 Jan 2019 08:57:47 -0500 [thread overview]
Message-ID: <3c3b0512-334d-524a-42be-e966cffa2f4a@tycho.nsa.gov> (raw)
In-Reply-To: <20190115133629.21263-1-plautrba@redhat.com>
On 1/15/19 8:36 AM, Petr Lautrbach wrote:
> audit2why.so used to export libsepol.a symbols. We only need Python related
> symbols:
>
> - initaudit2why for python 2
> - PyInit_audit2why for python3
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> libselinux/src/Makefile | 2 +-
> libselinux/src/audit2why.map | 6 ++++++
> 2 files changed, 7 insertions(+), 1 deletion(-)
> create mode 100644 libselinux/src/audit2why.map
>
> diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> index 8891086e..92e30738 100644
> --- a/libselinux/src/Makefile
> +++ b/libselinux/src/Makefile
> @@ -165,7 +165,7 @@ $(AUDIT2WHYLOBJ): audit2why.c
> $(CC) $(filter-out -Werror, $(CFLAGS)) $(PYINC) -fPIC -DSHARED -c -o $@ $<
>
> $(AUDIT2WHYSO): $(AUDIT2WHYLOBJ) $(LIBSEPOLA)
> - $(CC) $(CFLAGS) $(LDFLAGS) -L. -shared -o $@ $^ -lselinux $(LDLIBS_LIBSEPOLA) $(PYLIBS)
> + $(CC) $(CFLAGS) $(LDFLAGS) -L. -shared -o $@ $^ -lselinux $(LDLIBS_LIBSEPOLA) $(PYLIBS) -Wl,-soname,audit2why.so,--version-script=audit2why.map,-z,defs
>
> %.o: %.c policy.h
> $(CC) $(CFLAGS) $(TLSFLAGS) -c -o $@ $<
> diff --git a/libselinux/src/audit2why.map b/libselinux/src/audit2why.map
> new file mode 100644
> index 00000000..65989a8d
> --- /dev/null
> +++ b/libselinux/src/audit2why.map
> @@ -0,0 +1,6 @@
> +AUDIT2WHY_2.9 {
> + global:
> + initaudit2why;
> + PyInit_audit2why;
> + local: *;
> +};
>
next prev parent reply other threads:[~2019-01-15 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 17:57 RFC: introduce new library versions for added symbols Petr Lautrbach
2019-01-10 18:13 ` Stephen Smalley
2019-01-11 12:24 ` Petr Lautrbach
2019-01-11 16:01 ` Stephen Smalley
2019-01-15 13:36 ` [PATCH] libselinux/audit2why.so: Filter out non-python related symbols Petr Lautrbach
2019-01-15 13:57 ` Stephen Smalley [this message]
2019-01-17 14:18 ` Stephen Smalley
2019-01-17 14:33 ` Stephen Smalley
2019-01-21 12:15 ` Petr Lautrbach
2019-01-24 11:09 ` Petr Lautrbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c3b0512-334d-524a-42be-e966cffa2f4a@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).