* [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping
@ 2019-10-11 7:07 Petr Lautrbach
2019-10-11 7:10 ` Ondrej Mosnacek
2019-10-15 14:22 ` Stephen Smalley
0 siblings, 2 replies; 4+ messages in thread
From: Petr Lautrbach @ 2019-10-11 7:07 UTC (permalink / raw)
To: selinux; +Cc: Petr Lautrbach
There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize
kernel policy") which added new function sepol_policydb_optimize(), but there's
sepol_optimize_policy in libsepol.map.
LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
libsepol/src/libsepol.map.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
index 6358e51f..f4946a79 100644
--- a/libsepol/src/libsepol.map.in
+++ b/libsepol/src/libsepol.map.in
@@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
sepol_polcap_getname;
} LIBSEPOL_1.0;
-LIBSEPOL_1.2 {
+LIBSEPOL_3.0 {
global:
- sepol_optimize_policy;
+ sepol_policydb_optimize;
} LIBSEPOL_1.1;
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping
2019-10-11 7:07 [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping Petr Lautrbach
@ 2019-10-11 7:10 ` Ondrej Mosnacek
2019-10-15 14:22 ` Stephen Smalley
1 sibling, 0 replies; 4+ messages in thread
From: Ondrej Mosnacek @ 2019-10-11 7:10 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: SElinux list
On Fri, Oct 11, 2019 at 9:07 AM Petr Lautrbach <plautrba@redhat.com> wrote:
> There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize
> kernel policy") which added new function sepol_policydb_optimize(), but there's
> sepol_optimize_policy in libsepol.map.
>
> LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: Ondrej Mosnacek <omosnace@redhat.com>
Thanks for spotting it!
> ---
> libsepol/src/libsepol.map.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
> index 6358e51f..f4946a79 100644
> --- a/libsepol/src/libsepol.map.in
> +++ b/libsepol/src/libsepol.map.in
> @@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
> sepol_polcap_getname;
> } LIBSEPOL_1.0;
>
> -LIBSEPOL_1.2 {
> +LIBSEPOL_3.0 {
> global:
> - sepol_optimize_policy;
> + sepol_policydb_optimize;
> } LIBSEPOL_1.1;
> --
> 2.23.0
>
--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping
2019-10-11 7:07 [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping Petr Lautrbach
2019-10-11 7:10 ` Ondrej Mosnacek
@ 2019-10-15 14:22 ` Stephen Smalley
2019-10-17 12:41 ` Stephen Smalley
1 sibling, 1 reply; 4+ messages in thread
From: Stephen Smalley @ 2019-10-15 14:22 UTC (permalink / raw)
To: Petr Lautrbach, selinux
On 10/11/19 3:07 AM, Petr Lautrbach wrote:
> There's a typo in commit b8213acff837101 ("libsepol: add a function to optimize
> kernel policy") which added new function sepol_policydb_optimize(), but there's
> sepol_optimize_policy in libsepol.map.
>
> LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> libsepol/src/libsepol.map.in | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
> index 6358e51f..f4946a79 100644
> --- a/libsepol/src/libsepol.map.in
> +++ b/libsepol/src/libsepol.map.in
> @@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
> sepol_polcap_getname;
> } LIBSEPOL_1.0;
>
> -LIBSEPOL_1.2 {
> +LIBSEPOL_3.0 {
> global:
> - sepol_optimize_policy;
> + sepol_policydb_optimize;
> } LIBSEPOL_1.1;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping
2019-10-15 14:22 ` Stephen Smalley
@ 2019-10-17 12:41 ` Stephen Smalley
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Smalley @ 2019-10-17 12:41 UTC (permalink / raw)
To: Petr Lautrbach, selinux
On 10/15/19 10:22 AM, Stephen Smalley wrote:
> On 10/11/19 3:07 AM, Petr Lautrbach wrote:
>> There's a typo in commit b8213acff837101 ("libsepol: add a function to
>> optimize
>> kernel policy") which added new function sepol_policydb_optimize(),
>> but there's
>> sepol_optimize_policy in libsepol.map.
>>
>> LIBSEPOL_3.0 is used to follow the next release version libsepol-3.0
>>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Thanks, applied.
>
>> ---
>> libsepol/src/libsepol.map.in | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/libsepol/src/libsepol.map.in b/libsepol/src/libsepol.map.in
>> index 6358e51f..f4946a79 100644
>> --- a/libsepol/src/libsepol.map.in
>> +++ b/libsepol/src/libsepol.map.in
>> @@ -60,7 +60,7 @@ LIBSEPOL_1.1 {
>> sepol_polcap_getname;
>> } LIBSEPOL_1.0;
>> -LIBSEPOL_1.2 {
>> +LIBSEPOL_3.0 {
>> global:
>> - sepol_optimize_policy;
>> + sepol_policydb_optimize;
>> } LIBSEPOL_1.1;
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-17 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-11 7:07 [PATCH] libsepol: Use LIBSEPOL_3.0 and fix sepol_policydb_optimize symbol mapping Petr Lautrbach
2019-10-11 7:10 ` Ondrej Mosnacek
2019-10-15 14:22 ` Stephen Smalley
2019-10-17 12:41 ` Stephen Smalley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).