selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Smalley <sds@tycho.nsa.gov>
To: Petr Lautrbach <plautrba@redhat.com>, selinux@vger.kernel.org
Subject: Re: [PATCH] gui: Fix remove module in system-config-selinux
Date: Thu, 26 Sep 2019 08:54:51 -0400	[thread overview]
Message-ID: <7cc0dfdc-f56d-15e9-f99b-a83908d51ec6@tycho.nsa.gov> (raw)
In-Reply-To: <20190924191221.245789-1-plautrba@redhat.com>

On 9/24/19 3:12 PM, Petr Lautrbach wrote:
> When a user tried to remove a policy module with priority other than 400 via
> GUI, it failed with a message:
> 
> libsemanage.semanage_direct_remove_key: Unable to remove module somemodule at priority 400. (No such file or directory).
> 
> This is fixed by calling "semodule -x PRIORITY -r NAME" instead of
> "semodule -r NAME".
> 
>  From Jono Hein <fredwacko40@hotmail.com>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>

Thanks, applied.

> ---
>   gui/modulesPage.py | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gui/modulesPage.py b/gui/modulesPage.py
> index cb856b2d..0584acf9 100644
> --- a/gui/modulesPage.py
> +++ b/gui/modulesPage.py
> @@ -125,9 +125,10 @@ class modulesPage(semanagePage):
>       def delete(self):
>           store, iter = self.view.get_selection().get_selected()
>           module = store.get_value(iter, 0)
> +        priority = store.get_value(iter, 1)
>           try:
>               self.wait()
> -            status, output = getstatusoutput("semodule -r %s" % module)
> +            status, output = getstatusoutput("semodule -X %s -r %s" % (priority, module))
>               self.ready()
>               if status != 0:
>                   self.error(output)
> 


      reply	other threads:[~2019-09-26 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24 19:12 [PATCH] gui: Fix remove module in system-config-selinux Petr Lautrbach
2019-09-26 12:54 ` Stephen Smalley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cc0dfdc-f56d-15e9-f99b-a83908d51ec6@tycho.nsa.gov \
    --to=sds@tycho.nsa.gov \
    --cc=plautrba@redhat.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).