From: Stephen Smalley <sds@tycho.nsa.gov>
To: Vit Mojzis <vmojzis@redhat.com>, selinux@vger.kernel.org
Subject: Re: [PATCH 2/2] python/semanage: Add support for DCCP and SCTP protocols
Date: Wed, 9 Oct 2019 10:39:29 -0400 [thread overview]
Message-ID: <8820fee0-2472-3209-ba5d-1ef957e4d559@tycho.nsa.gov> (raw)
In-Reply-To: <20191008122213.9227-2-vmojzis@redhat.com>
On 10/8/19 8:22 AM, Vit Mojzis wrote:
> Fixes:
> # semanage port -a -p sctp -t port_t 1234
> ValueError: Protocol udp or tcp is required
> # semanage port -d -p sctp -t port_t 1234
> ValueError: Protocol udp or tcp is required
>
> Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
For both patches,
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> python/semanage/seobject.py | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/python/semanage/seobject.py b/python/semanage/seobject.py
> index f4c29854..dc413ca5 100644
> --- a/python/semanage/seobject.py
> +++ b/python/semanage/seobject.py
> @@ -1058,13 +1058,15 @@ class portRecords(semanageRecords):
> pass
>
> def __genkey(self, port, proto):
> - if proto == "tcp":
> - proto_d = SEMANAGE_PROTO_TCP
> + protocols = {"tcp": SEMANAGE_PROTO_TCP,
> + "udp": SEMANAGE_PROTO_UDP,
> + "sctp": SEMANAGE_PROTO_SCTP,
> + "dccp": SEMANAGE_PROTO_DCCP}
> +
> + if proto in protocols.keys():
> + proto_d = protocols[proto]
> else:
> - if proto == "udp":
> - proto_d = SEMANAGE_PROTO_UDP
> - else:
> - raise ValueError(_("Protocol udp or tcp is required"))
> + raise ValueError(_("Protocol has to be one of udp, tcp, dccp or sctp"))
> if port == "":
> raise ValueError(_("Port is required"))
>
>
next prev parent reply other threads:[~2019-10-09 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 12:22 [PATCH 1/2] libsemanage: Add support for DCCP and SCTP protocols Vit Mojzis
2019-10-08 12:22 ` [PATCH 2/2] python/semanage: " Vit Mojzis
2019-10-09 14:39 ` Stephen Smalley [this message]
2019-10-10 19:57 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8820fee0-2472-3209-ba5d-1ef957e4d559@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=vmojzis@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).