From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F7EC35247 for ; Wed, 5 Feb 2020 23:53:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8790D20672 for ; Wed, 5 Feb 2020 23:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="FLa7puDp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727486AbgBEXxJ (ORCPT ); Wed, 5 Feb 2020 18:53:09 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:42672 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727441AbgBEXxJ (ORCPT ); Wed, 5 Feb 2020 18:53:09 -0500 Received: by mail-qv1-f68.google.com with SMTP id dc14so2010965qvb.9 for ; Wed, 05 Feb 2020 15:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/m+6/gHtitRcFwDRfgIzzOezx3KJKRXU/a2k3eD85GU=; b=FLa7puDpv4wlbq05A10ZykfGH59L4UeD7CB9/Lf0OsX0XtUrdga2W2J0Q+VZk30wad oiE997YzvsAZQ2T79shfFhO2SvlFt/d+QfpgrTkPRValXuFvVw2LepfnACEwPO5Gyiph nos0QgbV/Y5frbDSa+0I1SXBgT4/2IWYpNCWdK8KdLShiuvNp75XJ6p3dm8xuH3/Fzrq 8iX7HE8qv1+8grJip7uVWB1mMVU6vTmswrGHASeYxQanYvqlSsO3qK5rUyF9L1iNO+FT 19RjBaO6LHwteGx1OxLouGE98zrOZhI9QrZ1lN4WtgcQUH94krDgJj7Udw/IN/Ji+d/W LyDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/m+6/gHtitRcFwDRfgIzzOezx3KJKRXU/a2k3eD85GU=; b=FG9qxgJfjhShz4bsZBrjVBZssiqTSfwqiH+EAKge9kgZdx3eEqxIhRFTimqEejqHTx dOp6HWbYk9IEkwJxMn9t+xY0CyGyoBuuc1FQnbEYU/Iv73EMoGxF9CxhwI9t0F1iD6Vu TvztQvKcbnRIn5j3eecoa3KtVGbHqAIPeckJO905GvHZRPiLl69Am7ftyspK6s2KXrAH UT8jLQ+SqgEhWD2Vms/pnE2M9klxJqUt6FpRUQdI+PeOq/+F50wmYa67uuxtnQL3q6N4 9brAsd4DdVnz34P95pZCiA/WEs8zU/mrxM0wj4KKtPkwtm46BksHil/fj8dlrX2xo+R9 zkgw== X-Gm-Message-State: APjAAAVpmGMIz1/hm4m7A7EoowrAjuwc98RVwlNwBoiqxMRAvNKCThbv 3mlVOpnMR6ogRGm1bbgtvfFbIXQ/YovzA6zCETZzaA== X-Google-Smtp-Source: APXvYqyzKRTHTvT+l4TdaQr2pk5kOvN2mGmw40JYEsRH+53Jof9zm1ZEoS9/lbvB60SM2gWBa8IruOgj0c8Qd9efzVY= X-Received: by 2002:a0c:cdcb:: with SMTP id a11mr165374qvn.244.1580946787002; Wed, 05 Feb 2020 15:53:07 -0800 (PST) MIME-Version: 1.0 References: <20200202014624.75356-1-hridya@google.com> In-Reply-To: From: Hridya Valsaraju Date: Wed, 5 Feb 2020 15:52:30 -0800 Message-ID: Subject: Re: [PATCH] selinux: Fix typo in filesystem name To: Paul Moore Cc: Stephen Smalley , Eric Paris , Jeff Vander Stoep , Mark Salyzyn , selinux@vger.kernel.org, LKML , Android Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Wed, Feb 5, 2020 at 3:28 PM Paul Moore wrote: > > On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju wrote: > > > > Correct the filesystem name to "binder" to enable > > genfscon per-file labelling for binderfs. > > > > Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs") > > Signed-off-by: Hridya Valsaraju > > --- > > > > Hello, > > > > I seem to have made the typo/mistake during a rebase. Sorry about that > > :( > > > > Thanks, > > Hridya > > > > security/selinux/hooks.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Ooops :/ > > Thanks for the fix. I've merged this into selinux/stable-5.6, but due > to some personal scheduling issues on my end I'm going to refrain from > sending this to Linus until next week. Thank you Paul and Stephen! Regards, Hridya > > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > > index 89fe3a805129..d67a80b0d8a8 100644 > > --- a/security/selinux/hooks.c > > +++ b/security/selinux/hooks.c > > @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb, > > > > if (!strcmp(sb->s_type->name, "debugfs") || > > !strcmp(sb->s_type->name, "tracefs") || > > - !strcmp(sb->s_type->name, "binderfs") || > > + !strcmp(sb->s_type->name, "binder") || > > !strcmp(sb->s_type->name, "pstore")) > > sbsec->flags |= SE_SBGENFS; > > > > -- > > 2.25.0.341.g760bfbb309-goog > > -- > paul moore > www.paul-moore.com