From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Jonathan Lebon <jlebon@redhat.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v2] setfiles: clarify documented path resolution behaviour
Date: Mon, 22 Jun 2020 08:25:48 -0400 [thread overview]
Message-ID: <CAEjxPJ5H4QWQXB53uGtSdxFpqxJUjHYUmTeRKwYsNeHAajwyDQ@mail.gmail.com> (raw)
In-Reply-To: <20200618182205.378233-1-jlebon@redhat.com>
On Thu, Jun 18, 2020 at 3:05 PM Jonathan Lebon <jlebon@redhat.com> wrote:
>
> One thing that confused me when investigating
> https://github.com/SELinuxProject/selinux/issues/248 (i.e.
> https://github.com/coreos/fedora-coreos-tracker/issues/512) was that the
> manual page for `setfiles` seemed to imply that paths were fully
> resolved. This was consistent with the issues above where `setfiles` was
> failing because the target of the symbolic link didn't exist.
>
> But in fact, the wording around symbolic links in
> `setfiles`/`restorecon` refers actually to whether the parent
> directories are canonicalized via `realpath(3)` before labeling.
>
> Clarify the man pages to explain this.
>
> Signed-off-by: Jonathan Lebon <jlebon@redhat.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
next prev parent reply other threads:[~2020-06-22 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 18:22 [PATCH v2] setfiles: clarify documented path resolution behaviour Jonathan Lebon
2020-06-22 12:25 ` Stephen Smalley [this message]
2020-06-25 17:31 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEjxPJ5H4QWQXB53uGtSdxFpqxJUjHYUmTeRKwYsNeHAajwyDQ@mail.gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=jlebon@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).