From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: "Christian Göttsche" <cgzones@googlemail.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] refparser: add missing newline after error message
Date: Fri, 29 May 2020 10:35:44 -0400 [thread overview]
Message-ID: <CAEjxPJ6EenXgia8b8-c_NG6RX1rpKGJ1Or_y2Y=2GAU+cxSTkA@mail.gmail.com> (raw)
In-Reply-To: <20200528125128.26915-2-cgzones@googlemail.com>
On Thu, May 28, 2020 at 8:52 AM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
This seems fine although I wonder if we should just do this inside of
the o() definition and have it done for all callers.
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
> ---
> python/sepolgen/src/sepolgen/refparser.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/python/sepolgen/src/sepolgen/refparser.py b/python/sepolgen/src/sepolgen/refparser.py
> index f3e0ae87..9f850990 100644
> --- a/python/sepolgen/src/sepolgen/refparser.py
> +++ b/python/sepolgen/src/sepolgen/refparser.py
> @@ -1148,6 +1148,6 @@ def parse_headers(root, output=None, expand=True, debug=False):
> status.step()
>
> if len(failures):
> - o("failed to parse some headers: %s" % ", ".join(failures))
> + o("failed to parse some headers: %s\n" % ", ".join(failures))
>
> return headers
> --
> 2.27.0.rc2
>
next prev parent reply other threads:[~2020-05-29 14:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 19:01 [PATCH] sepolgen: parse gen_tunable as bool Christian Göttsche
2020-05-27 15:04 ` Stephen Smalley
2020-05-28 12:51 ` [PATCH v2 1/3] " Christian Göttsche
2020-05-28 12:51 ` [PATCH v2 2/3] refparser: add missing newline after error message Christian Göttsche
2020-05-29 14:35 ` Stephen Smalley [this message]
2020-05-28 12:51 ` [PATCH v2 3/3] sepolgen-ifgen: refactor default policy path retrieval Christian Göttsche
2020-05-29 14:45 ` Stephen Smalley
2020-05-28 14:23 ` [PATCH v2 1/3] sepolgen: parse gen_tunable as bool Stephen Smalley
2020-05-28 14:51 ` Christian Göttsche
2020-06-04 20:26 ` Stephen Smalley
2020-06-05 14:49 ` [PATCH v3 " Christian Göttsche
2020-06-05 14:49 ` [PATCH v3 2/3] refparser: add missing newline after error message Christian Göttsche
2020-06-08 15:28 ` Stephen Smalley
2020-06-05 14:49 ` [PATCH v3 3/3] sepolgen-ifgen: refactor default policy path retrieval Christian Göttsche
2020-06-08 15:51 ` Stephen Smalley
2020-06-08 15:27 ` [PATCH v3 1/3] sepolgen: parse gen_tunable as bool Stephen Smalley
2020-06-11 13:53 ` [PATCH v4 " Christian Göttsche
2020-06-11 13:53 ` [PATCH v4 2/3] refparser: add missing newline after error message Christian Göttsche
2020-06-11 13:53 ` [PATCH v4 3/3] sepolgen-ifgen: refactor default policy path retrieval Christian Göttsche
2020-06-11 14:03 ` Stephen Smalley
2020-06-15 14:19 ` [PATCH v5 " Christian Göttsche
2020-06-15 15:07 ` [PATCH v6 " Christian Göttsche
2020-06-15 16:30 ` Stephen Smalley
2020-06-18 19:32 ` Petr Lautrbach
2020-05-28 12:54 ` [PATCH] sepolgen: parse gen_tunable as bool Christian Göttsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEjxPJ6EenXgia8b8-c_NG6RX1rpKGJ1Or_y2Y=2GAU+cxSTkA@mail.gmail.com' \
--to=stephen.smalley.work@gmail.com \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).