From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: James Carter <jwcart2@gmail.com>
Cc: SElinux list <selinux@vger.kernel.org>,
Topi Miettinen <toiwoton@gmail.com>
Subject: Re: [PATCH v3 2/2] libsepol/cil: Return error when identifier declared as both type and attribute
Date: Fri, 29 May 2020 08:52:00 -0400 [thread overview]
Message-ID: <CAEjxPJ6LBzu4PCg5S_cCrG5zKiLKNrWav5v7bFEJUsv9L8=QCA@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ4hG5ou+c5BY9g7BMBV1mCcVT5PEpEfuv_4WjNW2+NY_w@mail.gmail.com>
On Wed, May 27, 2020 at 9:16 AM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Tue, May 26, 2020 at 2:51 PM James Carter <jwcart2@gmail.com> wrote:
> >
> > CIL allows a type to be redeclared when using the multiple declarations
> > option ("-m" or "--muliple-decls"), but make it an error for an identifier
> > to be declared as both a type and an attribute.
> >
> > Change the error message so that it always gives the location and flavor
> > of both declarations. The flavors will be the same in all other cases,
> > but in this case they explain why there is an error even if multiple
> > declartions are allowed.
> >
> > Fixes: Commit fafe4c212bf6c32c ("libsepol: cil: Add ability to redeclare types[attributes]")
> > Reported-by: Topi Miettinen <toiwoton@gmail.com>
> > Signed-off-by: James Carter <jwcart2@gmail.com>
>
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Applied.
prev parent reply other threads:[~2020-05-29 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 18:50 [PATCH v3 1/2] libsepol/cil: Initialize the multiple_decls field of the cil db James Carter
2020-05-26 18:50 ` [PATCH v3 2/2] libsepol/cil: Return error when identifier declared as both type and attribute James Carter
2020-05-27 7:02 ` Topi Miettinen
2020-05-27 12:06 ` James Carter
2020-05-27 13:16 ` Stephen Smalley
2020-05-29 12:52 ` Stephen Smalley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEjxPJ6LBzu4PCg5S_cCrG5zKiLKNrWav5v7bFEJUsv9L8=QCA@mail.gmail.com' \
--to=stephen.smalley.work@gmail.com \
--cc=jwcart2@gmail.com \
--cc=selinux@vger.kernel.org \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).