From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: libsepol: drop dso question on CFLAGS (package maintainers weigh in please)
Date: Fri, 6 Mar 2020 11:25:50 -0500 [thread overview]
Message-ID: <CAEjxPJ7AMmRH-5y_WLx_b9rKdvq823FnJJ2HBBWAdDSQL3rnpg@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdp8TtcWRSA2PPWGaq1SPB81y7cF+w3ThbKr-BniEx9Gmw@mail.gmail.com>
On Fri, Mar 6, 2020 at 9:52 AM William Roberts <bill.c.roberts@gmail.com> wrote:
>
> The libsepol/src/Makefile has the below lines for CFLAGS:
>
> CFLAGS ?= -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute -O2
>
> override CFLAGS += -I. -I../include -D_GNU_SOURCE
>
> Does anyone have a preference where I add the -fno-semantic-interposition?
>
> I was thinking the conditional assignment because of the comment made
> about packagers overriding things on the selinux drop dso patch
> series.
I am not a package maintainer but regardless of how this gets added
(and I think in the libselinux case
it ends up being part of the conditional assignment), we need to make
sure that maintainers are strongly
encouraged to add it to their builds to preserve existing behavior.
next prev parent reply other threads:[~2020-03-06 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 14:51 libsepol: drop dso question on CFLAGS (package maintainers weigh in please) William Roberts
2020-03-06 16:25 ` Stephen Smalley [this message]
2020-03-06 17:46 ` William Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEjxPJ7AMmRH-5y_WLx_b9rKdvq823FnJJ2HBBWAdDSQL3rnpg@mail.gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=bill.c.roberts@gmail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).