From: Stephen Smalley <email@example.com> To: William Roberts <firstname.lastname@example.org> Cc: SElinux list <email@example.com> Subject: Re: PR 193 sitting for uClibC fix Date: Thu, 26 Mar 2020 12:58:30 -0400 Message-ID: <CAEjxPJ7YLp6_cAJ1bVUDy0638FpAy99wvBfEpKJxRkSUsTDfirstname.lastname@example.org> (raw) In-Reply-To: <CAEjxPJ6UMs+XgBm5ry98c41zKymKxO4QfSW+eyOaUe5xgQ6eaw@mail.gmail.com> On Thu, Mar 26, 2020 at 12:52 PM Stephen Smalley <email@example.com> wrote: > > On Thu, Mar 26, 2020 at 12:46 PM William Roberts > <firstname.lastname@example.org> wrote: > > > > On Thu, Mar 26, 2020 at 11:44 AM Stephen Smalley > > <email@example.com> wrote: > > > > > > On Thu, Mar 26, 2020 at 12:22 PM William Roberts > > > <firstname.lastname@example.org> wrote: > > > > > > > > This PR: > > > > https://github.com/SELinuxProject/selinux/pull/193 > > > > > > > > Has been sitting forever. I looked through the mailing list and didn't > > > > see any patches hit the list, > > > > we should either close it, or merge it. > > > > > > > > Thoughts? If we need it to hit the list, can I grab it and sign-off on > > > > it and post it? > > > > > > You can't sign-off on someone else's patch without them first signing off on it > > > or otherwise certifying to you that it falls under clauses (a), (b), > > > or (c) of the DCO. > > > > For some reason I just assumed it had a signed-off line, it doesn't though. > > > > > You could create your own patch to achieve the same end, especially > > > since this one is trivial and seems > > > to be modeled after an existing commit, > > > ab0e27003ef245f20512d1808b1dfee662ab8f41, so it > > > seems like it is relatively safe. > > > > I thought about creating it, but it's like how do I create such a trivial patch > > and not get hit with I copied it. > > IANAL, but IIUC when something can only be done one way, it isn't copyrightable. > Other possible ways to differentiate: > - libselinux/src/Makefile provides a FTS_LDLIBS ?= definition, which > was missing from their patch. > Not sure that matters. > - Instead of adding it LDLIBS for everything, could just add it where > needed, similar to PCRE_LDLIBS. Or you could just ping them on the github issue and ask if they will at least certify to the DCO as a github comment (or better, push a revised commit with sign-off) and then you can take it from there.
next prev parent reply index Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-26 16:21 William Roberts 2020-03-26 16:45 ` Stephen Smalley 2020-03-26 16:46 ` William Roberts 2020-03-26 16:52 ` Stephen Smalley 2020-03-26 16:58 ` Stephen Smalley [this message] 2020-03-26 17:02 ` William Roberts
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAEjxPJ7YLp6_cAJ1bVUDy0638FpAy99wvBfEpKJxRkSUsTDemail@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
SELinux Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/selinux/0 selinux/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 selinux selinux/ https://lore.kernel.org/selinux \ email@example.com public-inbox-index selinux Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.selinux AGPL code for this site: git clone https://public-inbox.org/public-inbox.git