selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Roberts <bill.c.roberts@gmail.com>
To: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Petr Lautrbach <plautrba@redhat.com>,
	Nicolas Iooss <nicolas.iooss@m4x.org>,
	Ulrich Drepper <drepper@redhat.com>,
	Ondrej Mosnacek <omosnace@redhat.com>,
	SElinux list <selinux@vger.kernel.org>,
	William Roberts <william.c.roberts@intel.com>
Subject: Re: [V4] libselinux: drop dso.h
Date: Thu, 12 Mar 2020 09:05:44 -0500	[thread overview]
Message-ID: <CAFftDdpQ2LFifgD4j=usv8WUpN1=xV2S_aOQcbN+MFomYQGrYg@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ7wqdhF5G_2n1EsGjuvHdZhLG6Ww4dEkZ+HJjbffFjDVA@mail.gmail.com>

On Wed, Mar 11, 2020 at 1:14 PM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Thu, Mar 5, 2020 at 2:09 PM William Roberts <bill.c.roberts@gmail.com> wrote:
> >
> > On Thu, Mar 5, 2020 at 10:12 AM William Roberts
> > <bill.c.roberts@gmail.com> wrote:
> > >
> > > On Thu, Mar 5, 2020 at 6:42 AM Petr Lautrbach <plautrba@redhat.com> wrote:
> > > >
> > > >
> > > > Stephen Smalley <stephen.smalley.work@gmail.com> writes:
> > > >
> > > > > On Mon, Mar 2, 2020 at 11:41 AM <bill.c.roberts@gmail.com> wrote:
> > > > >> [PATCH v4 1/4] dso: drop hidden_proto and hidden_def
> > > > >> [PATCH v4 2/4] Makefile: add -fno-semantic-interposition
> > > > >> [PATCH v4 3/4] Makefile: add linker script to minimize exports
> > > > >> [PATCH v4 4/4] libselinux: drop symbols from map
> > > > >
> > > > > This looks fine to me but I'd like at least one of the distro
> > > > > maintainers to ack it (especially the last one).
> > > >
> > > > Acked-by: Petr Lautrbach <plautrba@redhat.com>
> > > >
> > >
> > > Thanks staged:
> > > https://github.com/SELinuxProject/selinux/pull/205
> >
> > merged.
>
> I've noticed a change since this was applied; if I build userspace
> against the updated libselinux, the dynamic loader will
> print a warning if it is run on a system with the older libselinux, ala:
> $ /sbin/restorecon -v /etc
> /sbin/restorecon: /lib64/libselinux.so.1: no version information
> available (required by /sbin/restorecon)
> It still works since there was no real change in the ABI but I don't
> know if this is a concern for distros.

I replicated this and looked into it, AFAICT its relatively harmless since,
as you point out, we're not breaking ABI.

But If I understand your comment (paraphrasing), "userspace should all
be updated together"
from:
  - https://lore.kernel.org/selinux/CAEjxPJ4UPBWSP0E4pjR+F6uKMZNHK9J7LTL1gVznpwyJh9UWNA@mail.gmail.com/

Then it really shouldn't be an issue.

A lot of what I read on the version stuff was written by Urlich, so he
might weigh in with more
information and perhaps a way to correct this.

  reply	other threads:[~2020-03-12 14:05 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-27 23:01 libselinux: drop dso.h bill.c.roberts
2020-02-27 23:01 ` [PATCH 1/3] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-02-27 23:01 ` [PATCH 2/3] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-02-28 13:51   ` Stephen Smalley
2020-02-28 13:59     ` William Roberts
2020-03-01 20:32       ` Nicolas Iooss
2020-03-02 16:41         ` [V4] libselinux: drop dso.h bill.c.roberts
2020-03-02 16:41           ` [PATCH v4 1/4] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-03-02 16:41           ` [PATCH v4 2/4] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-03-02 16:41           ` [PATCH v4 3/4] Makefile: add linker script to minimize exports bill.c.roberts
2020-03-02 16:41           ` [PATCH v4 4/4] libselinux: drop symbols from map bill.c.roberts
2020-03-03 18:58           ` [V4] libselinux: drop dso.h Stephen Smalley
2020-03-04 12:26             ` Ondrej Mosnacek
2020-03-04 13:48               ` William Roberts
2020-03-04 13:15             ` Petr Lautrbach
2020-03-05 12:42             ` Petr Lautrbach
2020-03-05 16:12               ` William Roberts
2020-03-05 19:09                 ` William Roberts
2020-03-11 18:14                   ` Stephen Smalley
2020-03-12 14:05                     ` William Roberts [this message]
2020-02-27 23:01 ` [PATCH 3/3] Makefile: add linker script to minimize exports bill.c.roberts
2020-02-28 13:36   ` Stephen Smalley
2020-02-28 13:38     ` William Roberts
2020-02-28 14:05     ` [V2] libselinux: drop dso.h bill.c.roberts
2020-02-28 14:05       ` [PATCH v2 1/4] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-02-28 14:05       ` [PATCH v2 2/4] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-02-28 14:05       ` [PATCH v2 3/4] Makefile: add linker script to minimize exports bill.c.roberts
2020-02-28 14:05       ` [PATCH v2 4/4] libselinux: drop symbols from map bill.c.roberts
2020-02-28 15:39         ` Stephen Smalley
2020-02-28 15:40           ` William Roberts
2020-02-28 15:48 ` [V3] libselinux: drop dso.h bill.c.roberts
2020-02-28 15:48   ` [PATCH v3 1/4] dso: drop hidden_proto and hidden_def bill.c.roberts
2020-02-28 15:48   ` [PATCH v3 2/4] Makefile: add -fno-semantic-interposition bill.c.roberts
2020-02-28 15:48   ` [PATCH v3 3/4] Makefile: add linker script to minimize exports bill.c.roberts
     [not found]     ` <CAEjxPJ7CuMf5QeW_jjEonRN=kfcpTV8c4UnUMyEjyb2hee1YXg@mail.gmail.com>
     [not found]       ` <CAFftDdpeP39qvXNTe06EWkc3Kp_TMu5bGOf8WN6Q-k2Cehn_3w@mail.gmail.com>
2020-02-28 19:05         ` Stephen Smalley
2020-03-01 20:04           ` Nicolas Iooss
2020-02-28 15:48   ` [PATCH v3 4/4] libselinux: drop symbols from map bill.c.roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFftDdpQ2LFifgD4j=usv8WUpN1=xV2S_aOQcbN+MFomYQGrYg@mail.gmail.com' \
    --to=bill.c.roberts@gmail.com \
    --cc=drepper@redhat.com \
    --cc=nicolas.iooss@m4x.org \
    --cc=omosnace@redhat.com \
    --cc=plautrba@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).