SELinux Archive on lore.kernel.org
 help / color / Atom feed
From: William Roberts <bill.c.roberts@gmail.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: SElinux list <selinux@vger.kernel.org>,
	"Roberts, William C" <william.c.roberts@intel.com>
Subject: Re: [PATCH v2] scripts/ci: license as MIT
Date: Mon, 3 Aug 2020 11:43:49 -0500
Message-ID: <CAFftDdpwud0FtuaoUE1ABgYtMwr3+kcF-hww88+eDHdz5oGLSw@mail.gmail.com> (raw)
In-Reply-To: <CAFqZXNtTZio0-9_T9yheg0JmUP-TDa2OsUkgvHrNphGCrjhMVg@mail.gmail.com>

On Mon, Aug 3, 2020 at 11:31 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote:
> > From: William Roberts <william.c.roberts@intel.com>
> >
> > License the ci scripts with a permissive, OSI approved license, such as
> > MIT.
> >
> > Signed-off-by: William Roberts <william.c.roberts@intel.com>
> > ---
> >  v1: Apache 2.0
> >  v2: MIT
> >
> >  scripts/ci/LICENSE               | 7 +++++++
> >  scripts/ci/fedora-test-runner.sh | 2 +-
> >  scripts/ci/travis-kvm-setup.sh   | 2 +-
> >  3 files changed, 9 insertions(+), 2 deletions(-)
> >  create mode 100644 scripts/ci/LICENSE
> >
> > diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE
> > new file mode 100644
> > index 000000000000..6cd7b7924ef9
> > --- /dev/null
> > +++ b/scripts/ci/LICENSE
> > @@ -0,0 +1,7 @@
> > +Copyright <YEAR> <COPYRIGHT HOLDER>

You don't actually need them. They are often never updated anyways
after the initial. I can just drop that line, wget + git add.

>
> You should probably put an actual year/name here?
>
> > +
> > +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
> > +
> > +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
> > +
> > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh
> > index 569723387f6b..0aaba87c421b 100755
> > --- a/scripts/ci/fedora-test-runner.sh
> > +++ b/scripts/ci/fedora-test-runner.sh
> > @@ -1,5 +1,5 @@
> >  #!/usr/bin/env bash
> > -
> > +# SPDX-License-Identifier: MIT
>
> As I said in the v1 thread, also the individual files should contain a
> copyright line in addition to the SPDX line. See:
> https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement

You don't actually need them and they just clutter the code and as a
policy, I don't participate in adding to the problem of these big
blocks
of copyright statements that need to be maintained and grow per
contributor. I can just drop the SPDX identifiers, as the LICENSE file
applies to everything.

With version control, the issues as described by that author are less
of a problem. We can easily
trace from whom, by how and when code was modified for any legal
issues if they were to arise.

We can just keep the LICENSE file, drop the SPDX identifiers and I
would be 100% in-line with that libselinux is currently doing.

>
> >  set -ev
> >
> >  #
> > diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh
> > index 8d4cfb79f7d7..2b5734178096 100755
> > --- a/scripts/ci/travis-kvm-setup.sh
> > +++ b/scripts/ci/travis-kvm-setup.sh
> > @@ -1,5 +1,5 @@
> >  #!/usr/bin/env bash
> > -
> > +# SPDX-License-Identifier: MIT
> >  set -ev
> >
> >  TEST_RUNNER="scripts/ci/fedora-test-runner.sh"
> > --
> > 2.17.1
> >
>
> --
> Ondrej Mosnacek
> Software Engineer, Platform Security - SELinux kernel
> Red Hat, Inc.
>

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31 14:03 License of userspace CI scripts? Ondrej Mosnacek
2020-07-31 15:09 ` William Roberts
2020-07-31 17:33   ` [PATCH] scripts/ci: license as Apache 2.0 bill.c.roberts
2020-07-31 21:11     ` Ondrej Mosnacek
2020-07-31 21:23       ` William Roberts
2020-08-03  8:01         ` Ondrej Mosnacek
2020-08-03 15:14           ` [PATCH v2] scripts/ci: license as MIT bill.c.roberts
2020-08-03 16:31             ` Ondrej Mosnacek
2020-08-03 16:43               ` William Roberts [this message]
2020-08-04 14:34                 ` Ondrej Mosnacek
2020-08-04 14:36                   ` William Roberts
2020-08-07 12:28                     ` Ondrej Mosnacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFftDdpwud0FtuaoUE1ABgYtMwr3+kcF-hww88+eDHdz5oGLSw@mail.gmail.com \
    --to=bill.c.roberts@gmail.com \
    --cc=omosnace@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux/0 selinux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux selinux/ https://lore.kernel.org/selinux \
		selinux@vger.kernel.org
	public-inbox-index selinux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git