From: William Roberts <bill.c.roberts@gmail.com>
To: "Jokke Hämäläinen" <jokke.hamalainen@kolttonen.fi>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] Trivial style fixes pt2
Date: Wed, 15 May 2019 17:51:40 -0700 [thread overview]
Message-ID: <CAFftDdqcCu--4uckf7CpB5-qK1y6sp9yt1S5PYDVgqzGjE2pRw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.21.1905110105390.19034@34-41-5D-CA-59-C7>
On Fri, May 10, 2019 at 3:08 PM Jokke Hämäläinen
<jokke.hamalainen@kolttonen.fi> wrote:
>
>
> ---
> libsemanage/src/direct_api.c | 2 +-
> libsemanage/src/modules.c | 2 +-
> libsemanage/src/seusers_local.c | 2 +-
> libsemanage/src/users_local.c | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c
> index c58961be..7e097d5f 100644
> --- a/libsemanage/src/direct_api.c
> +++ b/libsemanage/src/direct_api.c
> @@ -517,7 +517,7 @@ ssize_t bunzip(semanage_handle_t *sh, FILE *f, char **data)
> size_t size = 1<<18;
> size_t bufsize = size;
> int bzerror;
> - size_t total=0;
> + size_t total = 0;
> char* uncompress = NULL;
> char* tmpalloc = NULL;
> int ret = -1;
> diff --git a/libsemanage/src/modules.c b/libsemanage/src/modules.c
> index 62af1018..fa84d33e 100644
> --- a/libsemanage/src/modules.c
> +++ b/libsemanage/src/modules.c
> @@ -1130,7 +1130,7 @@ int semanage_module_install_info(semanage_handle_t *sh,
> int semanage_module_remove_key(semanage_handle_t *sh,
> const semanage_module_key_t *modkey)
> {
> - if (sh->funcs->remove_key== NULL) {
> + if (sh->funcs->remove_key == NULL) {
> ERR(sh,
> "No remove key function defined for this connection type.");
> return -1;
> diff --git a/libsemanage/src/seusers_local.c b/libsemanage/src/seusers_local.c
> index a79e2d3d..3e2761c4 100644
> --- a/libsemanage/src/seusers_local.c
> +++ b/libsemanage/src/seusers_local.c
> @@ -133,7 +133,7 @@ int semanage_seuser_modify_local(semanage_handle_t * handle,
> semanage_seuser_t *new = NULL;
>
> if (!sename) {
> - errno=EINVAL;
> + errno = EINVAL;
> return -1;
> }
> rc = semanage_seuser_clone(handle, data, &new);
> diff --git a/libsemanage/src/users_local.c b/libsemanage/src/users_local.c
> index 7aa43d44..8193476d 100644
> --- a/libsemanage/src/users_local.c
> +++ b/libsemanage/src/users_local.c
> @@ -38,7 +38,7 @@ static int lookup_seuser(semanage_handle_t * handle, const semanage_user_key_t *
> semanage_seuser_list_local(handle,
> &records,
> &count);
> - for(i=0; i<count; i++) {
> + for(i = 0; i < count; i++) {
> sename = semanage_seuser_get_sename(records[i]);
> if (strcmp(name, sename) == 0) {
> errno = EINVAL;
> @@ -47,7 +47,7 @@ static int lookup_seuser(semanage_handle_t * handle, const semanage_user_key_t *
> rc = -1;
> }
> }
> - for(i=0; i<count; i++)
> + for(i = 0; i < count; i++)
> semanage_seuser_free(records[i]);
> free(records);
> semanage_user_free(user);
> --
> 2.21.0
>
ack, can you want to stage a PR?
prev parent reply other threads:[~2019-05-16 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 22:07 [PATCH] Trivial style fixes pt2 Jokke Hämäläinen
2019-05-16 0:51 ` William Roberts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFftDdqcCu--4uckf7CpB5-qK1y6sp9yt1S5PYDVgqzGjE2pRw@mail.gmail.com \
--to=bill.c.roberts@gmail.com \
--cc=jokke.hamalainen@kolttonen.fi \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).