From: William Roberts <bill.c.roberts@gmail.com>
To: James Carter <jwcart2@tycho.nsa.gov>
Cc: selinux@vger.kernel.org, selinux <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 0/4] libsepol: Cleanup initial sid handling when writing CIL and policy.conf files
Date: Thu, 11 Oct 2018 16:58:01 -0700 [thread overview]
Message-ID: <CAFftDdrGknwW3fJCU0+BptuS69qLcuKj+5gTchgkqJapTwjCTw@mail.gmail.com> (raw)
In-Reply-To: <20181011123549.14875-1-jwcart2@tycho.nsa.gov>
On Thu, Oct 11, 2018 at 5:37 AM James Carter <jwcart2@tycho.nsa.gov> wrote:
>
> [Resending because I originally only sent these to the new list]
>
> - Removes some redundent definitions of initial sid name strings
> - Adds range checking when looking up an initial sid name string for an index
> - Adds two new Xen initial sids
>
> James Carter (4):
> libsepol: Rename kernel_to_common.c stack functions
> libsepol: Eliminate initial sid string definitions in module_to_cil.c
> libsepol: Check that initial sid indexes are within the valid range
> libsepol: Add two new Xen initial SIDs
>
> libsepol/src/kernel_to_cil.c | 78 +++++++++++++++++++++------------
> libsepol/src/kernel_to_common.c | 10 ++---
> libsepol/src/kernel_to_common.h | 16 ++++---
> libsepol/src/kernel_to_conf.c | 78 +++++++++++++++++++++------------
> libsepol/src/module_to_cil.c | 78 +++++++++------------------------
> 5 files changed, 136 insertions(+), 124 deletions(-)
LGTM. I ran these locally and they seemed to be OK and I was able
to list the new SIDs from the policy db.
I staged them here to have travis run the CI as well:
https://github.com/SELinuxProject/selinux/pull/104
>
> --
> 2.17.1
>
> _______________________________________________
> Selinux mailing list
> Selinux@tycho.nsa.gov
> To unsubscribe, send email to Selinux-leave@tycho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@tycho.nsa.gov.
next prev parent reply other threads:[~2018-10-11 23:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 12:35 [PATCH 0/4] libsepol: Cleanup initial sid handling when writing CIL and policy.conf files James Carter
2018-10-11 12:35 ` [PATCH 1/4] libsepol: Rename kernel_to_common.c stack functions James Carter
2018-10-11 12:35 ` [PATCH 2/4] libsepol: Eliminate initial sid string definitions in module_to_cil.c James Carter
2018-10-11 12:35 ` [PATCH 3/4] libsepol: Check that initial sid indexes are within the valid range James Carter
2018-10-11 15:02 ` Yuli Khodorkovskiy
2018-10-11 12:35 ` [PATCH 4/4] libsepol: Add two new Xen initial SIDs James Carter
2018-10-11 23:58 ` William Roberts [this message]
2018-10-15 17:39 ` [PATCH 0/4] libsepol: Cleanup initial sid handling when writing CIL and policy.conf files William Roberts
-- strict thread matches above, loose matches on Subject: below --
2018-10-05 13:57 James Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFftDdrGknwW3fJCU0+BptuS69qLcuKj+5gTchgkqJapTwjCTw@mail.gmail.com \
--to=bill.c.roberts@gmail.com \
--cc=jwcart2@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).