Re: [PATCH] selinux-testsuite: update the dependencies in README.md

[Ondrej Mosnacek <omosnace@redhat.com>]

On Wed, Nov 27, 2019 at 3:47 PM Paul Moore <paul@paul-moore.com> wrote:
> From: Paul Moore <paul@paul-moore.com>
>
> The new kernel module tests added in a68d583c2a70 ("selinux-testsuite:
> Add kernel module tests") require the kernel-devel package on Fedora,
> make sure we list that in the README.md file.

Thanks, I should have thought of this when reviewing the patch :)

>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
> ---
>  README.md |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/README.md b/README.md
> index e845df8..4352796 100644
> --- a/README.md
> +++ b/README.md
> @@ -53,6 +53,7 @@ similar dependencies):
>  * attr _(tools used by the overlayfs tests)_
>  * libbpf-devel _(tools used by the bpf tests)_
>  * keyutils-libs-devel _(tools used by the keys tests)_
> +* kernel-devel _(used by the kernel module tests)_
>
>  On a modern Fedora system you can install these dependencies with the
>  following command:
> @@ -69,7 +70,8 @@ following command:
>                 lksctp-tools-devel \
>                 attr \
>                 libbpf-devel \
> -               keyutils-libs-devel
> +               keyutils-libs-devel \
> +               kernel-devel

I'm wondering whether we should rather put kernel-devel-$(uname -r)
here, to make sure that the right package is installed that
corresponds to the running kernel version (which may not be the latest
version that dnf will fetch). Or if the use of shell expansion feels
too clever, then we should at last document that the command may not
always install the version that is needed.

>
>  The testsuite requires a pre-existing base policy configuration of SELinux,
>  using either the old example policy or the reference policy as the baseline.

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.