selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ondrej Mosnacek <omosnace@redhat.com>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>,
	Nicolas Iooss <nicolas.iooss@m4x.org>,
	SElinux list <selinux@vger.kernel.org>,
	Ulrich Drepper <drepper@redhat.com>,
	Petr Lautrbach <plautrba@redhat.com>,
	William Roberts <william.c.roberts@intel.com>
Subject: Re: [PATCH v2 3/3] lbespol: remove wild cards in mapfile
Date: Fri, 13 Mar 2020 12:03:34 +0100	[thread overview]
Message-ID: <CAFqZXNsYcCQGLNYXHsEz_yw3y54mK2NO1XVk6pXtJatEn1b54w@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdqPtrg1jjcep=u_ny-SHuK04Fd_UhFu29pGohnxpNAP4g@mail.gmail.com>

On Thu, Mar 12, 2020 at 10:42 PM William Roberts
<bill.c.roberts@gmail.com> wrote:
> On Thu, Mar 12, 2020 at 3:21 PM Stephen Smalley
> <stephen.smalley.work@gmail.com> wrote:
> >
> > On Thu, Mar 12, 2020 at 9:59 AM William Roberts
> > <bill.c.roberts@gmail.com> wrote:
> > >
> > > I will fix the subject and add the Fixes: #165 to the commit when I
> > > stage them if thats ok?
> >
> > Fixes both 165 and 204 IIUC because the real underlying issue for both was the
> > fact that he was building with LTO and it was doing the wrong thing
> > with hidden_def/hidden_proto.
> > Otherwise works for me.  You can download the series from patchwork or
> > via get-lore-mbox
> > to pick up all the Acks automatically.
>
> I have no idea how to do that, Ill have to spend some time and
> familiarize myself with it.

You can simply go to
https://patchwork.kernel.org/project/selinux/list/, click on any patch
in the series (e.g. https://patchwork.kernel.org/patch/11430261/) and
copy the address of the "series" button/link in the upper right
corner. Then you just do:

curl <link> | git am

There is certainly a faster way to do it using the Patchwork CLI, but
I never bothered to set that up :)

> For now I just manually added the acks and did the edits we discussed
> and rebased ontop
> of current master. Their was a simple conflict in libsepol/src/services.c.
>
> I have them staged here:
> https://github.com/SELinuxProject/selinux/pull/207

The CI failed because libsepol/src/services.c still includes "dso.h"
in the rebased commits. You'll need to fix that first.

>
> And since their were some minor edits before they go in, ill let them
> sit a couple
> of days for any last objections. Ill merge Monday March 16 end of workday if all
> is silent.

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.


  reply	other threads:[~2020-03-13 11:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 15:25 libsepol drop dso.h bill.c.roberts
2020-03-09 15:25 ` [PATCH 1/2] libsepol/dso: drop hidden_proto and hidden_def bill.c.roberts
2020-03-10 20:10   ` Stephen Smalley
2020-03-10 20:15     ` William Roberts
2020-03-09 15:25 ` [PATCH 2/2] libsepol/Makefile: add -fno-semantic-interposition bill.c.roberts
2020-03-10 21:08 ` V2 libsepol drop dso.h bill.c.roberts
2020-03-10 21:08   ` [PATCH v2 1/3] libsepol/dso: drop hidden_proto and hidden_def bill.c.roberts
2020-03-10 21:08   ` [PATCH v2 2/3] libsepol/Makefile: add -fno-semantic-interposition bill.c.roberts
2020-03-10 21:08   ` [PATCH v2 3/3] lbespol: remove wild cards in mapfile bill.c.roberts
2020-03-11 18:53     ` Stephen Smalley
2020-03-11 18:54       ` Stephen Smalley
2020-03-12 13:59         ` William Roberts
2020-03-12 20:22           ` Stephen Smalley
2020-03-12 21:42             ` William Roberts
2020-03-13 11:03               ` Ondrej Mosnacek [this message]
2020-03-13 14:22                 ` William Roberts
2020-03-13 14:41                   ` Ondrej Mosnacek
2020-03-13 14:51                     ` William Roberts
2020-03-17 17:46               ` Stephen Smalley
2020-03-19 19:46                 ` William Roberts
2020-03-19 19:48                   ` [PATCH] cil: drop remaining dso.h include bill.c.roberts
2020-03-20  8:08                     ` Ondrej Mosnacek
2020-03-23 15:35                       ` William Roberts
2020-03-26 15:16                         ` Joshua Brindle
2020-03-26 15:35                           ` William Roberts
2020-03-26 15:46                           ` cil: Fix DISABLE_SYMVER support and drop last dso.h bill.c.roberts
2020-03-26 15:46                             ` [PATCH 1/2] cil: rm dead dso.h file bill.c.roberts
2020-03-26 15:46                             ` [PATCH 2/2] cil: re-enable DISABLE_SYMVER define bill.c.roberts
2020-03-26 15:47                             ` cil: Fix DISABLE_SYMVER support and drop last dso.h William Roberts
2020-03-26 16:05                               ` Joshua Brindle
2020-03-26 16:18                                 ` William Roberts
2020-03-27 14:27                                   ` William Roberts
2020-03-27 14:47                                     ` Stephen Smalley
2020-03-27 15:02                                       ` William Roberts
2020-03-26 16:50                           ` [PATCH] cil: drop remaining dso.h include Stephen Smalley
2020-03-26 16:51                             ` William Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqZXNsYcCQGLNYXHsEz_yw3y54mK2NO1XVk6pXtJatEn1b54w@mail.gmail.com \
    --to=omosnace@redhat.com \
    --cc=bill.c.roberts@gmail.com \
    --cc=drepper@redhat.com \
    --cc=nicolas.iooss@m4x.org \
    --cc=plautrba@redhat.com \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).