* [PATCH 1/1] libsepol: initialize a local variable once
@ 2019-07-28 18:37 Nicolas Iooss
2019-07-28 20:29 ` Ondrej Mosnacek
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Iooss @ 2019-07-28 18:37 UTC (permalink / raw)
To: selinux
Function optimize_cond_av_list() initializes its local variable pcov_cur
twice. Remove the first initialization.
This issue has been found using clang's static analyzer:
https://282-118970575-gh.circle-artifacts.com/0/output-scan-build/2019-06-24-210510-6101-1/report-c64da3.html#EndPath
Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
---
libsepol/src/optimize.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libsepol/src/optimize.c b/libsepol/src/optimize.c
index 3780b68b24fe..10399a43e1cf 100644
--- a/libsepol/src/optimize.c
+++ b/libsepol/src/optimize.c
@@ -247,7 +247,7 @@ static void optimize_cond_av_list(cond_av_list_t **cond, cond_av_list_t **del,
{
cond_av_list_t **listp = cond;
cond_av_list_t *pcov = NULL;
- cond_av_list_t **pcov_cur = &pcov;
+ cond_av_list_t **pcov_cur;
/*
* Separate out all "potentially covering" rules (src or tgt is an attr)
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] libsepol: initialize a local variable once
2019-07-28 18:37 [PATCH 1/1] libsepol: initialize a local variable once Nicolas Iooss
@ 2019-07-28 20:29 ` Ondrej Mosnacek
2019-07-30 22:05 ` Nicolas Iooss
0 siblings, 1 reply; 3+ messages in thread
From: Ondrej Mosnacek @ 2019-07-28 20:29 UTC (permalink / raw)
To: Nicolas Iooss; +Cc: SElinux list
On Sun, Jul 28, 2019 at 8:38 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
> Function optimize_cond_av_list() initializes its local variable pcov_cur
> twice. Remove the first initialization.
>
> This issue has been found using clang's static analyzer:
> https://282-118970575-gh.circle-artifacts.com/0/output-scan-build/2019-06-24-210510-6101-1/report-c64da3.html#EndPath
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Acked-by: Ondrej Mosnacek <omosnace@redhat.com>
> ---
> libsepol/src/optimize.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libsepol/src/optimize.c b/libsepol/src/optimize.c
> index 3780b68b24fe..10399a43e1cf 100644
> --- a/libsepol/src/optimize.c
> +++ b/libsepol/src/optimize.c
> @@ -247,7 +247,7 @@ static void optimize_cond_av_list(cond_av_list_t **cond, cond_av_list_t **del,
> {
> cond_av_list_t **listp = cond;
> cond_av_list_t *pcov = NULL;
> - cond_av_list_t **pcov_cur = &pcov;
> + cond_av_list_t **pcov_cur;
>
> /*
> * Separate out all "potentially covering" rules (src or tgt is an attr)
> --
> 2.22.0
>
--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] libsepol: initialize a local variable once
2019-07-28 20:29 ` Ondrej Mosnacek
@ 2019-07-30 22:05 ` Nicolas Iooss
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Iooss @ 2019-07-30 22:05 UTC (permalink / raw)
To: Ondrej Mosnacek, SElinux list
On Sun, Jul 28, 2019 at 10:29 PM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> On Sun, Jul 28, 2019 at 8:38 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
> > Function optimize_cond_av_list() initializes its local variable pcov_cur
> > twice. Remove the first initialization.
> >
> > This issue has been found using clang's static analyzer:
> > https://282-118970575-gh.circle-artifacts.com/0/output-scan-build/2019-06-24-210510-6101-1/report-c64da3.html#EndPath
> >
> > Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>
> Acked-by: Ondrej Mosnacek <omosnace@redhat.com>
Thanks, merged.
Nicolas
> > ---
> > libsepol/src/optimize.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libsepol/src/optimize.c b/libsepol/src/optimize.c
> > index 3780b68b24fe..10399a43e1cf 100644
> > --- a/libsepol/src/optimize.c
> > +++ b/libsepol/src/optimize.c
> > @@ -247,7 +247,7 @@ static void optimize_cond_av_list(cond_av_list_t **cond, cond_av_list_t **del,
> > {
> > cond_av_list_t **listp = cond;
> > cond_av_list_t *pcov = NULL;
> > - cond_av_list_t **pcov_cur = &pcov;
> > + cond_av_list_t **pcov_cur;
> >
> > /*
> > * Separate out all "potentially covering" rules (src or tgt is an attr)
> > --
> > 2.22.0
> >
>
> --
> Ondrej Mosnacek <omosnace at redhat dot com>
> Software Engineer, Security Technologies
> Red Hat, Inc.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-28 18:37 [PATCH 1/1] libsepol: initialize a local variable once Nicolas Iooss
2019-07-28 20:29 ` Ondrej Mosnacek
2019-07-30 22:05 ` Nicolas Iooss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).