* License of userspace CI scripts? @ 2020-07-31 14:03 Ondrej Mosnacek 2020-07-31 15:09 ` William Roberts 0 siblings, 1 reply; 12+ messages in thread From: Ondrej Mosnacek @ 2020-07-31 14:03 UTC (permalink / raw) To: SElinux list, William Roberts Hi all, I started working on converting the selinux-testsuite Travis CI to run the testsuite in a Fedora VM as is currently being done for SELinux userspace thanks to William. In my current working version I basically just copy-pasted William's scripts from scripts/ci/... and made minor adjustments, so I have a slight concern over licensing - the scripts currently don't have any license headers and there is no LICENSE/COPYING file in a parent directory that could implicitly apply to them. William, would you mind adding some explicit GPLv2-compatible license headers there so I can legally copy the code over to selinux-testsuite? :) Thanks, -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: License of userspace CI scripts? 2020-07-31 14:03 License of userspace CI scripts? Ondrej Mosnacek @ 2020-07-31 15:09 ` William Roberts 2020-07-31 17:33 ` [PATCH] scripts/ci: license as Apache 2.0 bill.c.roberts 0 siblings, 1 reply; 12+ messages in thread From: William Roberts @ 2020-07-31 15:09 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: SElinux list Ah, I thought those were under the libselinux license, but I see each sub-dir project has its own LICENSE terms. I would be amenable to Apache 2.0 or BSD-3, and can just drop spdx identifiers on them if that works? Bill On Fri, Jul 31, 2020 at 9:03 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > Hi all, > > I started working on converting the selinux-testsuite Travis CI to run > the testsuite in a Fedora VM as is currently being done for SELinux > userspace thanks to William. In my current working version I basically > just copy-pasted William's scripts from scripts/ci/... and made minor > adjustments, so I have a slight concern over licensing - the scripts > currently don't have any license headers and there is no > LICENSE/COPYING file in a parent directory that could implicitly apply > to them. William, would you mind adding some explicit GPLv2-compatible > license headers there so I can legally copy the code over to > selinux-testsuite? :) > > Thanks, > > -- > Ondrej Mosnacek > Software Engineer, Platform Security - SELinux kernel > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] scripts/ci: license as Apache 2.0 2020-07-31 15:09 ` William Roberts @ 2020-07-31 17:33 ` bill.c.roberts 2020-07-31 21:11 ` Ondrej Mosnacek 0 siblings, 1 reply; 12+ messages in thread From: bill.c.roberts @ 2020-07-31 17:33 UTC (permalink / raw) To: bill.c.roberts; +Cc: omosnace, selinux, William Roberts From: William Roberts <william.c.roberts@intel.com> License the ci scripts with a permissive, OSI approved license, such as Apache 2.0. Signed-off-by: William Roberts <william.c.roberts@intel.com> --- scripts/ci/LICENSE | 202 +++++++++++++++++++++++++++++++ scripts/ci/fedora-test-runner.sh | 2 +- scripts/ci/travis-kvm-setup.sh | 2 +- 3 files changed, 204 insertions(+), 2 deletions(-) create mode 100644 scripts/ci/LICENSE diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE new file mode 100644 index 000000000000..d64569567334 --- /dev/null +++ b/scripts/ci/LICENSE @@ -0,0 +1,202 @@ + + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship, whether in Source or + Object form, made available under the License, as indicated by a + copyright notice that is included in or attached to the work + (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other modifications + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean any work of authorship, including + the original version of the Work and any modifications or additions + to that Work or Derivative Works thereof, that is intentionally + submitted to Licensor for inclusion in the Work by the copyright owner + or by an individual or Legal Entity authorized to submit on behalf of + the copyright owner. For the purposes of this definition, "submitted" + means any form of electronic, verbal, or written communication sent + to the Licensor or its representatives, including but not limited to + communication on electronic mailing lists, source code control systems, + and issue tracking systems that are managed by, or on behalf of, the + Licensor for the purpose of discussing and improving the Work, but + excluding communication that is conspicuously marked or otherwise + designated in writing by the copyright owner as "Not a Contribution." + + "Contributor" shall mean Licensor and any individual or Legal Entity + on behalf of whom a Contribution has been received by Licensor and + subsequently incorporated within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by combination of their Contribution(s) + with the Work to which such Contribution(s) was submitted. If You + institute patent litigation against any entity (including a + cross-claim or counterclaim in a lawsuit) alleging that the Work + or a Contribution incorporated within the Work constitutes direct + or contributory patent infringement, then any patent licenses + granted to You under this License for that Work shall terminate + as of the date such litigation is filed. + + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + + (a) You must give any other recipients of the Work or + Derivative Works a copy of this License; and + + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + + (d) If the Work includes a "NOTICE" text file as part of its + distribution, then any Derivative Works that You distribute must + include a readable copy of the attribution notices contained + within such NOTICE file, excluding those notices that do not + pertain to any part of the Derivative Works, in at least one + of the following places: within a NOTICE text file distributed + as part of the Derivative Works; within the Source form or + documentation, if provided along with the Derivative Works; or, + within a display generated by the Derivative Works, if and + wherever such third-party notices normally appear. The contents + of the NOTICE file are for informational purposes only and + do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + + You may add Your own copyright statement to Your modifications and + may provide additional or different license terms and conditions + for use, reproduction, or distribution of Your modifications, or + for any such Derivative Works as a whole, provided Your use, + reproduction, and distribution of the Work otherwise complies with + the conditions stated in this License. + + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any warranties or conditions + of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A + PARTICULAR PURPOSE. You are solely responsible for determining the + appropriateness of using or redistributing the Work and assume any + risks associated with Your exercise of permissions under this License. + + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or consequential damages of any character arising as a + result of this License or out of the use or inability to use the + Work (including but not limited to damages for loss of goodwill, + work stoppage, computer failure or malfunction, or any and all + other commercial damages or losses), even if such Contributor + has been advised of the possibility of such damages. + + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may act only + on Your own behalf and on Your sole responsibility, not on behalf + of any other Contributor, and only if You agree to indemnify, + defend, and hold each Contributor harmless for any liability + incurred by, or claims asserted against, such Contributor by reason + of your accepting any such warranty or additional liability. + + END OF TERMS AND CONDITIONS + + APPENDIX: How to apply the Apache License to your work. + + To apply the Apache License to your work, attach the following + boilerplate notice, with the fields enclosed by brackets "[]" + replaced with your own identifying information. (Don't include + the brackets!) The text should be enclosed in the appropriate + comment syntax for the file format. We also recommend that a + file or class name and description of purpose be included on the + same "printed page" as the copyright notice for easier + identification within third-party archives. + + Copyright [yyyy] [name of copyright owner] + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh index 569723387f6b..8d6a572eb094 100755 --- a/scripts/ci/fedora-test-runner.sh +++ b/scripts/ci/fedora-test-runner.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash - +# SPDX-License-Identifier: Apache-2.0 set -ev # diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh index 8d4cfb79f7d7..275d05299971 100755 --- a/scripts/ci/travis-kvm-setup.sh +++ b/scripts/ci/travis-kvm-setup.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash - +# SPDX-License-Identifier: Apache-2.0 set -ev TEST_RUNNER="scripts/ci/fedora-test-runner.sh" -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] scripts/ci: license as Apache 2.0 2020-07-31 17:33 ` [PATCH] scripts/ci: license as Apache 2.0 bill.c.roberts @ 2020-07-31 21:11 ` Ondrej Mosnacek 2020-07-31 21:23 ` William Roberts 0 siblings, 1 reply; 12+ messages in thread From: Ondrej Mosnacek @ 2020-07-31 21:11 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list, William Roberts On Fri, Jul 31, 2020 at 7:33 PM <bill.c.roberts@gmail.com> wrote: > From: William Roberts <william.c.roberts@intel.com> > > License the ci scripts with a permissive, OSI approved license, such as > Apache 2.0. Thanks! On second thought though, I guess any open source license would be fine, since the scripts don't "link" with the rest of the testsuite (which is GPLv2). So if you prefer some more permissive (or shorter... :) license or just public domain, you can probably use that, too. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > scripts/ci/LICENSE | 202 +++++++++++++++++++++++++++++++ > scripts/ci/fedora-test-runner.sh | 2 +- > scripts/ci/travis-kvm-setup.sh | 2 +- > 3 files changed, 204 insertions(+), 2 deletions(-) > create mode 100644 scripts/ci/LICENSE > <snip> > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > index 569723387f6b..8d6a572eb094 100755 > --- a/scripts/ci/fedora-test-runner.sh > +++ b/scripts/ci/fedora-test-runner.sh > @@ -1,5 +1,5 @@ > #!/usr/bin/env bash > - > +# SPDX-License-Identifier: Apache-2.0 I think you should also add a copyright line alongside the SPDX header. See: https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement > set -ev > > # > diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh > index 8d4cfb79f7d7..275d05299971 100755 > --- a/scripts/ci/travis-kvm-setup.sh > +++ b/scripts/ci/travis-kvm-setup.sh > @@ -1,5 +1,5 @@ > #!/usr/bin/env bash > - > +# SPDX-License-Identifier: Apache-2.0 Ditto. > set -ev > > TEST_RUNNER="scripts/ci/fedora-test-runner.sh" > -- > 2.17.1 > -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] scripts/ci: license as Apache 2.0 2020-07-31 21:11 ` Ondrej Mosnacek @ 2020-07-31 21:23 ` William Roberts 2020-08-03 8:01 ` Ondrej Mosnacek 0 siblings, 1 reply; 12+ messages in thread From: William Roberts @ 2020-07-31 21:23 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: SElinux list, William Roberts On Fri, Jul 31, 2020 at 4:11 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Fri, Jul 31, 2020 at 7:33 PM <bill.c.roberts@gmail.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > > > License the ci scripts with a permissive, OSI approved license, such as > > Apache 2.0. > > Thanks! On second thought though, I guess any open source license > would be fine, since the scripts don't "link" with the rest of the > testsuite (which is GPLv2). So if you prefer some more permissive (or > shorter... :) license or just public domain, you can probably use > that, too. I can do MIT, does that work? > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > scripts/ci/LICENSE | 202 +++++++++++++++++++++++++++++++ > > scripts/ci/fedora-test-runner.sh | 2 +- > > scripts/ci/travis-kvm-setup.sh | 2 +- > > 3 files changed, 204 insertions(+), 2 deletions(-) > > create mode 100644 scripts/ci/LICENSE > > > > <snip> > > > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > > index 569723387f6b..8d6a572eb094 100755 > > --- a/scripts/ci/fedora-test-runner.sh > > +++ b/scripts/ci/fedora-test-runner.sh > > @@ -1,5 +1,5 @@ > > #!/usr/bin/env bash > > - > > +# SPDX-License-Identifier: Apache-2.0 > > I think you should also add a copyright line alongside the SPDX header. See: > https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement > > > set -ev > > > > # > > diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh > > index 8d4cfb79f7d7..275d05299971 100755 > > --- a/scripts/ci/travis-kvm-setup.sh > > +++ b/scripts/ci/travis-kvm-setup.sh > > @@ -1,5 +1,5 @@ > > #!/usr/bin/env bash > > - > > +# SPDX-License-Identifier: Apache-2.0 > > Ditto. > > > set -ev > > > > TEST_RUNNER="scripts/ci/fedora-test-runner.sh" > > -- > > 2.17.1 > > > > -- > Ondrej Mosnacek > Software Engineer, Platform Security - SELinux kernel > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] scripts/ci: license as Apache 2.0 2020-07-31 21:23 ` William Roberts @ 2020-08-03 8:01 ` Ondrej Mosnacek 2020-08-03 15:14 ` [PATCH v2] scripts/ci: license as MIT bill.c.roberts 0 siblings, 1 reply; 12+ messages in thread From: Ondrej Mosnacek @ 2020-08-03 8:01 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list, William Roberts On Fri, Jul 31, 2020 at 11:23 PM William Roberts <bill.c.roberts@gmail.com> wrote: > On Fri, Jul 31, 2020 at 4:11 PM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Fri, Jul 31, 2020 at 7:33 PM <bill.c.roberts@gmail.com> wrote: > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > License the ci scripts with a permissive, OSI approved license, such as > > > Apache 2.0. > > > > Thanks! On second thought though, I guess any open source license > > would be fine, since the scripts don't "link" with the rest of the > > testsuite (which is GPLv2). So if you prefer some more permissive (or > > shorter... :) license or just public domain, you can probably use > > that, too. > > I can do MIT, does that work? Yes, works for me. -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] scripts/ci: license as MIT 2020-08-03 8:01 ` Ondrej Mosnacek @ 2020-08-03 15:14 ` bill.c.roberts 2020-08-03 16:31 ` Ondrej Mosnacek 0 siblings, 1 reply; 12+ messages in thread From: bill.c.roberts @ 2020-08-03 15:14 UTC (permalink / raw) To: omosnace; +Cc: bill.c.roberts, selinux, william.c.roberts From: William Roberts <william.c.roberts@intel.com> License the ci scripts with a permissive, OSI approved license, such as MIT. Signed-off-by: William Roberts <william.c.roberts@intel.com> --- v1: Apache 2.0 v2: MIT scripts/ci/LICENSE | 7 +++++++ scripts/ci/fedora-test-runner.sh | 2 +- scripts/ci/travis-kvm-setup.sh | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 scripts/ci/LICENSE diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE new file mode 100644 index 000000000000..6cd7b7924ef9 --- /dev/null +++ b/scripts/ci/LICENSE @@ -0,0 +1,7 @@ +Copyright <YEAR> <COPYRIGHT HOLDER> + +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: + +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. + +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh index 569723387f6b..0aaba87c421b 100755 --- a/scripts/ci/fedora-test-runner.sh +++ b/scripts/ci/fedora-test-runner.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash - +# SPDX-License-Identifier: MIT set -ev # diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh index 8d4cfb79f7d7..2b5734178096 100755 --- a/scripts/ci/travis-kvm-setup.sh +++ b/scripts/ci/travis-kvm-setup.sh @@ -1,5 +1,5 @@ #!/usr/bin/env bash - +# SPDX-License-Identifier: MIT set -ev TEST_RUNNER="scripts/ci/fedora-test-runner.sh" -- 2.17.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] scripts/ci: license as MIT 2020-08-03 15:14 ` [PATCH v2] scripts/ci: license as MIT bill.c.roberts @ 2020-08-03 16:31 ` Ondrej Mosnacek 2020-08-03 16:43 ` William Roberts 0 siblings, 1 reply; 12+ messages in thread From: Ondrej Mosnacek @ 2020-08-03 16:31 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list, Roberts, William C On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote: > From: William Roberts <william.c.roberts@intel.com> > > License the ci scripts with a permissive, OSI approved license, such as > MIT. > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > --- > v1: Apache 2.0 > v2: MIT > > scripts/ci/LICENSE | 7 +++++++ > scripts/ci/fedora-test-runner.sh | 2 +- > scripts/ci/travis-kvm-setup.sh | 2 +- > 3 files changed, 9 insertions(+), 2 deletions(-) > create mode 100644 scripts/ci/LICENSE > > diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE > new file mode 100644 > index 000000000000..6cd7b7924ef9 > --- /dev/null > +++ b/scripts/ci/LICENSE > @@ -0,0 +1,7 @@ > +Copyright <YEAR> <COPYRIGHT HOLDER> You should probably put an actual year/name here? > + > +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: > + > +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. > + > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > index 569723387f6b..0aaba87c421b 100755 > --- a/scripts/ci/fedora-test-runner.sh > +++ b/scripts/ci/fedora-test-runner.sh > @@ -1,5 +1,5 @@ > #!/usr/bin/env bash > - > +# SPDX-License-Identifier: MIT As I said in the v1 thread, also the individual files should contain a copyright line in addition to the SPDX line. See: https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement > set -ev > > # > diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh > index 8d4cfb79f7d7..2b5734178096 100755 > --- a/scripts/ci/travis-kvm-setup.sh > +++ b/scripts/ci/travis-kvm-setup.sh > @@ -1,5 +1,5 @@ > #!/usr/bin/env bash > - > +# SPDX-License-Identifier: MIT > set -ev > > TEST_RUNNER="scripts/ci/fedora-test-runner.sh" > -- > 2.17.1 > -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] scripts/ci: license as MIT 2020-08-03 16:31 ` Ondrej Mosnacek @ 2020-08-03 16:43 ` William Roberts 2020-08-04 14:34 ` Ondrej Mosnacek 0 siblings, 1 reply; 12+ messages in thread From: William Roberts @ 2020-08-03 16:43 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: SElinux list, Roberts, William C On Mon, Aug 3, 2020 at 11:31 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote: > > From: William Roberts <william.c.roberts@intel.com> > > > > License the ci scripts with a permissive, OSI approved license, such as > > MIT. > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > --- > > v1: Apache 2.0 > > v2: MIT > > > > scripts/ci/LICENSE | 7 +++++++ > > scripts/ci/fedora-test-runner.sh | 2 +- > > scripts/ci/travis-kvm-setup.sh | 2 +- > > 3 files changed, 9 insertions(+), 2 deletions(-) > > create mode 100644 scripts/ci/LICENSE > > > > diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE > > new file mode 100644 > > index 000000000000..6cd7b7924ef9 > > --- /dev/null > > +++ b/scripts/ci/LICENSE > > @@ -0,0 +1,7 @@ > > +Copyright <YEAR> <COPYRIGHT HOLDER> You don't actually need them. They are often never updated anyways after the initial. I can just drop that line, wget + git add. > > You should probably put an actual year/name here? > > > + > > +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: > > + > > +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. > > + > > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > > index 569723387f6b..0aaba87c421b 100755 > > --- a/scripts/ci/fedora-test-runner.sh > > +++ b/scripts/ci/fedora-test-runner.sh > > @@ -1,5 +1,5 @@ > > #!/usr/bin/env bash > > - > > +# SPDX-License-Identifier: MIT > > As I said in the v1 thread, also the individual files should contain a > copyright line in addition to the SPDX line. See: > https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement You don't actually need them and they just clutter the code and as a policy, I don't participate in adding to the problem of these big blocks of copyright statements that need to be maintained and grow per contributor. I can just drop the SPDX identifiers, as the LICENSE file applies to everything. With version control, the issues as described by that author are less of a problem. We can easily trace from whom, by how and when code was modified for any legal issues if they were to arise. We can just keep the LICENSE file, drop the SPDX identifiers and I would be 100% in-line with that libselinux is currently doing. > > > set -ev > > > > # > > diff --git a/scripts/ci/travis-kvm-setup.sh b/scripts/ci/travis-kvm-setup.sh > > index 8d4cfb79f7d7..2b5734178096 100755 > > --- a/scripts/ci/travis-kvm-setup.sh > > +++ b/scripts/ci/travis-kvm-setup.sh > > @@ -1,5 +1,5 @@ > > #!/usr/bin/env bash > > - > > +# SPDX-License-Identifier: MIT > > set -ev > > > > TEST_RUNNER="scripts/ci/fedora-test-runner.sh" > > -- > > 2.17.1 > > > > -- > Ondrej Mosnacek > Software Engineer, Platform Security - SELinux kernel > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] scripts/ci: license as MIT 2020-08-03 16:43 ` William Roberts @ 2020-08-04 14:34 ` Ondrej Mosnacek 2020-08-04 14:36 ` William Roberts 0 siblings, 1 reply; 12+ messages in thread From: Ondrej Mosnacek @ 2020-08-04 14:34 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list, Roberts, William C On Mon, Aug 3, 2020 at 6:44 PM William Roberts <bill.c.roberts@gmail.com> wrote: > On Mon, Aug 3, 2020 at 11:31 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote: > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > License the ci scripts with a permissive, OSI approved license, such as > > > MIT. > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > --- > > > v1: Apache 2.0 > > > v2: MIT > > > > > > scripts/ci/LICENSE | 7 +++++++ > > > scripts/ci/fedora-test-runner.sh | 2 +- > > > scripts/ci/travis-kvm-setup.sh | 2 +- > > > 3 files changed, 9 insertions(+), 2 deletions(-) > > > create mode 100644 scripts/ci/LICENSE > > > > > > diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE > > > new file mode 100644 > > > index 000000000000..6cd7b7924ef9 > > > --- /dev/null > > > +++ b/scripts/ci/LICENSE > > > @@ -0,0 +1,7 @@ > > > +Copyright <YEAR> <COPYRIGHT HOLDER> > > You don't actually need them. They are often never updated anyways > after the initial. I can just drop that line, wget + git add. > > > > > You should probably put an actual year/name here? > > > > > + > > > +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: > > > + > > > +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. > > > + > > > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > > > index 569723387f6b..0aaba87c421b 100755 > > > --- a/scripts/ci/fedora-test-runner.sh > > > +++ b/scripts/ci/fedora-test-runner.sh > > > @@ -1,5 +1,5 @@ > > > #!/usr/bin/env bash > > > - > > > +# SPDX-License-Identifier: MIT > > > > As I said in the v1 thread, also the individual files should contain a > > copyright line in addition to the SPDX line. See: > > https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement > > You don't actually need them and they just clutter the code and as a > policy, I don't participate in adding to the problem of these big > blocks > of copyright statements that need to be maintained and grow per > contributor. I can just drop the SPDX identifiers, as the LICENSE file > applies to everything. > > With version control, the issues as described by that author are less > of a problem. We can easily > trace from whom, by how and when code was modified for any legal > issues if they were to arise. > > We can just keep the LICENSE file, drop the SPDX identifiers and I > would be 100% in-line with that libselinux is currently doing. I tend to disagree, but I can live with it if you want to leave it out. So let me ACK this patch and I'll just remove the template "Copyright" line from the LICENSE file when applying. Acked-by: Ondrej Mosnacek <omosnace@redhat.com> -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] scripts/ci: license as MIT 2020-08-04 14:34 ` Ondrej Mosnacek @ 2020-08-04 14:36 ` William Roberts 2020-08-07 12:28 ` Ondrej Mosnacek 0 siblings, 1 reply; 12+ messages in thread From: William Roberts @ 2020-08-04 14:36 UTC (permalink / raw) To: Ondrej Mosnacek; +Cc: SElinux list, Roberts, William C Sounds good. On Tue, Aug 4, 2020 at 9:35 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > On Mon, Aug 3, 2020 at 6:44 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > On Mon, Aug 3, 2020 at 11:31 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote: > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > License the ci scripts with a permissive, OSI approved license, such as > > > > MIT. > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > --- > > > > v1: Apache 2.0 > > > > v2: MIT > > > > > > > > scripts/ci/LICENSE | 7 +++++++ > > > > scripts/ci/fedora-test-runner.sh | 2 +- > > > > scripts/ci/travis-kvm-setup.sh | 2 +- > > > > 3 files changed, 9 insertions(+), 2 deletions(-) > > > > create mode 100644 scripts/ci/LICENSE > > > > > > > > diff --git a/scripts/ci/LICENSE b/scripts/ci/LICENSE > > > > new file mode 100644 > > > > index 000000000000..6cd7b7924ef9 > > > > --- /dev/null > > > > +++ b/scripts/ci/LICENSE > > > > @@ -0,0 +1,7 @@ > > > > +Copyright <YEAR> <COPYRIGHT HOLDER> > > > > You don't actually need them. They are often never updated anyways > > after the initial. I can just drop that line, wget + git add. > > > > > > > > You should probably put an actual year/name here? > > > > > > > + > > > > +Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: > > > > + > > > > +The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. > > > > + > > > > +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > > > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > > > > index 569723387f6b..0aaba87c421b 100755 > > > > --- a/scripts/ci/fedora-test-runner.sh > > > > +++ b/scripts/ci/fedora-test-runner.sh > > > > @@ -1,5 +1,5 @@ > > > > #!/usr/bin/env bash > > > > - > > > > +# SPDX-License-Identifier: MIT > > > > > > As I said in the v1 thread, also the individual files should contain a > > > copyright line in addition to the SPDX line. See: > > > https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement > > > > You don't actually need them and they just clutter the code and as a > > policy, I don't participate in adding to the problem of these big > > blocks > > of copyright statements that need to be maintained and grow per > > contributor. I can just drop the SPDX identifiers, as the LICENSE file > > applies to everything. > > > > With version control, the issues as described by that author are less > > of a problem. We can easily > > trace from whom, by how and when code was modified for any legal > > issues if they were to arise. > > > > We can just keep the LICENSE file, drop the SPDX identifiers and I > > would be 100% in-line with that libselinux is currently doing. > > I tend to disagree, but I can live with it if you want to leave it > out. So let me ACK this patch and I'll just remove the template > "Copyright" line from the LICENSE file when applying. > > Acked-by: Ondrej Mosnacek <omosnace@redhat.com> > > -- > Ondrej Mosnacek > Software Engineer, Platform Security - SELinux kernel > Red Hat, Inc. > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] scripts/ci: license as MIT 2020-08-04 14:36 ` William Roberts @ 2020-08-07 12:28 ` Ondrej Mosnacek 0 siblings, 0 replies; 12+ messages in thread From: Ondrej Mosnacek @ 2020-08-07 12:28 UTC (permalink / raw) To: William Roberts; +Cc: SElinux list, Roberts, William C On Tue, Aug 4, 2020 at 4:36 PM William Roberts <bill.c.roberts@gmail.com> wrote: > Sounds good. > > On Tue, Aug 4, 2020 at 9:35 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > On Mon, Aug 3, 2020 at 6:44 PM William Roberts <bill.c.roberts@gmail.com> wrote: > > > On Mon, Aug 3, 2020 at 11:31 AM Ondrej Mosnacek <omosnace@redhat.com> wrote: > > > > > > > > On Mon, Aug 3, 2020 at 5:14 PM <bill.c.roberts@gmail.com> wrote: > > > > > From: William Roberts <william.c.roberts@intel.com> > > > > > > > > > > License the ci scripts with a permissive, OSI approved license, such as > > > > > MIT. > > > > > > > > > > Signed-off-by: William Roberts <william.c.roberts@intel.com> > > > > > --- > > > > > v1: Apache 2.0 > > > > > v2: MIT > > > > > > > > > > scripts/ci/LICENSE | 7 +++++++ > > > > > scripts/ci/fedora-test-runner.sh | 2 +- > > > > > scripts/ci/travis-kvm-setup.sh | 2 +- > > > > > 3 files changed, 9 insertions(+), 2 deletions(-) > > > > > create mode 100644 scripts/ci/LICENSE > > > > > [...] > > > > > diff --git a/scripts/ci/fedora-test-runner.sh b/scripts/ci/fedora-test-runner.sh > > > > > index 569723387f6b..0aaba87c421b 100755 > > > > > --- a/scripts/ci/fedora-test-runner.sh > > > > > +++ b/scripts/ci/fedora-test-runner.sh > > > > > @@ -1,5 +1,5 @@ > > > > > #!/usr/bin/env bash > > > > > - > > > > > +# SPDX-License-Identifier: MIT > > > > > > > > As I said in the v1 thread, also the individual files should contain a > > > > copyright line in addition to the SPDX line. See: > > > > https://matija.suklje.name/how-and-why-to-properly-write-copyright-statements-in-your-code#why-have-the-copyright-statement > > > > > > You don't actually need them and they just clutter the code and as a > > > policy, I don't participate in adding to the problem of these big > > > blocks > > > of copyright statements that need to be maintained and grow per > > > contributor. I can just drop the SPDX identifiers, as the LICENSE file > > > applies to everything. > > > > > > With version control, the issues as described by that author are less > > > of a problem. We can easily > > > trace from whom, by how and when code was modified for any legal > > > issues if they were to arise. > > > > > > We can just keep the LICENSE file, drop the SPDX identifiers and I > > > would be 100% in-line with that libselinux is currently doing. > > > > I tend to disagree, but I can live with it if you want to leave it > > out. So let me ACK this patch and I'll just remove the template > > "Copyright" line from the LICENSE file when applying. > > > > Acked-by: Ondrej Mosnacek <omosnace@redhat.com> Patch applied. -- Ondrej Mosnacek Software Engineer, Platform Security - SELinux kernel Red Hat, Inc. ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-08-07 12:28 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-31 14:03 License of userspace CI scripts? Ondrej Mosnacek 2020-07-31 15:09 ` William Roberts 2020-07-31 17:33 ` [PATCH] scripts/ci: license as Apache 2.0 bill.c.roberts 2020-07-31 21:11 ` Ondrej Mosnacek 2020-07-31 21:23 ` William Roberts 2020-08-03 8:01 ` Ondrej Mosnacek 2020-08-03 15:14 ` [PATCH v2] scripts/ci: license as MIT bill.c.roberts 2020-08-03 16:31 ` Ondrej Mosnacek 2020-08-03 16:43 ` William Roberts 2020-08-04 14:34 ` Ondrej Mosnacek 2020-08-04 14:36 ` William Roberts 2020-08-07 12:28 ` Ondrej Mosnacek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).