selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ondrej Mosnacek <omosnace@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH 1/2] selinux-testsuite: use our own version of perltidy in the Travis CI tests
Date: Tue, 24 Sep 2019 09:26:01 +0200	[thread overview]
Message-ID: <CAFqZXNvhNUvCoquAC-Zq9hZCSmAVUGySubJSUER1x--MqqPdng@mail.gmail.com> (raw)
In-Reply-To: <156927696325.621177.10551869484430505777.stgit@chester>

On Tue, Sep 24, 2019 at 12:16 AM Paul Moore <paul@paul-moore.com> wrote:
> From: Paul Moore <paul@paul-moore.com>
>
> Unfortunately the perltidy results differ between moden distros and the
> current Travis CI environment.  This patch attempts to address this by
> using the current upstream perltidy in the Travis CI tests.

Generally thumbs up from me, although I have a few comments below.

>
> Signed-off-by: Paul Moore <paul@paul-moore.com>
> ---
>  .travis.yml |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/.travis.yml b/.travis.yml
> index 61bb1f2..256e92c 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -6,10 +6,17 @@ addons:
>    apt:
>      packages:
>        - astyle
> -      - perltidy
>        - libselinux1-dev
>        - libsctp-dev
>
> +before_install:
> +  - git clone https://github.com/perltidy/perltidy.git perltidy

I think it would be safer to add here something like:

- git checkout 8551fc60fc515cd290ba38ee8c758c1f4df52b56

That way the Travis checks won't suddenly break when something changes
in the master branch (where I'd expect things to change/break once in
a while). IMHO having to bump the commit manually from time to time is
less bothersome than having to deal with random changes in the
upstream branch.

> +  - |
> +    (cd perltidy;
> +     perl Makefile.PL;
> +     make;
> +     sudo make install)

This is not a big deal, but you might want to join these with '&&'
instead of ';' since if an earlier command fails, it doesn't make much
sense to try to run the rest (the pipeline would then almost certainly
fail later anyway).

> +
>  script:
>    - tools/check-syntax -f && git diff --exit-code
>    - make
>

--
Ondrej Mosnacek <omosnace at redhat dot com>
Software Engineer, Security Technologies
Red Hat, Inc.


  reply	other threads:[~2019-09-24  7:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23 22:15 [PATCH 0/2] selinux-testsuite: fix perltidy in Travis CI Paul Moore
2019-09-23 22:16 ` [PATCH 1/2] selinux-testsuite: use our own version of perltidy in the Travis CI tests Paul Moore
2019-09-24  7:26   ` Ondrej Mosnacek [this message]
2019-09-24 17:19     ` Paul Moore
2019-09-23 22:16 ` [PATCH 2/2] selinux-testsuite: apply perltidy fixes Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqZXNvhNUvCoquAC-Zq9hZCSmAVUGySubJSUER1x--MqqPdng@mail.gmail.com \
    --to=omosnace@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).