From: Joshua Brindle <joshua.brindle@crunchydata.com>
To: Paul Moore <paul@paul-moore.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH v2] default_range glblub implementation
Date: Thu, 29 Aug 2019 09:29:10 -0400 [thread overview]
Message-ID: <CAGB+Vh7dg-2mmtAYsFp3+v6a5DD1mRycOxqRLWOx1tcUOmvWYw@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhQVeSvqFYA9tgVZi9p5B6mDWdnsREJUYfP-oSGi17YhUQ@mail.gmail.com>
On Wed, Aug 28, 2019 at 6:31 PM Paul Moore <paul@paul-moore.com> wrote:
>
> On Wed, Aug 28, 2019 at 4:43 PM Joshua Brindle
> <joshua.brindle@crunchydata.com> wrote:
> >
> > A policy developer can now specify glblub as a default_range default and
> > the computed transition will be the intersection of the mls range of
> > the two contexts.
> >
> > The glb (greatest lower bound) lub (lowest upper bound) of a range is calculated
> > as the greater of the low sensitivities and the lower of the high sensitivities
> > and the and of each category bitmap.
> >
> > This can be used by MLS solution developers to compute a context that satisfies,
> > for example, the range of a network interface and the range of a user logging in.
> >
> > Some examples are:
> >
> > User Permitted Range | Network Device Label | Computed Label
> > ---------------------|----------------------|----------------
> > S0-S1:c0.c12 | S0 | S0
> > S0-S1:c0.c12 | S0-S1:c0.c1024 | S0-S1:c0.c12
> > S0-S4:c0.c512 | S1-S1:c0.c1024 | S1-S1:c0.c512
> > S0-S16:c0,c2 | S4-S6:c0.c128 | S4-S6:c0,c2
> > S0-S4 | S2-S6 | S2-S4
> > S0-S4 | S5-S8 | INVALID
> > S5-S8 | S0-S4 | INVALID
> > S6:c0,c2-S7:c4,c5 | S0:c2,c4-S6:c5.c100 | S6:c2-S6:c5
> >
> > Signed-off-by: Joshua Brindle <joshua.brindle@crunchydata.com>
> > ---
> > security/selinux/include/security.h | 3 ++-
> > security/selinux/ss/context.h | 28 ++++++++++++++++++++++++++++
> > security/selinux/ss/ebitmap.c | 18 ++++++++++++++++++
> > security/selinux/ss/ebitmap.h | 1 +
> > security/selinux/ss/mls.c | 2 ++
> > security/selinux/ss/policydb.c | 5 +++++
> > security/selinux/ss/policydb.h | 1 +
> > 7 files changed, 57 insertions(+), 1 deletion(-)
>
> You incorporated some feedback from the v1 patch, but you ignored
> some, can you explain why?
>
I apologize, I missed a couple C++ style comments, I'll fix those and
resend, was there anything else? I thought I addressed all of the
technical concerns.
> For reference, here are my comments on your first patch:
> * https://lore.kernel.org/selinux/CAHC9VhRXyRDjj3KJDHvA4ruJg6H+1kzFPzfA-PLZ-NqBicsLrw@mail.gmail.com/
>
> --
> paul moore
> www.paul-moore.com
next prev parent reply other threads:[~2019-08-29 13:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 20:43 [PATCH v2] default_range glblub implementation Joshua Brindle
2019-08-28 22:31 ` Paul Moore
2019-08-29 13:29 ` Joshua Brindle [this message]
2019-08-29 16:58 ` Paul Moore
2019-08-29 17:11 ` Joshua Brindle
2019-08-30 21:38 ` Paul Moore
2019-08-29 20:45 ` Stephen Smalley
2019-08-29 21:10 ` Joshua Brindle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGB+Vh7dg-2mmtAYsFp3+v6a5DD1mRycOxqRLWOx1tcUOmvWYw@mail.gmail.com \
--to=joshua.brindle@crunchydata.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).