From: Paul Moore <paul@paul-moore.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] selinux-testsuite: fix old python shebang in tests/overlay/access
Date: Wed, 19 Jun 2019 10:40:33 -0400 [thread overview]
Message-ID: <CAHC9VhQ1Bo-xpROgZa18MqxJSnTLoYoj6GbQR-pmDy2jSDs1bQ@mail.gmail.com> (raw)
In-Reply-To: <20190619142630.26648-1-sds@tycho.nsa.gov>
On Wed, Jun 19, 2019 at 10:26 AM Stephen Smalley <sds@tycho.nsa.gov> wrote:
>
> /usr/bin/python is no longer installed by default, so this test
> script fails on default installs.
> Best practice guidance appears to be to switch to using
> /usr/bin/python3 instead, per
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
>
> Fixes: #46
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> tests/overlay/access | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I think it would be better to reference the Python upstream guidance
regarding "python3" instead of the Fedora packaging guidelines.
Keeping things distro agnostic is a good goal whenever possible.
* https://www.python.org/dev/peps/pep-0394
> diff --git a/tests/overlay/access b/tests/overlay/access
> index 5a47eb145904..e50d5b402ebd 100755
> --- a/tests/overlay/access
> +++ b/tests/overlay/access
> @@ -1,4 +1,4 @@
> -#!/bin/python
> +#!/usr/bin/python3
> import os, sys
> try:
> acc=eval("os.%s" % sys.argv[2])
> --
> 2.20.1
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2019-06-19 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 14:26 [PATCH] selinux-testsuite: fix old python shebang in tests/overlay/access Stephen Smalley
2019-06-19 14:40 ` Paul Moore [this message]
2019-06-19 16:04 ` Stephen Smalley
2019-06-21 15:44 ` Paul Moore
2019-06-23 17:01 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhQ1Bo-xpROgZa18MqxJSnTLoYoj6GbQR-pmDy2jSDs1bQ@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).