From: Paul Moore <paul@paul-moore.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: zohar@linux.ibm.com,
Stephen Smalley <stephen.smalley.work@gmail.com>,
prsriva02@gmail.com, tusharsu@linux.microsoft.com,
nramas@linux.microsoft.com, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ima: Add digest and digest_len params to the functions to measure a buffer
Date: Mon, 12 Jul 2021 22:40:00 -0400 [thread overview]
Message-ID: <CAHC9VhQAM+-TXOHLkcY2VGyJ3PNES0EaNr3PccHT=j3nGAvfPQ@mail.gmail.com> (raw)
In-Reply-To: <20210705090922.3321178-4-roberto.sassu@huawei.com>
On Mon, Jul 5, 2021 at 5:09 AM Roberto Sassu <roberto.sassu@huawei.com> wrote:
>
> This patch adds the 'digest' and 'digest_len' parameters to
> ima_measure_critical_data() and process_buffer_measurement(), so that
> callers can get the digest of the passed buffer.
>
> These functions calculate the digest even if there is no suitable rule in
> the IMA policy and, in this case, they simply return 1 before generating a
> new measurement entry.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> ---
> include/linux/ima.h | 5 +--
> security/integrity/ima/ima.h | 2 +-
> security/integrity/ima/ima_appraise.c | 2 +-
> security/integrity/ima/ima_asymmetric_keys.c | 2 +-
> security/integrity/ima/ima_init.c | 3 +-
> security/integrity/ima/ima_main.c | 36 ++++++++++++++------
> security/integrity/ima/ima_queue_keys.c | 2 +-
> security/selinux/ima.c | 6 ++--
> 8 files changed, 39 insertions(+), 19 deletions(-)
The SELinux changes are trivial and fall into that
cross-subsystem-ACK-not-really-necessary category, but why not :)
For the SELinux bits:
Acked-by: Paul Moore <paul@paul-moore.com>
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2021-07-13 2:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 9:09 [PATCH v3 0/3] ima: Provide more info about buffer measurement Roberto Sassu
2021-07-05 9:09 ` [PATCH v3 1/3] ima: Introduce ima_get_current_hash_algo() Roberto Sassu
2021-07-05 9:09 ` [PATCH v3 2/3] ima: Return int in the functions to measure a buffer Roberto Sassu
2021-07-06 19:21 ` Lakshmi Ramasubramanian
2021-07-19 20:28 ` Mimi Zohar
2021-07-20 12:38 ` Roberto Sassu
2021-07-20 13:01 ` Mimi Zohar
2021-07-05 9:09 ` [PATCH v3 3/3] ima: Add digest and digest_len params to " Roberto Sassu
2021-07-06 19:24 ` Lakshmi Ramasubramanian
2021-07-13 2:40 ` Paul Moore [this message]
2021-07-19 20:59 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhQAM+-TXOHLkcY2VGyJ3PNES0EaNr3PccHT=j3nGAvfPQ@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
--cc=prsriva02@gmail.com \
--cc=roberto.sassu@huawei.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=tusharsu@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).