From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F17C433F5 for ; Fri, 28 Jan 2022 02:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345325AbiA1CZa (ORCPT ); Thu, 27 Jan 2022 21:25:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345319AbiA1CZa (ORCPT ); Thu, 27 Jan 2022 21:25:30 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73DD9C061714 for ; Thu, 27 Jan 2022 18:25:29 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id p7so6734735edc.12 for ; Thu, 27 Jan 2022 18:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TIM/9YxONk8z0lexlFGrsOXlsM+mXoPlWV7GxMGCHPU=; b=mINAVHjXaAFiquQLI+M15IWJaVPPEA6dLZ3Zm9VgsWOTI5Pfl5KjdqSgvZGS70G9vY dywxPdd1gcSy9qY+TqvgtEJyZFm755lGxQ7gs1+9z7bIrObl3EVT175ZusPCi2pceHNr XbKd1hQkPit95lQVUqkiZOYC5JatCLaZdAfvbGi5SBanfAbkRoOlT1EU4IV8OZGT0tlz va69LKX7VRAB1tqFPGbg84kwTYMt+g+Tohb1mnBwhuC0rl35gtLxhf4l8EMor/3VzCta QAe6NUmz8BqmmVB/f7DElWtwol3tE7uSmYP7JK+aEZpGteRWHVb2+cgpXGmRe/wRmxxS Z4Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TIM/9YxONk8z0lexlFGrsOXlsM+mXoPlWV7GxMGCHPU=; b=538SrSe1A6SHCSBhZmh/Ttu8ApqttMY7Yt2M75qkN0mAO0BEm0FlBdlv1giie/1hR4 lEyXSKIDSDJdrwcE2J6N+Aycs2UCIFYwFUl+zvrqZX1yPJhpSrBlGMYZjiLM8g1b4zNG mFQIqN7VsRUGdJhOtI5n5x7o6y0AR1XTLTRXshql7M1AupFENdAaNPV+3WFMRjs6IagF a9WaYHZDOezZnYFXMcj+Mv/0d3FvgIdBTZ4R3Gr1Ffn1EW/QYzETOlm7yD33S3w7MpYF uA6Evpudz4pvK1NWEX1Yrt7xMVjqYDodQCV30pdZ0DlCbJPSpEOrhEVwwjRiFfnS1Czn K/Zg== X-Gm-Message-State: AOAM532WA6od5ZjeGT7zq3hdTdCIRKfEJP83+OoDrxmHjZQLTOsB0nOu f6/EutEv/qhNYoztzMgo7cumcKC0Xb+WKbIycUJA X-Google-Smtp-Source: ABdhPJztDA6NHlQTDRr8lUOhYNr117WJE7+PhFHDKCmhuZCVk44RzyaYKVEHbANIS0iugGjghRQzs4AdEUVNSwDvFqE= X-Received: by 2002:a50:ef16:: with SMTP id m22mr6093537eds.340.1643336728063; Thu, 27 Jan 2022 18:25:28 -0800 (PST) MIME-Version: 1.0 References: <20220120214948.3637895-1-smayhew@redhat.com> <20220120214948.3637895-2-smayhew@redhat.com> In-Reply-To: From: Paul Moore Date: Thu, 27 Jan 2022 21:25:17 -0500 Message-ID: Subject: Re: [PATCH RFC v2 1/2] selinux: Fix selinux_sb_mnt_opts_compat() To: Ondrej Mosnacek Cc: Scott Mayhew , SElinux list , linux-nfs , Linux kernel mailing list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Thu, Jan 27, 2022 at 4:54 AM Ondrej Mosnacek wrote: > I wonder if we could make this all much simpler by *always* doing the > label parsing in selinux_add_opt() and just returning an error when > !selinux_initialized(&selinux_state). Before the new mount API, mount > options were always passed directly to the mount(2) syscall, so it > wasn't possible to pass any SELinux mount options before the SELinux > policy was loaded. I don't see why we need to jump through hoops here > just to support this pseudo-feature of stashing an unparsed label into > an fs_context before policy is loaded... Userspace should never need > to do that. I could agree with that, although part of my mind is a little nervous about the "userspace should *never* ..." because that always seems to bite us. Although I'm struggling to think of a case where userspace would need to set explicit SELinux mount options without having a policy loaded. -- paul-moore.com