From: Paul Moore <paul@paul-moore.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: selinux@vger.kernel.org, omosnace@redhat.com
Subject: Re: [PATCH] selinux: fix avc audit messages
Date: Tue, 5 Feb 2019 12:45:31 -0500 [thread overview]
Message-ID: <CAHC9VhQRnXMXt5J-rhDHORVHqq6-Q4TRZ0-Zw7OMnsXAVWzcQw@mail.gmail.com> (raw)
In-Reply-To: <20190205164932.8472-1-sds@tycho.nsa.gov>
On Tue, Feb 5, 2019 at 11:49 AM Stephen Smalley <sds@tycho.nsa.gov> wrote:
> commit a2c513835bb6c6 ("selinux: inline some AVC functions used only once")
> introduced usage of audit_log_string() in place of audit_log_format()
> for fixed strings. However, audit_log_string() quotes the string.
> This breaks the avc audit message format and userspace audit parsers.
> Switch back to using audit_log_format().
>
> Fixes: a2c513835bb6c6 ("selinux: inline some AVC functions used only once")
> Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/avc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Thanks Stephen, I've been burned on this in the past too, I'm
disappointed that I didn't catch this originally :/
> diff --git a/security/selinux/avc.c b/security/selinux/avc.c
> index 33863298a9b5..8346a4f7c5d7 100644
> --- a/security/selinux/avc.c
> +++ b/security/selinux/avc.c
> @@ -674,13 +674,13 @@ static void avc_audit_pre_callback(struct audit_buffer *ab, void *a)
> audit_log_format(ab, "avc: %s ", sad->denied ? "denied" : "granted");
>
> if (av == 0) {
> - audit_log_string(ab, " null");
> + audit_log_format(ab, " null");
> return;
> }
>
> perms = secclass_map[sad->tclass-1].perms;
>
> - audit_log_string(ab, " {");
> + audit_log_format(ab, " {");
> i = 0;
> perm = 1;
> while (i < (sizeof(av) * 8)) {
> @@ -695,7 +695,7 @@ static void avc_audit_pre_callback(struct audit_buffer *ab, void *a)
> if (av)
> audit_log_format(ab, " 0x%x", av);
>
> - audit_log_string(ab, " } for ");
> + audit_log_format(ab, " } for ");
> }
>
> /**
> --
> 2.20.1
>
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2019-02-05 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 16:49 [PATCH] selinux: fix avc audit messages Stephen Smalley
2019-02-05 17:45 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhQRnXMXt5J-rhDHORVHqq6-Q4TRZ0-Zw7OMnsXAVWzcQw@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=omosnace@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).