From: Paul Moore <paul@paul-moore.com>
To: Petr Lautrbach <plautrba@redhat.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] Add CONTRIBUTING
Date: Fri, 31 May 2019 13:54:07 -0400 [thread overview]
Message-ID: <CAHC9VhQcrzJ7bQZccJw9v7cYUewMGMRdDVm8bkBwc4KFYsDKng@mail.gmail.com> (raw)
In-Reply-To: <pjdo93iv7q2.fsf@redhat.com>
On Fri, May 31, 2019 at 1:45 PM Petr Lautrbach <plautrba@redhat.com> wrote:
> Paul Moore <paul@paul-moore.com> writes:
> > On Wed, May 29, 2019 at 12:05 PM Paul Moore <paul@paul-moore.com> wrote:
> >> On Wed, May 29, 2019 at 12:03 PM Petr Lautrbach <plautrba@redhat.com> wrote:
> >> >
> >> > Based on https://github.com/SELinuxProject/selinux/wiki/Contributing
> >> >
> >> > Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
> >> > ---
> >> > CONTRIBUTING | 60 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >> > 1 file changed, 60 insertions(+)
> >> > create mode 100644 CONTRIBUTING
> >>
> >> I would suggest updating the wiki to point to this file if/when it is
> >> merged upstream.
> >
> > Sorry, one more thing: you might consider adding the ".md" suffix so
> > that GitHub and others will treat it as Markdown. I know that GitHub
> > also treats the CONTRIBUTING.md file in a special way and presents it
> > to users in various parts of the web UI, for example it show up in the
> > sidebar when creating new issues.
>
> Using Contributing.md in code would mean that it could be directly
> copied to wiki.
Another benefit, although I would encourage you to simply put a
pointer on the wiki to the repo file; duplicating the text is almost a
guarantee that one of those copies is going to go out of sync with the
other.
> When you say include DCO directly in Contributing, do you mean something
> like
> https://github.com/bachradsusi/SELinuxProject-selinux/wiki/Contributing
> ?
Yep. In case you are wondering, here is what I did for libseccomp:
* https://github.com/seccomp/libseccomp/blob/master/CONTRIBUTING.md
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2019-05-31 17:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 16:03 [PATCH] Add CONTRIBUTING Petr Lautrbach
2019-05-29 16:05 ` Paul Moore
2019-05-31 15:16 ` Paul Moore
2019-05-31 17:45 ` Petr Lautrbach
2019-05-31 17:54 ` Paul Moore [this message]
2019-05-31 20:19 ` [PATCH v2] Add CONTRIBUTING.md Petr Lautrbach
2019-05-31 21:01 ` Paul Moore
2019-06-14 19:00 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhQcrzJ7bQZccJw9v7cYUewMGMRdDVm8bkBwc4KFYsDKng@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).