From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C1BC433FF for ; Fri, 9 Aug 2019 15:27:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 369FC2086A for ; Fri, 9 Aug 2019 15:27:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="HnqjuGXa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407342AbfHIP1s (ORCPT ); Fri, 9 Aug 2019 11:27:48 -0400 Received: from mail-lf1-f45.google.com ([209.85.167.45]:36671 "EHLO mail-lf1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfHIP1s (ORCPT ); Fri, 9 Aug 2019 11:27:48 -0400 Received: by mail-lf1-f45.google.com with SMTP id j17so15787874lfp.3 for ; Fri, 09 Aug 2019 08:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=63nF9E0JoauNflUf+1oyiGGf3j4Ef0o1wSxE7efMELg=; b=HnqjuGXa/dRh7xqjfbfXOqKIBLqaTPWjwE33x6r/sO8XVojjudbtoweMlgjJdxmS0N 4ditulIIj+muxM3FJe8+UX1ignLGcGArxJIy+ejyrt2TC/FjW8fxo5dRQTo4E2Ak9nGE 4qt+Xl7Kdyxkwqx1s7DKo/vprTBDwEB/5SXvSTBAiiCgwxb73d0AEAeFyScygmBorKBY ifgXW1ppJEb+6Lc6awVJFyUZJ9r8T1vDWeAPCkJGdnwN1r0zVPnl3ZHEJ3rgKxjLBZYx W12ucdtpmPuw7vImUeIhKREFRj77fgzVXqCAmGN42u/otjrMgubvsFWfrh7ia38bUZi5 hssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=63nF9E0JoauNflUf+1oyiGGf3j4Ef0o1wSxE7efMELg=; b=BEXmjfNOSvMt7F2x5gy/1bD483xZf5MLx62li/tA2v1hahq5eXVoi4cgsKjcOSyLJQ qKzkZwHqsxZB61mTNMYXoBDWAfPbj031Lpc0OB4DOTR/ofBZVBiJVihB2cUcujSuXvLl 2iCoFneFr6ocIFCzEf2isqxCLp4kfbAWCzxSF7w0GFK4WmfuUsGSoNErqOx1npUAuv3X CXDHUOoyxCoqaLe5qE5e/0XPaMPBZaPwWi37/bpCinTOt99d8UoN4+oIjlID9jaJyAzE oM8wwpaqguLGAYg43uuHdMmEfez7uH1OocIgEdA8sFqlPCL2u13CdhSe4+7wNqBVO0Sj z/rw== X-Gm-Message-State: APjAAAUVYSNpc2g8D+am+Hwc5Sw6KXWDCwI3x9Jhu97istzoX6hfK77x mbIAIshset/hd6zzf5Vo24PHCPl48PGk3TVnxOT3qtM= X-Google-Smtp-Source: APXvYqyvYp4RqC0agT+y6UYL3uyO1pHkelu7FHuF6GzTte6AzqBStWYisPzbtWnhjZqnr+YW2x4m6xV7SUX9GRkXkwk= X-Received: by 2002:a19:8093:: with SMTP id b141mr13270051lfd.137.1565364466236; Fri, 09 Aug 2019 08:27:46 -0700 (PDT) MIME-Version: 1.0 References: <20190801111212.5536-1-richard_c_haines@btinternet.com> In-Reply-To: <20190801111212.5536-1-richard_c_haines@btinternet.com> From: Paul Moore Date: Fri, 9 Aug 2019 11:27:35 -0400 Message-ID: Subject: Re: [PATCH V2 0/2] selinux-testsuite: Add BPF tests To: Richard Haines Cc: selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Thu, Aug 1, 2019 at 7:22 AM Richard Haines wrote: > Patch 1 Runs basic checks for BPF with map_create, map_read, map_write, > prog_load and prog_run permissions. > > Patch 2 Updates fdreceive to test BPF security_file_receive() path using > the common BPF code in tests/bpf. > > If these are okay, I'll do the binder BPF tests for the > security_binder_transfer_file() path. Patch 1/2 seems to run fine on my test system, but I'm hitting some errors with patch 2/2 ... although they appear to be gone now that I run the test again to paste the error into my email :/ I'm about to leave for the weekend, and while I have access to email, I don't plan to do much debugging while away ;) I'll take a closer look next week. > Are there any other SELinux BPF areas that need testing ?? I would say as long as you exercise the SELinux BPF access controls we should be good. Thanks for helping with the tests! -- paul moore www.paul-moore.com