selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Hridya Valsaraju <hridya@google.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
	Eric Paris <eparis@parisplace.org>,
	Jeff Vander Stoep <jeffv@google.com>,
	Mark Salyzyn <salyzyn@android.com>,
	selinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-team@android.com
Subject: Re: [PATCH] selinux: Fix typo in filesystem name
Date: Wed, 5 Feb 2020 18:28:44 -0500	[thread overview]
Message-ID: <CAHC9VhR-aUtrU4PTibDLLG2S5GB9bx9MtwKuyH-x9eqSCmyP9w@mail.gmail.com> (raw)
In-Reply-To: <20200202014624.75356-1-hridya@google.com>

On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <hridya@google.com> wrote:
>
> Correct the filesystem name to "binder" to enable
> genfscon per-file labelling for binderfs.
>
> Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> Signed-off-by: Hridya Valsaraju <hridya@google.com>
> ---
>
> Hello,
>
> I seem to have made the typo/mistake during a rebase. Sorry about that
> :(
>
> Thanks,
> Hridya
>
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ooops :/

Thanks for the fix.  I've merged this into selinux/stable-5.6, but due
to some personal scheduling issues on my end I'm going to refrain from
sending this to Linus until next week.

> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 89fe3a805129..d67a80b0d8a8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>
>         if (!strcmp(sb->s_type->name, "debugfs") ||
>             !strcmp(sb->s_type->name, "tracefs") ||
> -           !strcmp(sb->s_type->name, "binderfs") ||
> +           !strcmp(sb->s_type->name, "binder") ||
>             !strcmp(sb->s_type->name, "pstore"))
>                 sbsec->flags |= SE_SBGENFS;
>
> --
> 2.25.0.341.g760bfbb309-goog

-- 
paul moore
www.paul-moore.com

  parent reply	other threads:[~2020-02-05 23:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02  1:46 [PATCH] selinux: Fix typo in filesystem name Hridya Valsaraju
2020-02-03 13:38 ` Stephen Smalley
2020-02-05 23:28 ` Paul Moore [this message]
2020-02-05 23:52   ` Hridya Valsaraju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC9VhR-aUtrU4PTibDLLG2S5GB9bx9MtwKuyH-x9eqSCmyP9w@mail.gmail.com \
    --to=paul@paul-moore.com \
    --cc=eparis@parisplace.org \
    --cc=hridya@google.com \
    --cc=jeffv@google.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=salyzyn@android.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).