From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH testsuite 1/2] check-syntax: use 'command -v' instead of 'which'
Date: Fri, 22 Jan 2021 10:47:27 -0500 [thread overview]
Message-ID: <CAHC9VhR20WJM=KQPuzt6YzSmKbj8hKoCLJg9gESQzt6GXto_Eg@mail.gmail.com> (raw)
In-Reply-To: <20210122102748.38776-2-omosnace@redhat.com>
On Fri, Jan 22, 2021 at 5:46 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> In minimal environments (e.g. Fedora container image) 'which' is not
> installed by default. To avoid the need to install an additional
> dependency, use 'command -v', which also does the trick and is a shell
> builtin.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> ---
> tools/check-syntax | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Nice.
Acked-by: Paul Moore <paul@paul-moore.com>
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2021-01-22 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 10:27 [PATCH testsuite 0/2] Migrate CI to GH Actions Ondrej Mosnacek
2021-01-22 10:27 ` [PATCH testsuite 1/2] check-syntax: use 'command -v' instead of 'which' Ondrej Mosnacek
2021-01-22 15:47 ` Paul Moore [this message]
2021-01-22 10:27 ` [PATCH testsuite 2/2] Migrate CI to GH Actions Ondrej Mosnacek
2021-01-23 9:55 ` [PATCH testsuite 0/2] " Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhR20WJM=KQPuzt6YzSmKbj8hKoCLJg9gESQzt6GXto_Eg@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).