From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>, Kees Cook <keescook@chromium.org>
Cc: selinux@vger.kernel.org,
coverity-bot <keescook+coverity-bot@chromium.org>
Subject: Re: [PATCH] selinux: free str on error in str_read()
Date: Wed, 15 Apr 2020 18:04:53 -0400 [thread overview]
Message-ID: <CAHC9VhRZgntyb4SneJDmpSSvfLYiox1Bz-SYMs6V9ncyCZPqSw@mail.gmail.com> (raw)
In-Reply-To: <20200414142351.162526-1-omosnace@redhat.com>
On Tue, Apr 14, 2020 at 10:25 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> In [see "Fixes:"] I missed the fact that str_read() may give back an
> allocated pointer even if it returns an error, causing a potential
> memory leak in filename_trans_read_one(). Fix this by making the
> function free the allocated string whenever it returns a non-zero value,
> which also makes its behavior more obvious and prevents repeating the
> same mistake in the future.
>
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1461665 ("Resource leaks")
> Fixes: c3a276111ea2 ("selinux: optimize storage of filename transitions")
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> ---
> security/selinux/ss/policydb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
I just merged this into selinux/stable-5.7 and assuming all goes well
in testing I'll send this up to Linus later this week. Thanks Ondrej.
I also want to add my thanks to the "coverity bot", thanks Kees. Are
you only running this only on Linus tree? If it's open to other trees
it might be nice to get the selinux/next branch into the automated
testing.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-04-15 22:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 14:23 [PATCH] selinux: free str on error in str_read() Ondrej Mosnacek
2020-04-14 15:37 ` Kees Cook
2020-04-15 22:04 ` Paul Moore [this message]
2020-04-17 21:47 ` Kees Cook
2020-04-17 22:23 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhRZgntyb4SneJDmpSSvfLYiox1Bz-SYMs6V9ncyCZPqSw@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=keescook+coverity-bot@chromium.org \
--cc=keescook@chromium.org \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).