From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: selinux@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH v2 4/5] selinux: convert cond_expr to array
Date: Thu, 30 Jan 2020 23:22:10 -0500 [thread overview]
Message-ID: <CAHC9VhRo2JhRSJ=2XxF4u5wm1640ycQmJ5H9nLjmw-2N-V9NrQ@mail.gmail.com> (raw)
In-Reply-To: <20200117085836.445797-5-omosnace@redhat.com>
On Fri, Jan 17, 2020 at 3:58 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> Since it is fixed-size after allocation and we know the size beforehand,
> using a plain old array is simpler and more efficient.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> Reviewed-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/ss/conditional.c | 62 ++++++++++++-------------------
> security/selinux/ss/conditional.h | 14 ++++---
> 2 files changed, 33 insertions(+), 43 deletions(-)
This patch looks fine, but since I think you may need to respin at
least one of the earlier patches I'm going to hold off on merging this
for now.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-01-31 4:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 8:58 [PATCH v2 0/5] selinux: Assorted simplifications and cleanups Ondrej Mosnacek
2020-01-17 8:58 ` [PATCH v2 1/5] selinux: simplify evaluate_cond_node() Ondrej Mosnacek
2020-01-17 19:37 ` Stephen Smalley
2020-01-31 3:47 ` Paul Moore
2020-01-17 8:58 ` [PATCH v2 2/5] selinux: convert cond_list to array Ondrej Mosnacek
2020-01-17 19:38 ` Stephen Smalley
2020-01-31 4:05 ` Paul Moore
2020-02-03 9:05 ` Ondrej Mosnacek
2020-01-17 8:58 ` [PATCH v2 3/5] selinux: convert cond_av_list " Ondrej Mosnacek
2020-01-31 4:17 ` Paul Moore
2020-02-03 9:13 ` Ondrej Mosnacek
2020-01-17 8:58 ` [PATCH v2 4/5] selinux: convert cond_expr " Ondrej Mosnacek
2020-01-31 4:22 ` Paul Moore [this message]
2020-01-17 8:58 ` [PATCH v2 5/5] selinux: generalize evaluate_cond_node() Ondrej Mosnacek
2020-01-17 19:39 ` Stephen Smalley
2020-01-31 4:24 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhRo2JhRSJ=2XxF4u5wm1640ycQmJ5H9nLjmw-2N-V9NrQ@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=omosnace@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).