From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D86C433DF for ; Thu, 9 Jul 2020 18:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 740A72080D for ; Thu, 9 Jul 2020 18:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="V78WOIaM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726786AbgGISKL (ORCPT ); Thu, 9 Jul 2020 14:10:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbgGISKK (ORCPT ); Thu, 9 Jul 2020 14:10:10 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D89DCC08C5DC for ; Thu, 9 Jul 2020 11:10:09 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id w6so3269293ejq.6 for ; Thu, 09 Jul 2020 11:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0tpny+IfvksUcNBVh7AI/yK93gIOPfFjHFotjL50OR4=; b=V78WOIaMdW2+HJXmaAk4+l1yyNYhuFDu7Klmt8XO8dTcnxzNsqC2HKNIwBXLTzrkMI eOX6I8fz130icVJrTMuB4tV/V+GMkPPyflPOeNhTSTdoyAFOB0wo8em6imZsoRAvdzZ0 UwmNfjHPbiF4rrtMSxm0QAW1S7R/M2BRqnOPZMEo0ueTEC9Y6IhXC1I0RWyO+Q6qcTtU yOQxC0HlVF3rNbd+UwHxJ+jGbWdwhw+ImFt7Q5XBp5UA6VfV1WrCp8uWo7I+G1SVqU0B gE7XC5KF+hZSla1qgna2zWFsJPej+a5ylJKr9dHpKpq4bMlecSVMnd9UrX1+FIonrg4d BMrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0tpny+IfvksUcNBVh7AI/yK93gIOPfFjHFotjL50OR4=; b=rvxcOrzaZTK8MJRujwy0WGnsGvTsSl3eaPs/5nW03G6RUtqC57f7kV8QU8scfjRxFf E42RTqNmLkIzgzUdzgNkQ2y71P32FOjs2P/BGUtHsSokUkTmwyatIgLGwO93k7PEFnl3 9dsE13KQuHCu41OzpbGmQYmBiZfxKG7961uWnc5BrAZ74TzR55775jHNHGpQLrUAoE0B xbdCc+xkbuEU7ax3mmYEzX8kNab6T3Q3yj8Y2toNXMs6oBc7xekBz2PYQfMcqeZE6ih6 LhVcj/9BLVjR64IJx/lk+T/+YDhFR1rUx6r1qPWouz6SaYKiNoA9a9CrJ+HEUpNVqdqd YV1g== X-Gm-Message-State: AOAM532bErGOguPBl65T0PRlIOyy90UPF+6NPQQP2X+JTzv6JhUKVdlP sk1KhyH3Jz/p+JGEgR2d9joYShsb/iqW1KY6hskHzsgKvA== X-Google-Smtp-Source: ABdhPJyOf27f7rBkDHb/taO3jhGZp1ofl38ev63qsacDu5oyMNiV7flyGxc80dtDZgYb7m/loYb4o2qzRc4QPQV+BSM= X-Received: by 2002:a17:906:4757:: with SMTP id j23mr30313846ejs.431.1594318208476; Thu, 09 Jul 2020 11:10:08 -0700 (PDT) MIME-Version: 1.0 References: <20200709131111.4mqrge6vjsbfs7ls@archlaptop.localdomain> In-Reply-To: <20200709131111.4mqrge6vjsbfs7ls@archlaptop.localdomain> From: Paul Moore Date: Thu, 9 Jul 2020 14:09:57 -0400 Message-ID: Subject: Re: [PATCH] security: selinux: ss: conditional.c fixed a checkpatch warning To: Ethan Edwards Cc: Stephen Smalley , selinux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Thu, Jul 9, 2020 at 9:11 AM Ethan Edwards wrote: > > `sizeof buf` changed to `sizeof(buf)` > > Signed-off-by: Ethan Edwards > --- > security/selinux/ss/conditional.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Why are you reposting this when I applied your original patch last week? https://lore.kernel.org/selinux/CAHC9VhSakA7V99+tkvLLZHohiupWmjSFxSZLWZT4-Gwr5Cc-XA@mail.gmail.com > diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c > index 0cc7cdd58465..90a2f5927e55 100644 > --- a/security/selinux/ss/conditional.c > +++ b/security/selinux/ss/conditional.c > @@ -215,7 +215,7 @@ int cond_read_bool(struct policydb *p, struct hashtab *h, void *fp) > if (!booldatum) > return -ENOMEM; > > - rc = next_entry(buf, fp, sizeof buf); > + rc = next_entry(buf, fp, sizeof(buf)); > if (rc) > goto err; > > @@ -416,7 +416,7 @@ int cond_read_list(struct policydb *p, void *fp) > u32 i, len; > int rc; > > - rc = next_entry(buf, fp, sizeof buf); > + rc = next_entry(buf, fp, sizeof(buf)); > if (rc) > return rc; > > -- > 2.27.0 > -- paul moore www.paul-moore.com