From: Paul Moore <paul@paul-moore.com>
To: Paulo Alcantara <paulo@paulo.ac>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH] selinux: use kernel linux/socket.h definitions for PF_MAX
Date: Wed, 27 Feb 2019 12:35:50 -0500 [thread overview]
Message-ID: <CAHC9VhSaMcD232ZzXuS16usQL2DHSZRy5JqtFZWkjV+h6eUztw@mail.gmail.com> (raw)
In-Reply-To: <87y36170y2.fsf@paulo.ac>
On Wed, Feb 27, 2019 at 12:07 PM Paulo Alcantara <paulo@paulo.ac> wrote:
> Paulo Alcantara <paulo@paulo.ac> writes:
> > When compiling genheaders and mdp from a newer host kernel, the
> > following error happens:
> >
> > In file included from scripts/selinux/genheaders/genheaders.c:18:
> > ./security/selinux/include/classmap.h:238:2: error: #error New
> > address family defined, please update secclass_map. #error New
> > address family defined, please update secclass_map. ^~~~~
> > make[3]: *** [scripts/Makefile.host:107:
> > scripts/selinux/genheaders/genheaders] Error 1 make[2]: ***
> > [scripts/Makefile.build:599: scripts/selinux/genheaders] Error 2
> > make[1]: *** [scripts/Makefile.build:599: scripts/selinux] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> >
> > Instead of relying on the host definition, include linux/socket.h in
> > classmap.h to have PF_MAX.
> >
> > Signed-off-by: Paulo Alcantara <paulo@paulo.ac>
> > ---
> > scripts/selinux/genheaders/genheaders.c | 1 -
> > scripts/selinux/mdp/mdp.c | 1 -
> > security/selinux/include/classmap.h | 1 +
> > 3 files changed, 1 insertion(+), 2 deletions(-)
>
> Ping?
>
> Could someone please take a look at this issue?
It looks fine to me, but I typically don't merge patches this late in
the development window (we are at -rc8), unless it is a serious bug
fix.
> It's quite easy to reproduce on my host (4.20+) when building an
> unpatched 4.14 kernel ...
While this is a good patch that does fix a real but, the fact that it
has been broken for several releases tells me this is not a serious
bug and not likely worth the risk for the upcoming merge window
(however small it may be). There has been a lot of good work put into
mdp very recently, and I expect to merge that, as well as your fix,
once the upcoming merge window closes.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2019-02-27 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 0:55 [PATCH] selinux: use kernel linux/socket.h definitions for PF_MAX Paulo Alcantara
2019-02-27 14:36 ` Paulo Alcantara
2019-02-27 17:35 ` Paul Moore [this message]
2019-02-27 17:43 ` Paulo Alcantara
2019-03-18 22:58 ` Paul Moore
2019-02-27 17:23 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhSaMcD232ZzXuS16usQL2DHSZRy5JqtFZWkjV+h6eUztw@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=paulo@paulo.ac \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).