From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE01CCA480 for ; Wed, 20 Jul 2022 14:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240836AbiGTOwi (ORCPT ); Wed, 20 Jul 2022 10:52:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240800AbiGTOwh (ORCPT ); Wed, 20 Jul 2022 10:52:37 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA8BD1ADBA for ; Wed, 20 Jul 2022 07:52:35 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id d16so26457437wrv.10 for ; Wed, 20 Jul 2022 07:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PUMNzOcke9F/E6l0+nSlaEl2q/BLzsi49G5O8oR/nQk=; b=05e5XLBmfccOHOTn5Xi23vWg8lqNJPD/R1R0dBx9OAM6rEtAjGyDb7fFMs3y3i/7oD /Ok5WoBVNnLuPSv+vaxNoWo7ozHczx628+bmwDooSBy4Ell7vhkiyYtko7XwBb+kbr/R BAjORV2J0Is7Zf5la7TDJ8tdimEtSTjqnhLmTWTo+VkhDV2SDH+8N+fLRE2KY7wZfezY T+8JyFzZ6P9hW/0ZmdZZ/B/Uv/FqGJI9SKb0Tf0iLP0d+exKHiujMl9frRdeNNWZHTAH i9rgvXBSrNV3XeYyu2mF/sA2JpA/OlBjHP/f6HQ3JwqaawYdWHZ7Uly6ofxMlSylDhlx Vy5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PUMNzOcke9F/E6l0+nSlaEl2q/BLzsi49G5O8oR/nQk=; b=NBpGs6eUnPd/n/fY7lWGk+msdE7iDVk7XbbnXKrV910JKQ71cw5afPRo4rR5ybzohE 4Ppc66yIMtrdoaGkMThtqYPIKR2yOk0cT40vNfIBnqqDuqtOWaHbX10iQOu2gfDWVqzw xWWLAJ+8ORjXsmQtBcY4+YNYJqS0jRfsxabYrn8MT75vmwc2lNxCn3siYr7OYfqJUrXQ N1MhKRlZDGEUs4ImEk2o1tmwXXDQrcctobbmPEQB+9JuG9Y0xWYXGxzuc3aq5xt0zFNb 0kvnGP/uWhyqHq+AmVTWXmCFl4qrZq3kF/M2CB+ipyzeQLfe+zLPNxQavUzxgEM65wiS QD8Q== X-Gm-Message-State: AJIora8CErk488NrNwrihr2QF2ROUVU233G0bJx56Scm3nA9gzr26Gjc gOVEsInR5+mVBqDlgV/Cdm3WUoJdkHW3NhGlNOFn X-Google-Smtp-Source: AGRyM1vRgjFuWdos6HfR4YAkcb84ehTx76Uq4a7TaHyarDjXm0pNXoiIf0CYV/zUZqhGSCYFaueGHUufPPeJ3RbZVR0= X-Received: by 2002:a5d:4f8f:0:b0:21e:4f09:9e15 with SMTP id d15-20020a5d4f8f000000b0021e4f099e15mr1313451wru.55.1658328754216; Wed, 20 Jul 2022 07:52:34 -0700 (PDT) MIME-Version: 1.0 References: <20220707223228.1940249-1-fred@cloudflare.com> <20220707223228.1940249-5-fred@cloudflare.com> In-Reply-To: From: Paul Moore Date: Wed, 20 Jul 2022 10:52:23 -0400 Message-ID: Subject: Re: [PATCH v2 4/4] selinux: Implement create_user_ns hook To: Karl MacMillan Cc: Frederick Lawler , andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, brauner@kernel.org, casey@schaufler-ca.com, daniel@iogearbox.net, ebiederm@xmission.com, eparis@parisplace.org, jackmanb@chromium.org, jmorris@namei.org, john.fastabend@gmail.com, kafai@fb.com, kernel-team@cloudflare.com, kpsingh@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, revest@chromium.org, selinux@vger.kernel.org, serge@hallyn.com, shuah@kernel.org, songliubraving@fb.com, stephen.smalley.work@gmail.com, yhs@fb.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Tue, Jul 19, 2022 at 10:42 PM Karl MacMillan wrote: > On Thu, Jul 7, 2022 at 6:34 PM Frederick Lawler wro= te: >> >> Unprivileged user namespace creation is an intended feature to enable >> sandboxing, however this feature is often used to as an initial step to >> perform a privilege escalation attack. >> >> This patch implements a new namespace { userns_create } access control >> permission to restrict which domains allow or deny user namespace >> creation. This is necessary for system administrators to quickly protect >> their systems while waiting for vulnerability patches to be applied. >> >> This permission can be used in the following way: >> >> allow domA_t domB_t : namespace { userns_create }; > > > Isn=E2=80=99t this actually domA_t domA_t : namespace . . . > > I got confused reading this initially trying to figure out what the secon= d domain type would be, but looking at the code cleared that up. Ah, good catch, thanks Karl! --=20 paul-moore.com