From: Paul Moore <paul@paul-moore.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Ondrej Mosnacek <omosnace@redhat.com>,
SElinux list <selinux@vger.kernel.org>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Daniel Walsh <dwalsh@redhat.com>,
Zdenek Pytela <zpytela@redhat.com>,
virtio-fs-list <virtio-fs@redhat.com>,
Miklos Szeredi <mszeredi@redhat.com>
Subject: Re: virtiofs and its optional xattr support vs. fs_use_xattr
Date: Tue, 8 Dec 2020 18:41:17 -0500 [thread overview]
Message-ID: <CAHC9VhTHXxZRKaUybvLzPMFLP08co9e6yNjB3upVJyCPbh3=+g@mail.gmail.com> (raw)
In-Reply-To: <20201207205209.GD3107@redhat.com>
On Mon, Dec 7, 2020 at 3:52 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> On Mon, Dec 07, 2020 at 10:03:24AM -0500, Paul Moore wrote:
> > On Mon, Dec 7, 2020 at 9:43 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> > >
> > > Hi everyone,
> > >
> > > In [1] we ran into a problem with the current handling of filesystem
> > > labeling rules. Basically, it is only possible to specify either
> > > genfscon or fs_use_xattr for a given filesystem, but in the case of
> > > virtiofs, certain mounts may support security xattrs, while other ones
> > > may not.
>
> [ cc virtio-fs list and miklos ]
> > Quickly skimming the linked GH issue, it appears that the problem
> > really lies in the fact that virtiofs allows one to enable/disable
> > xattrs at mount time. What isn't clear to me is why one would need to
> > disable xattrs, can you explain that use case? Why does enabling
> > xattrs in virtiofs cause problems?
>
> Its not exactly a mount time option. Its a virtiofs file server option.
>
> xattr support by default is disabled because it has performance
> penalty. Users can enable it if they want to.
Oh the number of sins against security that have been committed under
the banner of performance! ;)
Regardless, thanks for the explanation, that helps.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-12-08 23:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 14:42 virtiofs and its optional xattr support vs. fs_use_xattr Ondrej Mosnacek
2020-12-07 15:03 ` Paul Moore
2020-12-07 20:52 ` Vivek Goyal
2020-12-07 21:22 ` Dominick Grift
2020-12-08 14:33 ` Vivek Goyal
2020-12-08 15:13 ` Dominick Grift
2020-12-08 23:41 ` Paul Moore [this message]
2020-12-07 17:17 ` James Carter
2020-12-08 23:45 ` Paul Moore
2020-12-09 15:37 ` James Carter
2020-12-10 2:39 ` Paul Moore
2020-12-10 9:29 ` Ondrej Mosnacek
2020-12-10 22:17 ` Vivek Goyal
2020-12-10 22:24 ` Ondrej Mosnacek
2020-12-10 22:30 ` Vivek Goyal
2020-12-11 9:15 ` Ondrej Mosnacek
2020-12-11 13:29 ` Vivek Goyal
2021-01-04 20:14 ` Vivek Goyal
2021-01-05 14:00 ` Ondrej Mosnacek
2021-01-05 14:21 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhTHXxZRKaUybvLzPMFLP08co9e6yNjB3upVJyCPbh3=+g@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=dwalsh@redhat.com \
--cc=mszeredi@redhat.com \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--cc=zpytela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).