From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A5D8C43387 for ; Thu, 10 Jan 2019 00:54:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 098ED214DA for ; Thu, 10 Jan 2019 00:54:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="uqs0aoLh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbfAJAyb (ORCPT ); Wed, 9 Jan 2019 19:54:31 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:37749 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfAJAyb (ORCPT ); Wed, 9 Jan 2019 19:54:31 -0500 Received: by mail-lf1-f65.google.com with SMTP id y11so7072774lfj.4 for ; Wed, 09 Jan 2019 16:54:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=whQTbq+D2SNbxG+9U732P/FdMekb35BbA4EKj0dp34s=; b=uqs0aoLhxVABXGYbNXR6KIc8b0zWMHpQ3q98ELUgWlUSGCaBA+632UThdlyNS3G0kb l3FKQVKbQOkl/ITslw0eK68IJg1C0dwOxBE4g6ppoUQaCaAmDwwV5ry0gfFeinY1ZQfu agtspiX+bRmHhsx5/YFAjJKMWpSFgImgRqKv+SbZGUbyOA5ueFBCRO4INJzMMdzv5djf K6aeHR4qe5cyy8kAkCEwBd9aoq0EvLNnXzVg6BHJcHRQBhrS06Lp1ql+yQcOvQ+khiDz +QVEMkrLG2FdFEvhLbeYPec7WF+muA1Eqgt8kfwAMGe7aXQ88sNZOMMhfFr5TTBqBiYs sOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=whQTbq+D2SNbxG+9U732P/FdMekb35BbA4EKj0dp34s=; b=inIiol2jUE8Vhxean35B6LEA0Gnnj+MIvxa5Xy+Ng02KqdZ4Ke9Tt/3QEZKapToWaI oE6Rti9cqv86wVkk4t/wuuq1V656ahivYO/diLPE5Gk3xajrgYJY9jg7Tu4bmW/bloZs YLaOhmSjWzRuxtHox8+NdtFoeeTWpLWB/aEVoe1ZF21dG3Ll7l0oW4/OztSmEZlqlvmM h3wkeVLi9Y2r7Lief+6D++dHH+GPLCn9b3Z1UH/CtkGAXqtZYjBRUqFWxeq66dDBKJ3y 3kNlXviHetRFFy1xZaDbdyWTE34KVLY89i997gSZnZyzpCgOk24aPv6hmA9lmRQLnqf/ 3Kkw== X-Gm-Message-State: AJcUukf1npVMvWoRlmMtlSLTEmb7aZ2kgp4OJi2LsauEsLwTGAvSFvF7 j/r398ouCLiD5PkPRWMiq8hHwN5ppMar/fWg2XUJsdzSqw== X-Google-Smtp-Source: ALg8bN5gl/8+9SwFBOGo4rlpklrR6vLFH0rSEdhtistndhAn9hlVjPUENXxRc1I06AXuAOqfgTZV6zL1ezQ8oh8Y80c= X-Received: by 2002:a19:a40f:: with SMTP id q15mr2403509lfc.4.1547081669323; Wed, 09 Jan 2019 16:54:29 -0800 (PST) MIME-Version: 1.0 References: <1546593547-24406-1-git-send-email-peng.hao2@zte.com.cn> In-Reply-To: <1546593547-24406-1-git-send-email-peng.hao2@zte.com.cn> From: Paul Moore Date: Wed, 9 Jan 2019 19:54:18 -0500 Message-ID: Subject: Re: [PATCH] security/selinux/hooks: remove unneeded semicolon To: Peng Hao Cc: Stephen Smalley , Eric Paris , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, selinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Thu, Jan 3, 2019 at 7:55 PM Peng Hao wrote: > > Remove unneeded semicolon. > > Signed-off-by: Peng Hao > --- > security/selinux/hooks.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index a67459e..73c679e 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -1263,7 +1263,7 @@ static void selinux_write_opts(struct seq_file *m, > default: > BUG(); > return; > - }; > + } > /* we need a comma before each option */ > seq_putc(m, ','); > seq_puts(m, prefix); Thank you for your patch, but the selinux_write_opts() function was just removed in v5.0-rc1 in commit e3489f8974e1 ("selinux: kill selinux_sb_get_mnt_opts()"). -- paul moore www.paul-moore.com