selinux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Christian Göttsche" <cgzones@googlemail.com>
To: selinux@vger.kernel.org
Subject: src:shadow: dropping passwd shortcut
Date: Thu, 17 Oct 2019 23:24:42 +0200	[thread overview]
Message-ID: <CAJ2a_Dc6KDDgkZ4KmGf0oDR0X8q8Ve0Typ7x9RcEp-dbhcHeeA@mail.gmail.com> (raw)

Hi,
I am working to migrate src:shadow to today's SELinux api as
previously mentioned.
Currently there is a shortcut in the passwd check:

If user root tries to change a password for another user AND the
user-identity part (before first colon) of the previous (exec-wise)
context equals the username in question, no SELinux check is
performed.

Stephen suggested to drop this logic as nowadays SELinux
user-identities rarely matches usernames and we only skip is simple
passwd:passwd check.

So I'd like to announce that this logic is probably going to be removed.

Kind regards,
     Christian Göttsche

p.s.:
in fedoras passwd, the logic does not exist:
https://pagure.io/passwd/blob/master/f/selinux_utils.c

                 reply	other threads:[~2019-10-17 21:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ2a_Dc6KDDgkZ4KmGf0oDR0X8q8Ve0Typ7x9RcEp-dbhcHeeA@mail.gmail.com \
    --to=cgzones@googlemail.com \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).