Re: [v4] Annotate Deprecated Functions in libselinux

From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: Petr Lautrbach <plautrba@redhat.com>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	SElinux list <selinux@vger.kernel.org>
Subject: Re: [v4] Annotate Deprecated Functions in libselinux
Date: Tue, 28 Apr 2020 23:25:12 +0200	[thread overview]
Message-ID: <CAJfZ7===D-jb_OGnMjyZw4JLx-=hCwUBHChHBK9h=rvwfgN15g@mail.gmail.com> (raw)
In-Reply-To: <20200427202315.4943-1-william.c.roberts@intel.com>

On Mon, Apr 27, 2020 at 10:23 PM <bill.c.roberts@gmail.com> wrote:
>
> V4:
> - Drop the internal header interfaces, they were unused and pointless.
>
> V3:
> - Made the deprecated annotation dependent on __GNUC__ like
>   the __format__(printf,...) specifiers. This will allow these
>   not be defined when swig is building, so this will fix the
>   swig syntax issues.
> - Swig's build flags include -Wno-deprecated-declarations becuase the
>   bindings need to pull the fill API out, even deprecated functions.
> - Rather than compile matchpathcon with static selinux, I just set its
>   compile flags to include -Wno-deprecated-declarations. Essentially
>   saying, yes use this old interface it's Ok in this instance.
>
> V2:
> - Simplified now that dso.h stuff has been removed.
> - selinux_check_passwd_access has been deprecated and now
>   both selinux_check_passwd_access and checkPasswdAccess
>   are recomending selinux_check_access.
> - matchpathcon is linked statically to get access to deprecated
>   routines and prints a deprecated warning to stderr.
>
> V1:
> I went through and annotated deprecated routines we have in
> libselinux that are mentioned to be deprecated either in code
> comments and/or manpages.
>
> External users, when compiling will see a warning similair to some
> sample output:
>
> a.c: In function ‘main’:
> a.c:18:2: warning: ‘foo’ is deprecated: foo bar msg [-Wdeprecated-declarations]
>   foo();
>   ^~~
> a.c:5:5: note: declared here
>  int foo(void) {
>       ^~~
> a.c:19:2: warning: ‘boo’ is deprecated [-Wdeprecated-declarations]
>   boo();
>   ^~~
> a.c:11:5: note: declared here
>  int boo(void) {
>
> [PATCH v4 01/18] security_load_booleans: update return comment
> [PATCH v4 02/18] security_load_booleans: annotate deprecated
> [PATCH v4 03/18] selinux_booleans_path: annotate deprecated
> [PATCH v4 04/18] selinux_users_path: annotate deprecated
> [PATCH v4 05/18] rpm_execcon: annotate deprecated
> [PATCH v4 06/18] sidget: annotate deprecated
> [PATCH v4 07/18] sidput: annotate deprecated
> [PATCH v4 08/18] checkPasswdAccess: annotate deprecated
> [PATCH v4 09/18] matchpathcon_init: annotate deprecated
> [PATCH v4 10/18] matchpathcon_fini: annotate deprecated
> [PATCH v4 11/18] matchpathcon: annotate deprecated
> [PATCH v4 12/18] avc_init: annotate deprecated
> [PATCH v4 13/18] avc: create internal avc_init interface
> [PATCH v4 14/18] matchpathcon: create internal matchpathcon_fini
> [PATCH v4 15/18] selinux_check_passwd_access: annotate deprecated
> [PATCH v4 16/18] matchpathcon: allow use of deprecated routines
> [PATCH v4 17/18] utils: matchpathcon add deprecated warning
> [PATCH v4 18/18] Makefile: swig build allow deprecated functions

Hello,
Thanks for this v4. Some commit descriptions still use "...2" instead
of "..._internal", but I do not think this needs to be fixed in
another iteration, because the patches look otherwise good to me.

Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>

Feel free to apply them (eventually with fixed descriptions).
Otherwise I will apply them tomorrow.
Nicolas