From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext
Date: Sat, 2 Nov 2019 18:23:15 +0100 [thread overview]
Message-ID: <CAJfZ7=kQ42uknUJL3NX7LyLcpYSX-bR47ndE+puqpgtRKL1ggw@mail.gmail.com> (raw)
In-Reply-To: <CAJfZ7==Y0vw1nXR=qH-SETcwMyaF08L0ygputGFp1AAKV+opTw@mail.gmail.com>
On Fri, Nov 1, 2019 at 10:22 AM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> On Fri, Oct 25, 2019 at 3:42 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> >
> > Using $(DESTDIR) during the build does not follow the normal/standard
> > semantic of DESTDIR: it is normally only needed during the
> > installation. Therefore, a lot of build systems/environments don't
> > pass any DESTDIR at build time, which causes setup.py to be called
> > with -I /usr/include -L /usr/lib, which breaks cross-compilation.
> >
> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> This patch looks good to me. It does not seem to break the build
> configurations that I am using and fixes a real issue. If nobody
> complains, I will merge it (without the 2 other patches) tomorrow.
>
> Acked-by: Nicolas Iooss <nicolas.iooss@m4x.org>
>
> Thanks!
Applied.
Nicolas
> > ---
> > libselinux/src/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libselinux/src/Makefile b/libselinux/src/Makefile
> > index 2b1696a0..3b8bad81 100644
> > --- a/libselinux/src/Makefile
> > +++ b/libselinux/src/Makefile
> > @@ -130,7 +130,7 @@ SWIGRUBY = swig -Wall -ruby -o $(SWIGRUBYCOUT) -outdir ./ $(DISABLE_FLAGS)
> > all: $(LIBA) $(LIBSO) $(LIBPC)
> >
> > pywrap: all selinuxswig_python_exception.i
> > - CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext -I $(DESTDIR)$(INCLUDEDIR) -L $(DESTDIR)$(LIBDIR)
> > + CFLAGS="$(CFLAGS) $(SWIG_CFLAGS)" $(PYTHON) setup.py build_ext
> >
> > rubywrap: all $(SWIGRUBYSO)
> >
> > --
> > 2.21.0
> >
prev parent reply other threads:[~2019-11-02 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 13:41 [PATCH libselinux] libselinux/src/Makefile: don't pass bogus -I and -L to python setup.py build_ext Thomas Petazzoni
2019-11-01 9:22 ` Nicolas Iooss
2019-11-02 17:23 ` Nicolas Iooss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfZ7=kQ42uknUJL3NX7LyLcpYSX-bR47ndE+puqpgtRKL1ggw@mail.gmail.com' \
--to=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).