SELinux Archive on lore.kernel.org
 help / color / Atom feed
From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: William Roberts <bill.c.roberts@gmail.com>
Cc: SElinux list <selinux@vger.kernel.org>,
	William Roberts <william.c.roberts@intel.com>,
	Paul Moore <paul@paul-moore.com>
Subject: Re: [PATCH v2] ci: run SELinux kernel test suite
Date: Fri, 22 May 2020 21:07:30 +0200
Message-ID: <CAJfZ7=mEC4hHT8AdPGhO7RoX+DUrO2y+7g_3OX-W2y09+uKKMA@mail.gmail.com> (raw)
In-Reply-To: <CAFftDdpDpAw6W0d6OaCcaWYSO6g_zguO-D8u+fLYAW45nyGukA@mail.gmail.com>

On Fri, May 22, 2020 at 12:39 AM William Roberts
<bill.c.roberts@gmail.com> wrote:
>
> <snip>
> > * fedora-test-runner.sh uses ~, which is expanded to /root as it does
> > not make sense to run this script as non-root user. In my humble
> > opinion, using /root instead of ~ makes the script even easier to
> > read.
>
> I forgot to mention this in my previous email, this is the only thing
> I really don't
> want to change. You could, in theory, configure any user to run this.
>
> <snip>

The script executes "setenforce 0", runs dnf to install packages and
overwrites binaries and libraries in system directories (/usr/bin,
/usr/sbin, /usr/lib64, etc.). How do you allow any user to perform
these actions, without being root?

Anyway, if you do not want to hardcode /root, to could use "$HOME"
instead of ~. It makes things appear less magical, in my humble
opinion.

Nicolas


  reply index

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 15:14 Travis CI: Run selinux-testsuite bill.c.roberts
2020-05-19 15:14 ` [PATCH] ci: run SE Linux kernel test suite bill.c.roberts
2020-05-19 22:00   ` Paul Moore
2020-05-19 22:16     ` William Roberts
2020-05-19 22:23       ` Paul Moore
2020-05-20 15:13         ` William Roberts
2020-05-20 15:20           ` William Roberts
2020-05-19 21:41 ` Travis CI: Run selinux-testsuite Paul Moore
2020-05-20 16:34   ` [v2] " bill.c.roberts
2020-05-20 16:34     ` [PATCH v2] ci: run SELinux kernel test suite bill.c.roberts
2020-05-21  8:50       ` Ondrej Mosnacek
2020-05-21 12:52         ` Stephen Smalley
2020-05-21 12:58           ` Ondrej Mosnacek
2020-05-21 14:11             ` William Roberts
2020-05-22  7:40               ` Ondrej Mosnacek
2020-05-24 16:18                 ` William Roberts
2020-05-29 13:24                   ` Stephen Smalley
2020-05-29 15:33                     ` William Roberts
2020-05-21 19:54       ` Nicolas Iooss
2020-05-21 20:52         ` William Roberts
2020-05-21 22:39         ` William Roberts
2020-05-22 19:07           ` Nicolas Iooss [this message]
2020-05-23  0:21             ` William Roberts
2020-05-29 18:42       ` Ondrej Mosnacek
2020-05-29 19:17         ` William Roberts
2020-05-20 16:56     ` [v2] Travis CI: Run selinux-testsuite Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfZ7=mEC4hHT8AdPGhO7RoX+DUrO2y+7g_3OX-W2y09+uKKMA@mail.gmail.com' \
    --to=nicolas.iooss@m4x.org \
    --cc=bill.c.roberts@gmail.com \
    --cc=paul@paul-moore.com \
    --cc=selinux@vger.kernel.org \
    --cc=william.c.roberts@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

SELinux Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/selinux/0 selinux/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 selinux selinux/ https://lore.kernel.org/selinux \
		selinux@vger.kernel.org
	public-inbox-index selinux

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.selinux


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git