From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: Petr Lautrbach <plautrba@redhat.com>
Cc: selinux@vger.kernel.org
Subject: Re: [PATCH 2/3] libselinux: Fix RESOURCE_LEAK defects reported by coverity scan
Date: Thu, 31 Jan 2019 22:47:43 +0100 [thread overview]
Message-ID: <CAJfZ7=mO29pHKvNH7r6WWabyNth=nJboYU1rP4DpW5E41Q_YQQ@mail.gmail.com> (raw)
In-Reply-To: <20190131132226.19030-2-plautrba@redhat.com>
On Thu, Jan 31, 2019 at 2:22 PM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
> ---
> libselinux/src/checkAccess.c | 4 +++-
> libselinux/src/label_db.c | 3 +++
> libselinux/src/label_file.c | 4 +++-
> libselinux/src/load_policy.c | 4 +++-
> libselinux/src/selinux_config.c | 17 +++++++++--------
> libselinux/src/selinux_restorecon.c | 12 ++++++++++--
> 6 files changed, 31 insertions(+), 13 deletions(-)
>
> diff --git a/libselinux/src/checkAccess.c b/libselinux/src/checkAccess.c
> index 8de57477..16bfcfb6 100644
> --- a/libselinux/src/checkAccess.c
> +++ b/libselinux/src/checkAccess.c
> @@ -89,8 +89,10 @@ int selinux_check_passwd_access(access_vector_t requested)
> int retval;
>
> passwd_class = string_to_security_class("passwd");
> - if (passwd_class == 0)
> + if (passwd_class == 0) {
> + freecon(user_context);
> return 0;
> + }
>
> retval = security_compute_av_raw(user_context,
> user_context,
> diff --git a/libselinux/src/label_db.c b/libselinux/src/label_db.c
> index c46d0a1d..fa481e04 100644
> --- a/libselinux/src/label_db.c
> +++ b/libselinux/src/label_db.c
> @@ -283,10 +283,12 @@ db_init(const struct selinux_opt *opts, unsigned nopts,
> }
> if (fstat(fileno(filp), &sb) < 0) {
> free(catalog);
> + fclose(filp);
> return NULL;
> }
> if (!S_ISREG(sb.st_mode)) {
> free(catalog);
> + fclose(filp);
> errno = EINVAL;
> return NULL;
> }
Please indent with tabs instead of spaces, like the other lines.
All the other changes in this patch look good to me.
Nicolas
next prev parent reply other threads:[~2019-01-31 21:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 13:22 [PATCH 1/3] libsepol: Fix RESOURCE_LEAK defects reported by coverity scan Petr Lautrbach
2019-01-31 13:22 ` [PATCH 2/3] libselinux: " Petr Lautrbach
2019-01-31 21:47 ` Nicolas Iooss [this message]
2019-02-06 20:33 ` [PATCH v2] " Petr Lautrbach
2019-02-06 22:40 ` Nicolas Iooss
2019-02-10 18:32 ` Nicolas Iooss
2019-01-31 13:22 ` [PATCH 3/3] libsemanage: Fix USE_AFTER_FREE " Petr Lautrbach
2019-01-31 21:57 ` Nicolas Iooss
2019-02-01 12:45 ` Petr Lautrbach
2019-01-31 21:17 ` [PATCH 1/3] libsepol: Fix RESOURCE_LEAK " Nicolas Iooss
2019-02-01 18:19 ` [Non-DoD Source] " jwcart2
2019-01-31 21:33 ` Nicolas Iooss
2019-02-01 19:32 ` [Non-DoD Source] " jwcart2
2019-02-01 20:07 ` [Non-DoD Source] " jwcart2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfZ7=mO29pHKvNH7r6WWabyNth=nJboYU1rP4DpW5E41Q_YQQ@mail.gmail.com' \
--to=nicolas.iooss@m4x.org \
--cc=plautrba@redhat.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).