From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38D65C433E1 for ; Tue, 21 Jul 2020 06:41:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1BEE22080D for ; Tue, 21 Jul 2020 06:41:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726152AbgGUGln (ORCPT ); Tue, 21 Jul 2020 02:41:43 -0400 Received: from mx1.polytechnique.org ([129.104.30.34]:46352 "EHLO mx1.polytechnique.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgGUGln (ORCPT ); Tue, 21 Jul 2020 02:41:43 -0400 X-Greylist: delayed 329 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jul 2020 02:41:42 EDT Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ssl.polytechnique.org (Postfix) with ESMTPSA id C2BBD564DDC for ; Tue, 21 Jul 2020 08:36:11 +0200 (CEST) Received: by mail-oi1-f182.google.com with SMTP id r8so16360843oij.5 for ; Mon, 20 Jul 2020 23:36:11 -0700 (PDT) X-Gm-Message-State: AOAM5325PKjw5TDCr5bbK4zWytuRgW8xKAG1BZs5CEIk/Fe0s2j9W8Gs WgTdoAgQjn1sv8gdaWpAl0JantpHKwTmAzZPJp4= X-Google-Smtp-Source: ABdhPJy/2mjDzVlvfz0oTgMRGWJ3QTAIGjZ55u0Z7qKOllATToWobOdWtPVnJQ2mj6dE2FjS8hZDD+/sVUcHU7VeI7s= X-Received: by 2002:aca:72ca:: with SMTP id p193mr1925243oic.20.1595313370721; Mon, 20 Jul 2020 23:36:10 -0700 (PDT) MIME-Version: 1.0 References: <51d7bd5e067978ea5340ee408a7329e8b921b372.camel@flyn.org> In-Reply-To: From: Nicolas Iooss Date: Tue, 21 Jul 2020 08:35:59 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] python/audit2allow: add #include to sepolgen-ifgen-attr-helper.c To: "W. Michael Petullo" Cc: SElinux list Content-Type: text/plain; charset="UTF-8" X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Tue Jul 21 08:36:12 2020 +0200 (CEST)) X-Org-Mail: nicolas.iooss.2010@polytechnique.org Sender: selinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org On Sun, Jul 19, 2020 at 6:43 PM Nicolas Iooss wrote: > > On Thu, Jul 16, 2020 at 10:39 PM W. Michael Petullo wrote: > > > > I found that building on OpenWrt/musl failed with: > > > > sepolgen-ifgen-attr-helper.c:152:16: error: 'PATH_MAX' undeclared ... > > > > Musl is less "generous" than glibc in recursively including header > > files, and I suspect this is the reason for this error. Explicitly > > including limits.h fixes the problem. > > > > Signed-off-by: W. Michael Petullo > > --- > > python/audit2allow/sepolgen-ifgen-attr-helper.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/python/audit2allow/sepolgen-ifgen-attr-helper.c > > b/python/audit2allow/sepolgen-ifgen-attr-helper.c > > index 53f20818..f010c958 100644 > > --- a/python/audit2allow/sepolgen-ifgen-attr-helper.c > > +++ b/python/audit2allow/sepolgen-ifgen-attr-helper.c > > @@ -28,6 +28,7 @@ > > > > #include > > > > +#include > > #include > > #include > > #include > > -- > > 2.26.2 > > Looks good to me. Nevertheless I had some trouble applying your patch > using "git am" because your message contained > "b/python/audit2allow/sepolgen-ifgen-attr-helper.c" on a new line. Did > you use "git send-email" or something similar, to send your patch? > > Acked-by: Nicolas Iooss > > If nobody complains, I will apply this patch tomorrow. Applied. Thanks, Nicolas