From: James Morris <jmorris@namei.org>
To: Aaron Goidel <acgoide@tycho.nsa.gov>
Cc: paul@paul-moore.com, rgb@redhat.com, mortonm@chromium.org,
john.johansen@canonical.com, selinux@vger.kernel.org,
luto@amacapital.net, linux-security-module@vger.kernel.org,
linux-audit@redhat.com, nhfran2@tycho.nsa.gov, serge@hallyn.com,
sds@tycho.nsa.gov
Subject: Re: [RFC PATCH v3] security,capability: pass object information to security_capable
Date: Fri, 16 Aug 2019 08:32:12 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1908160817300.22623@namei.org> (raw)
In-Reply-To: <20190815202357.4238-1-acgoide@tycho.nsa.gov>
On Thu, 15 Aug 2019, Aaron Goidel wrote:
> In SELinux this new information is leveraged here to perform an
> additional inode based check for capabilities relevant to inodes. Since
> the inode provided to capable_wrt_inode_uidgid() is a const argument,
> this also required propagating const down to dump_common_audit_data() and
> dropping the use of d_find_alias() to find an alias for the inode. This
> was sketchy to begin with and should be obsoleted by a separate change
> that will allow LSMs to trigger audit collection for all file-related
> information.
Will the audit logs look the same once the 2nd patch is applied? We need
to be careful about breaking existing userland.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-08-15 22:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 20:23 [RFC PATCH v3] security,capability: pass object information to security_capable Aaron Goidel
2019-08-15 22:32 ` James Morris [this message]
2019-08-16 14:57 ` [RFC PATCH v3] security, capability: " Stephen Smalley
2019-08-16 16:36 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1908160817300.22623@namei.org \
--to=jmorris@namei.org \
--cc=acgoide@tycho.nsa.gov \
--cc=john.johansen@canonical.com \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mortonm@chromium.org \
--cc=nhfran2@tycho.nsa.gov \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).